clippy: Consolidate many lints in maint/add_warning

Found these by disabling the nightly dbg macro special case.  Now, we
have a mechanism for globally adding suppressions to tests, we can use
that instead.

clippy-nightly.toml

@@ -3,4 +3,5 @@
 # We must edit the tree, this way, sadly:
 #   https://github.com/rust-lang/rust-clippy/issues/8973
 
-allow-dbg-in-tests = true
+# (currently we do not need tohave anything here; everything is dealt with
+# by suppressions maintained by maint/add_warning)

crates/arti-client/examples/advanced_isolation.rs

@@ -1,4 +1,7 @@
 // @@ begin test lint list maintained by maint/add_warning @@
+#![allow(clippy::bool_assert_comparison)]
+#![allow(clippy::clone_on_copy)]
+#![allow(clippy::dbg_macro)]
 #![allow(clippy::print_stderr)]
 #![allow(clippy::print_stdout)]
 #![allow(clippy::unwrap_used)]

crates/arti-client/examples/hook-tcp.rs

@@ -1,4 +1,7 @@
 // @@ begin test lint list maintained by maint/add_warning @@
+#![allow(clippy::bool_assert_comparison)]
+#![allow(clippy::clone_on_copy)]
+#![allow(clippy::dbg_macro)]
 #![allow(clippy::print_stderr)]
 #![allow(clippy::print_stdout)]
 #![allow(clippy::unwrap_used)]

crates/arti-client/examples/lazy-init.rs

@@ -1,4 +1,7 @@
 // @@ begin test lint list maintained by maint/add_warning @@
+#![allow(clippy::bool_assert_comparison)]
+#![allow(clippy::clone_on_copy)]
+#![allow(clippy::dbg_macro)]
 #![allow(clippy::print_stderr)]
 #![allow(clippy::print_stdout)]
 #![allow(clippy::unwrap_used)]

crates/arti-client/examples/readme.rs

@@ -1,4 +1,7 @@
 // @@ begin test lint list maintained by maint/add_warning @@
+#![allow(clippy::bool_assert_comparison)]
+#![allow(clippy::clone_on_copy)]
+#![allow(clippy::dbg_macro)]
 #![allow(clippy::print_stderr)]
 #![allow(clippy::print_stdout)]
 #![allow(clippy::unwrap_used)]

crates/arti-hyper/examples/hyper.rs

@@ -1,4 +1,7 @@
 // @@ begin test lint list maintained by maint/add_warning @@
+#![allow(clippy::bool_assert_comparison)]
+#![allow(clippy::clone_on_copy)]
+#![allow(clippy::dbg_macro)]
 #![allow(clippy::print_stderr)]
 #![allow(clippy::print_stdout)]
 #![allow(clippy::unwrap_used)]

crates/tor-basic-utils/src/futures.rs

@@ -413,9 +413,16 @@ where
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)] // why is this not the default in tests
-#[allow(clippy::print_stderr)]
 mod test {
+    // @@ begin test lint list maintained by maint/add_warning @@
+    #![allow(clippy::bool_assert_comparison)]
+    #![allow(clippy::clone_on_copy)]
+    #![allow(clippy::dbg_macro)]
+    #![allow(clippy::print_stderr)]
+    #![allow(clippy::print_stdout)]
+    #![allow(clippy::unwrap_used)]
+    //! <!-- @@ end test lint list maintained by maint/add_warning @@ -->
+
     use super::*;
     use futures::channel::mpsc;
     use futures::future::poll_fn;

crates/tor-chanmgr/src/mgr/map.rs

@@ -366,6 +366,9 @@ fn update_padding_parameters_from_netdir(
 #[cfg(test)]
 mod test {
     // @@ begin test lint list maintained by maint/add_warning @@
+    #![allow(clippy::bool_assert_comparison)]
+    #![allow(clippy::clone_on_copy)]
+    #![allow(clippy::dbg_macro)]
     #![allow(clippy::print_stderr)]
     #![allow(clippy::print_stdout)]
     #![allow(clippy::unwrap_used)]

crates/tor-circmgr/src/path/dirpath.rs

@@ -80,8 +80,15 @@ impl DirPathBuilder {
 
 #[cfg(test)]
 mod test {
-    #![allow(clippy::unwrap_used)]
+    // @@ begin test lint list maintained by maint/add_warning @@
+    #![allow(clippy::bool_assert_comparison)]
     #![allow(clippy::clone_on_copy)]
+    #![allow(clippy::dbg_macro)]
+    #![allow(clippy::print_stderr)]
+    #![allow(clippy::print_stdout)]
+    #![allow(clippy::unwrap_used)]
+    //! <!-- @@ end test lint list maintained by maint/add_warning @@ -->
+
     use super::*;
     use crate::path::assert_same_path_when_owned;
     use crate::test::OptDummyGuardMgr;

crates/tor-config/src/path.rs

@@ -308,6 +308,15 @@ mod test {
 
 #[cfg(test)]
 mod test_serde {
+    // @@ begin test lint list maintained by maint/add_warning @@
+    #![allow(clippy::bool_assert_comparison)]
+    #![allow(clippy::clone_on_copy)]
+    #![allow(clippy::dbg_macro)]
+    #![allow(clippy::print_stderr)]
+    #![allow(clippy::print_stdout)]
+    #![allow(clippy::unwrap_used)]
+    //! <!-- @@ end test lint list maintained by maint/add_warning @@ -->
+
     use super::*;
     use std::ffi::OsString;
     use std::fmt::Debug;

crates/tor-guardmgr/src/fallback/set.rs

@@ -229,7 +229,15 @@ impl FallbackState {
 
 #[cfg(test)]
 mod test {
+    // @@ begin test lint list maintained by maint/add_warning @@
+    #![allow(clippy::bool_assert_comparison)]
+    #![allow(clippy::clone_on_copy)]
+    #![allow(clippy::dbg_macro)]
+    #![allow(clippy::print_stderr)]
+    #![allow(clippy::print_stdout)]
     #![allow(clippy::unwrap_used)]
+    //! <!-- @@ end test lint list maintained by maint/add_warning @@ -->
+
     use super::*;
     use crate::FirstHopId;
     use rand::Rng;

crates/tor-proto/src/channel/padding.rs

@@ -351,10 +351,16 @@ impl PreparedParameters {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
-#[allow(clippy::bool_assert_comparison)]
-#[allow(clippy::print_stderr)]
 mod test {
+    // @@ begin test lint list maintained by maint/add_warning @@
+    #![allow(clippy::bool_assert_comparison)]
+    #![allow(clippy::clone_on_copy)]
+    #![allow(clippy::dbg_macro)]
+    #![allow(clippy::print_stderr)]
+    #![allow(clippy::print_stdout)]
+    #![allow(clippy::unwrap_used)]
+    //! <!-- @@ end test lint list maintained by maint/add_warning @@ -->
+
     use super::*;
     use futures::future::ready;
     use futures::select_biased;

maint/add_warning

@@ -49,6 +49,9 @@ WANT_LINTS = """
 # ---------- list of lints to apply or disapply *in tests* ----------
 
 TEST_LINTS = """
+#![allow(clippy::bool_assert_comparison)]
+#![allow(clippy::clone_on_copy)]
+#![allow(clippy::dbg_macro)]
 #![allow(clippy::print_stderr)]
 #![allow(clippy::print_stdout)]
 #![allow(clippy::unwrap_used)]