From ce8b0184ec6d896a7c7d136467f40db34a6b61fd Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Tue, 22 Aug 2023 15:26:40 +0100 Subject: [PATCH 1/2] clippy: Suppress needless_pass_by_value in tests Rationale: same as for useless_vec, as in 01cb7ee0a112. Prompted by reading a commit where someone did makework to get rid of an occurrence of this warning. --- maint/add_warning | 1 + 1 file changed, 1 insertion(+) diff --git a/maint/add_warning b/maint/add_warning index 95a996fbe..f25827812 100755 --- a/maint/add_warning +++ b/maint/add_warning @@ -67,6 +67,7 @@ TEST_LINTS = """ #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] +#![allow(clippy::needless_pass_by_value)] """ # ---------- some notes about lints we might use - NOT USED by any code here ---------- From 42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Tue, 22 Aug 2023 15:28:12 +0100 Subject: [PATCH 2/2] Run maint/add_warning to add lint block everywhere --- crates/arti-bench/src/main.rs | 1 + crates/arti-client/examples/advanced_isolation.rs | 1 + crates/arti-client/examples/hook-tcp.rs | 1 + crates/arti-client/examples/lazy-init.rs | 1 + crates/arti-client/examples/readme-with-report.rs | 1 + crates/arti-client/examples/readme.rs | 1 + crates/arti-client/examples/snowflake.rs | 1 + crates/arti-client/src/address.rs | 1 + crates/arti-client/src/client.rs | 1 + crates/arti-client/src/config.rs | 1 + crates/arti-client/src/err.rs | 1 + crates/arti-hyper/examples/hyper.rs | 1 + crates/arti-hyper/src/lib.rs | 1 + crates/arti-rpcserver/src/cancel.rs | 1 + crates/arti-rpcserver/src/globalid.rs | 1 + crates/arti-rpcserver/src/msgs.rs | 1 + crates/arti-rpcserver/src/objmap.rs | 1 + crates/arti-rpcserver/src/streams.rs | 1 + crates/arti/src/cfg.rs | 1 + crates/arti/src/logging/time.rs | 1 + crates/fs-mistrust/src/anon_home.rs | 1 + crates/fs-mistrust/src/dir.rs | 1 + crates/fs-mistrust/src/disable.rs | 1 + crates/fs-mistrust/src/err.rs | 1 + crates/fs-mistrust/src/lib.rs | 1 + crates/fs-mistrust/src/user.rs | 1 + crates/fs-mistrust/src/user/serde_support.rs | 1 + crates/fs-mistrust/src/walk.rs | 1 + crates/retry-error/src/lib.rs | 1 + crates/safelog/src/flags.rs | 1 + crates/safelog/src/impls.rs | 1 + crates/safelog/src/lib.rs | 1 + crates/tor-async-utils/src/prepare_send.rs | 1 + crates/tor-async-utils/src/watch.rs | 1 + crates/tor-basic-utils/src/iter.rs | 1 + crates/tor-basic-utils/src/lib.rs | 1 + crates/tor-basic-utils/src/n_key_set.rs | 1 + crates/tor-basic-utils/src/rangebounds.rs | 1 + crates/tor-basic-utils/src/retry.rs | 1 + crates/tor-basic-utils/src/test_rng.rs | 1 + crates/tor-bytes/src/lib.rs | 1 + crates/tor-bytes/src/secretbuf.rs | 1 + crates/tor-cell/src/chancell/msg.rs | 1 + crates/tor-cell/src/slicewriter.rs | 1 + crates/tor-cert/src/encode.rs | 1 + crates/tor-cert/src/lib.rs | 1 + crates/tor-chanmgr/src/builder.rs | 1 + crates/tor-chanmgr/src/config.rs | 1 + crates/tor-chanmgr/src/event.rs | 1 + crates/tor-chanmgr/src/mgr.rs | 1 + crates/tor-chanmgr/src/mgr/state.rs | 1 + crates/tor-chanmgr/src/mgr/state/padding_test.rs | 1 + crates/tor-chanmgr/src/transport/default.rs | 1 + crates/tor-chanmgr/src/transport/proxied.rs | 1 + crates/tor-checkable/src/signed.rs | 1 + crates/tor-checkable/src/timed.rs | 1 + crates/tor-circmgr/src/build.rs | 1 + crates/tor-circmgr/src/config.rs | 1 + crates/tor-circmgr/src/hspool/pool.rs | 1 + crates/tor-circmgr/src/lib.rs | 1 + crates/tor-circmgr/src/mgr.rs | 1 + crates/tor-circmgr/src/mgr/streams.rs | 1 + crates/tor-circmgr/src/path/dirpath.rs | 1 + crates/tor-circmgr/src/path/exitpath.rs | 1 + crates/tor-circmgr/src/preemptive.rs | 1 + crates/tor-circmgr/src/timeouts.rs | 1 + crates/tor-circmgr/src/timeouts/estimator.rs | 1 + crates/tor-circmgr/src/timeouts/pareto.rs | 1 + crates/tor-config/src/cmdline.rs | 1 + crates/tor-config/src/err.rs | 1 + crates/tor-config/src/lib.rs | 1 + crates/tor-config/src/list_builder.rs | 1 + crates/tor-config/src/load.rs | 1 + crates/tor-config/src/misc.rs | 1 + crates/tor-config/src/mut_cfg.rs | 1 + crates/tor-config/src/path.rs | 1 + crates/tor-config/src/sources.rs | 1 + crates/tor-congestion/src/rtt.rs | 1 + crates/tor-consdiff/src/lib.rs | 1 + crates/tor-dirclient/src/lib.rs | 1 + crates/tor-dirclient/src/request.rs | 1 + crates/tor-dirclient/src/response.rs | 1 + crates/tor-dirclient/src/util.rs | 1 + crates/tor-dirmgr/src/authority.rs | 1 + crates/tor-dirmgr/src/bootstrap.rs | 1 + crates/tor-dirmgr/src/bridgedesc/bdtest.rs | 1 + crates/tor-dirmgr/src/config.rs | 1 + crates/tor-dirmgr/src/docid.rs | 1 + crates/tor-dirmgr/src/docmeta.rs | 1 + crates/tor-dirmgr/src/event.rs | 1 + crates/tor-dirmgr/src/lib.rs | 1 + crates/tor-dirmgr/src/retry.rs | 1 + crates/tor-dirmgr/src/shared_ref.rs | 1 + crates/tor-dirmgr/src/state.rs | 1 + crates/tor-dirmgr/src/storage.rs | 1 + crates/tor-error/src/internal.rs | 1 + crates/tor-error/src/report.rs | 1 + crates/tor-error/src/retriable.rs | 1 + crates/tor-events/src/lib.rs | 1 + crates/tor-geoip/src/lib.rs | 1 + crates/tor-guardmgr/src/bridge/config.rs | 1 + crates/tor-guardmgr/src/config.rs | 1 + crates/tor-guardmgr/src/dirstatus.rs | 1 + crates/tor-guardmgr/src/fallback/set.rs | 1 + crates/tor-guardmgr/src/filter.rs | 1 + crates/tor-guardmgr/src/guard.rs | 1 + crates/tor-guardmgr/src/lib.rs | 1 + crates/tor-guardmgr/src/sample.rs | 1 + crates/tor-guardmgr/src/skew.rs | 1 + crates/tor-guardmgr/src/util.rs | 1 + crates/tor-hsclient/src/connect.rs | 1 + crates/tor-hsclient/src/isol_map.rs | 1 + crates/tor-hsclient/src/state.rs | 1 + crates/tor-hscrypto/src/ops.rs | 1 + crates/tor-hscrypto/src/pk.rs | 1 + crates/tor-hscrypto/src/time.rs | 1 + crates/tor-keymgr/src/err.rs | 1 + crates/tor-keymgr/src/key_specifier.rs | 1 + crates/tor-keymgr/src/key_type/ssh.rs | 1 + crates/tor-keymgr/src/keystore/arti.rs | 1 + crates/tor-keymgr/src/mgr.rs | 1 + crates/tor-linkspec/src/decode.rs | 1 + crates/tor-linkspec/src/ids.rs | 1 + crates/tor-linkspec/src/ids/by_id.rs | 1 + crates/tor-linkspec/src/ids/set.rs | 1 + crates/tor-linkspec/src/ls.rs | 1 + crates/tor-linkspec/src/owned.rs | 1 + crates/tor-linkspec/src/traits.rs | 1 + crates/tor-linkspec/src/transport.rs | 1 + crates/tor-linkspec/src/verbatim.rs | 1 + crates/tor-llcrypto/src/pk.rs | 1 + crates/tor-llcrypto/src/pk/keymanip.rs | 1 + crates/tor-llcrypto/src/util/ct.rs | 1 + crates/tor-llcrypto/src/util/rand_compat.rs | 1 + crates/tor-netdir/src/hsdir_params.rs | 1 + crates/tor-netdir/src/hsdir_ring.rs | 1 + crates/tor-netdir/src/lib.rs | 1 + crates/tor-netdir/src/params.rs | 1 + crates/tor-netdir/src/testnet.rs | 1 + crates/tor-netdir/src/weight.rs | 1 + crates/tor-netdoc/src/build.rs | 1 + crates/tor-netdoc/src/doc/authcert.rs | 1 + crates/tor-netdoc/src/doc/authcert/build.rs | 1 + crates/tor-netdoc/src/doc/hsdesc.rs | 1 + crates/tor-netdoc/src/doc/hsdesc/build.rs | 1 + crates/tor-netdoc/src/doc/hsdesc/build/inner.rs | 1 + crates/tor-netdoc/src/doc/hsdesc/build/middle.rs | 1 + crates/tor-netdoc/src/doc/hsdesc/build/outer.rs | 1 + crates/tor-netdoc/src/doc/hsdesc/desc_enc.rs | 1 + crates/tor-netdoc/src/doc/hsdesc/inner.rs | 1 + crates/tor-netdoc/src/doc/hsdesc/middle.rs | 1 + crates/tor-netdoc/src/doc/hsdesc/outer.rs | 1 + crates/tor-netdoc/src/doc/microdesc.rs | 1 + crates/tor-netdoc/src/doc/microdesc/build.rs | 1 + crates/tor-netdoc/src/doc/netstatus.rs | 1 + crates/tor-netdoc/src/doc/netstatus/build.rs | 1 + crates/tor-netdoc/src/doc/routerdesc.rs | 1 + crates/tor-netdoc/src/parse/parser.rs | 1 + crates/tor-netdoc/src/parse/tokenize.rs | 1 + crates/tor-netdoc/src/types/family.rs | 1 + crates/tor-netdoc/src/types/misc.rs | 1 + crates/tor-netdoc/src/types/policy.rs | 1 + crates/tor-netdoc/src/types/policy/addrpolicy.rs | 1 + crates/tor-netdoc/src/types/policy/portpolicy.rs | 1 + crates/tor-netdoc/src/types/version.rs | 1 + crates/tor-netdoc/src/util/batching_split_before.rs | 1 + crates/tor-netdoc/src/util/intern.rs | 1 + crates/tor-netdoc/src/util/str.rs | 1 + crates/tor-persist/src/fs.rs | 1 + crates/tor-persist/src/fs/clean.rs | 1 + crates/tor-persist/src/testing.rs | 1 + crates/tor-proto/src/channel/circmap.rs | 1 + crates/tor-proto/src/channel/padding.rs | 1 + crates/tor-proto/src/channel/unique_id.rs | 1 + crates/tor-proto/src/circuit.rs | 1 + crates/tor-proto/src/circuit/celltypes.rs | 1 + crates/tor-proto/src/circuit/halfstream.rs | 1 + crates/tor-proto/src/circuit/sendme.rs | 1 + crates/tor-proto/src/circuit/streammap.rs | 1 + crates/tor-proto/src/crypto/cell.rs | 1 + crates/tor-proto/src/crypto/handshake/fast.rs | 1 + crates/tor-proto/src/crypto/handshake/hs_ntor.rs | 1 + crates/tor-proto/src/crypto/handshake/ntor_v3.rs | 1 + crates/tor-proto/src/crypto/ll/kdf.rs | 1 + crates/tor-proto/src/util/ct.rs | 1 + crates/tor-proto/src/util/skew.rs | 1 + crates/tor-proto/src/util/ts.rs | 1 + crates/tor-protover/src/lib.rs | 1 + crates/tor-ptmgr/src/ipc.rs | 1 + crates/tor-rpcbase/src/dispatch.rs | 1 + crates/tor-rpcbase/src/err.rs | 1 + crates/tor-rpcbase/src/obj.rs | 1 + crates/tor-rpcbase/src/obj/cast.rs | 1 + crates/tor-rpcbase/src/typeid.rs | 1 + crates/tor-rtcompat/src/async_std.rs | 1 + crates/tor-rtcompat/src/impls/rustls.rs | 1 + crates/tor-rtcompat/src/timer.rs | 1 + crates/tor-rtcompat/src/tokio.rs | 1 + crates/tor-rtmock/src/io.rs | 1 + crates/tor-rtmock/src/net.rs | 1 + crates/tor-rtmock/src/task.rs | 1 + crates/tor-rtmock/src/time.rs | 1 + crates/tor-socksproto/src/handshake.rs | 1 + crates/tor-socksproto/src/handshake/client.rs | 1 + crates/tor-socksproto/src/handshake/proxy.rs | 1 + crates/tor-socksproto/src/msg.rs | 1 + 206 files changed, 206 insertions(+) diff --git a/crates/arti-bench/src/main.rs b/crates/arti-bench/src/main.rs index 883174e5e..44e4858e4 100644 --- a/crates/arti-bench/src/main.rs +++ b/crates/arti-bench/src/main.rs @@ -764,6 +764,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::StreamIsolationTracker; diff --git a/crates/arti-client/examples/advanced_isolation.rs b/crates/arti-client/examples/advanced_isolation.rs index 00efbdd1b..42c25df95 100644 --- a/crates/arti-client/examples/advanced_isolation.rs +++ b/crates/arti-client/examples/advanced_isolation.rs @@ -8,6 +8,7 @@ #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] +#![allow(clippy::needless_pass_by_value)] //! // This example showcase how to use the trait IsolationHelper to build complex isolation rules. diff --git a/crates/arti-client/examples/hook-tcp.rs b/crates/arti-client/examples/hook-tcp.rs index d5784f271..3ec05ade9 100644 --- a/crates/arti-client/examples/hook-tcp.rs +++ b/crates/arti-client/examples/hook-tcp.rs @@ -8,6 +8,7 @@ #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] +#![allow(clippy::needless_pass_by_value)] //! //! This example showcases using a custom [`TcpProvider`] to do custom actions before Arti initiates diff --git a/crates/arti-client/examples/lazy-init.rs b/crates/arti-client/examples/lazy-init.rs index 9eb27582d..b079d8dc1 100644 --- a/crates/arti-client/examples/lazy-init.rs +++ b/crates/arti-client/examples/lazy-init.rs @@ -8,6 +8,7 @@ #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] +#![allow(clippy::needless_pass_by_value)] //! use anyhow::Result; diff --git a/crates/arti-client/examples/readme-with-report.rs b/crates/arti-client/examples/readme-with-report.rs index 06752b426..c0670680b 100644 --- a/crates/arti-client/examples/readme-with-report.rs +++ b/crates/arti-client/examples/readme-with-report.rs @@ -8,6 +8,7 @@ #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] +#![allow(clippy::needless_pass_by_value)] //! use anyhow::Result; diff --git a/crates/arti-client/examples/readme.rs b/crates/arti-client/examples/readme.rs index bfff9637b..8f0318138 100644 --- a/crates/arti-client/examples/readme.rs +++ b/crates/arti-client/examples/readme.rs @@ -8,6 +8,7 @@ #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] +#![allow(clippy::needless_pass_by_value)] //! use anyhow::Result; diff --git a/crates/arti-client/examples/snowflake.rs b/crates/arti-client/examples/snowflake.rs index f0519b4b8..ec0c9cc32 100644 --- a/crates/arti-client/examples/snowflake.rs +++ b/crates/arti-client/examples/snowflake.rs @@ -9,6 +9,7 @@ #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] +#![allow(clippy::needless_pass_by_value)] //! #[cfg(feature = "pt-client")] diff --git a/crates/arti-client/src/address.rs b/crates/arti-client/src/address.rs index e84edbf75..45d0f41c1 100644 --- a/crates/arti-client/src/address.rs +++ b/crates/arti-client/src/address.rs @@ -558,6 +558,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/arti-client/src/client.rs b/crates/arti-client/src/client.rs index 99d523d0e..e80374f2f 100644 --- a/crates/arti-client/src/client.rs +++ b/crates/arti-client/src/client.rs @@ -1382,6 +1382,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use tor_config::Reconfigure; diff --git a/crates/arti-client/src/config.rs b/crates/arti-client/src/config.rs index db53ba6cc..e9eea2403 100644 --- a/crates/arti-client/src/config.rs +++ b/crates/arti-client/src/config.rs @@ -764,6 +764,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/arti-client/src/err.rs b/crates/arti-client/src/err.rs index 588790293..6f13d6ed0 100644 --- a/crates/arti-client/src/err.rs +++ b/crates/arti-client/src/err.rs @@ -564,6 +564,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/arti-hyper/examples/hyper.rs b/crates/arti-hyper/examples/hyper.rs index 7917e4abc..07b52153f 100644 --- a/crates/arti-hyper/examples/hyper.rs +++ b/crates/arti-hyper/examples/hyper.rs @@ -8,6 +8,7 @@ #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] +#![allow(clippy::needless_pass_by_value)] //! #![allow(clippy::uninlined_format_args)] diff --git a/crates/arti-hyper/src/lib.rs b/crates/arti-hyper/src/lib.rs index 53191bbc9..db5e37a07 100644 --- a/crates/arti-hyper/src/lib.rs +++ b/crates/arti-hyper/src/lib.rs @@ -297,6 +297,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/arti-rpcserver/src/cancel.rs b/crates/arti-rpcserver/src/cancel.rs index 88ecad29a..baeafda05 100644 --- a/crates/arti-rpcserver/src/cancel.rs +++ b/crates/arti-rpcserver/src/cancel.rs @@ -119,6 +119,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/arti-rpcserver/src/globalid.rs b/crates/arti-rpcserver/src/globalid.rs index d5d9f9c0a..d81bc3ea0 100644 --- a/crates/arti-rpcserver/src/globalid.rs +++ b/crates/arti-rpcserver/src/globalid.rs @@ -159,6 +159,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/arti-rpcserver/src/msgs.rs b/crates/arti-rpcserver/src/msgs.rs index a925c3572..4c73c5c51 100644 --- a/crates/arti-rpcserver/src/msgs.rs +++ b/crates/arti-rpcserver/src/msgs.rs @@ -166,6 +166,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/arti-rpcserver/src/objmap.rs b/crates/arti-rpcserver/src/objmap.rs index ef1b159c9..b736df960 100644 --- a/crates/arti-rpcserver/src/objmap.rs +++ b/crates/arti-rpcserver/src/objmap.rs @@ -382,6 +382,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/arti-rpcserver/src/streams.rs b/crates/arti-rpcserver/src/streams.rs index 7823256ba..dd2f7e1f4 100644 --- a/crates/arti-rpcserver/src/streams.rs +++ b/crates/arti-rpcserver/src/streams.rs @@ -67,6 +67,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/arti/src/cfg.rs b/crates/arti/src/cfg.rs index dd2c9639a..d2a990561 100644 --- a/crates/arti/src/cfg.rs +++ b/crates/arti/src/cfg.rs @@ -279,6 +279,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! // Saves adding many individual #[cfg], or a sub-module diff --git a/crates/arti/src/logging/time.rs b/crates/arti/src/logging/time.rs index e3b30b31a..8cfe98617 100644 --- a/crates/arti/src/logging/time.rs +++ b/crates/arti/src/logging/time.rs @@ -247,6 +247,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/fs-mistrust/src/anon_home.rs b/crates/fs-mistrust/src/anon_home.rs index 28d72b08b..e059e7ae1 100644 --- a/crates/fs-mistrust/src/anon_home.rs +++ b/crates/fs-mistrust/src/anon_home.rs @@ -118,6 +118,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/fs-mistrust/src/dir.rs b/crates/fs-mistrust/src/dir.rs index 82f29f051..6733554ee 100644 --- a/crates/fs-mistrust/src/dir.rs +++ b/crates/fs-mistrust/src/dir.rs @@ -258,6 +258,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::testing::Dir; diff --git a/crates/fs-mistrust/src/disable.rs b/crates/fs-mistrust/src/disable.rs index c3e6dbbe8..beb6ae593 100644 --- a/crates/fs-mistrust/src/disable.rs +++ b/crates/fs-mistrust/src/disable.rs @@ -104,6 +104,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; #[test] diff --git a/crates/fs-mistrust/src/err.rs b/crates/fs-mistrust/src/err.rs index 690c77860..a0d261138 100644 --- a/crates/fs-mistrust/src/err.rs +++ b/crates/fs-mistrust/src/err.rs @@ -288,6 +288,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/fs-mistrust/src/lib.rs b/crates/fs-mistrust/src/lib.rs index 10801de93..1ce7efcc9 100644 --- a/crates/fs-mistrust/src/lib.rs +++ b/crates/fs-mistrust/src/lib.rs @@ -599,6 +599,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use testing::{mistrust_build, Dir, MistrustOp}; diff --git a/crates/fs-mistrust/src/user.rs b/crates/fs-mistrust/src/user.rs index d40587ff4..5c32913d2 100644 --- a/crates/fs-mistrust/src/user.rs +++ b/crates/fs-mistrust/src/user.rs @@ -298,6 +298,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use pwd_grp::mock::MockPwdGrpProvider; diff --git a/crates/fs-mistrust/src/user/serde_support.rs b/crates/fs-mistrust/src/user/serde_support.rs index 7a1a68f0d..8b85c383f 100644 --- a/crates/fs-mistrust/src/user/serde_support.rs +++ b/crates/fs-mistrust/src/user/serde_support.rs @@ -154,6 +154,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/fs-mistrust/src/walk.rs b/crates/fs-mistrust/src/walk.rs index 4595737d3..7cf7e2c9c 100644 --- a/crates/fs-mistrust/src/walk.rs +++ b/crates/fs-mistrust/src/walk.rs @@ -397,6 +397,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::testing; diff --git a/crates/retry-error/src/lib.rs b/crates/retry-error/src/lib.rs index 96ee51a57..3f81c723a 100644 --- a/crates/retry-error/src/lib.rs +++ b/crates/retry-error/src/lib.rs @@ -303,6 +303,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use derive_more::From; diff --git a/crates/safelog/src/flags.rs b/crates/safelog/src/flags.rs index 9a514e3a5..fef210d92 100644 --- a/crates/safelog/src/flags.rs +++ b/crates/safelog/src/flags.rs @@ -190,6 +190,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; // We use "serial_test" to make sure that our tests here run one at a time, diff --git a/crates/safelog/src/impls.rs b/crates/safelog/src/impls.rs index 93c2bb871..0505ac95a 100644 --- a/crates/safelog/src/impls.rs +++ b/crates/safelog/src/impls.rs @@ -59,6 +59,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use std::{ diff --git a/crates/safelog/src/lib.rs b/crates/safelog/src/lib.rs index 8dc719be0..532b09511 100644 --- a/crates/safelog/src/lib.rs +++ b/crates/safelog/src/lib.rs @@ -333,6 +333,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use serial_test::serial; diff --git a/crates/tor-async-utils/src/prepare_send.rs b/crates/tor-async-utils/src/prepare_send.rs index 63f521012..f1a0d73cd 100644 --- a/crates/tor-async-utils/src/prepare_send.rs +++ b/crates/tor-async-utils/src/prepare_send.rs @@ -424,6 +424,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-async-utils/src/watch.rs b/crates/tor-async-utils/src/watch.rs index 471f825ad..136417df3 100644 --- a/crates/tor-async-utils/src/watch.rs +++ b/crates/tor-async-utils/src/watch.rs @@ -139,6 +139,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-basic-utils/src/iter.rs b/crates/tor-basic-utils/src/iter.rs index 447c920c7..f9bd83bb5 100644 --- a/crates/tor-basic-utils/src/iter.rs +++ b/crates/tor-basic-utils/src/iter.rs @@ -165,6 +165,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-basic-utils/src/lib.rs b/crates/tor-basic-utils/src/lib.rs index 3f1b9882e..bb6f7d8cd 100644 --- a/crates/tor-basic-utils/src/lib.rs +++ b/crates/tor-basic-utils/src/lib.rs @@ -561,6 +561,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-basic-utils/src/n_key_set.rs b/crates/tor-basic-utils/src/n_key_set.rs index 3a187ce84..f26c19ec8 100644 --- a/crates/tor-basic-utils/src/n_key_set.rs +++ b/crates/tor-basic-utils/src/n_key_set.rs @@ -595,6 +595,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! n_key_set! { diff --git a/crates/tor-basic-utils/src/rangebounds.rs b/crates/tor-basic-utils/src/rangebounds.rs index cda422c2e..70bf44b52 100644 --- a/crates/tor-basic-utils/src/rangebounds.rs +++ b/crates/tor-basic-utils/src/rangebounds.rs @@ -108,6 +108,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use std::fmt::Debug; diff --git a/crates/tor-basic-utils/src/retry.rs b/crates/tor-basic-utils/src/retry.rs index 00092cd32..4aa20eb19 100644 --- a/crates/tor-basic-utils/src/retry.rs +++ b/crates/tor-basic-utils/src/retry.rs @@ -129,6 +129,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::test_rng::testing_rng; diff --git a/crates/tor-basic-utils/src/test_rng.rs b/crates/tor-basic-utils/src/test_rng.rs index 99705136c..4e0bef689 100644 --- a/crates/tor-basic-utils/src/test_rng.rs +++ b/crates/tor-basic-utils/src/test_rng.rs @@ -240,6 +240,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use std::env::VarError; diff --git a/crates/tor-bytes/src/lib.rs b/crates/tor-bytes/src/lib.rs index 1e939b5bd..aa6460368 100644 --- a/crates/tor-bytes/src/lib.rs +++ b/crates/tor-bytes/src/lib.rs @@ -178,6 +178,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-bytes/src/secretbuf.rs b/crates/tor-bytes/src/secretbuf.rs index 444f4a3fe..ec22666d3 100644 --- a/crates/tor-bytes/src/secretbuf.rs +++ b/crates/tor-bytes/src/secretbuf.rs @@ -110,6 +110,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-cell/src/chancell/msg.rs b/crates/tor-cell/src/chancell/msg.rs index 2448a100b..352b1e39c 100644 --- a/crates/tor-cell/src/chancell/msg.rs +++ b/crates/tor-cell/src/chancell/msg.rs @@ -1234,6 +1234,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; #[test] diff --git a/crates/tor-cell/src/slicewriter.rs b/crates/tor-cell/src/slicewriter.rs index d5a9d9341..d230962c5 100644 --- a/crates/tor-cell/src/slicewriter.rs +++ b/crates/tor-cell/src/slicewriter.rs @@ -98,6 +98,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-cert/src/encode.rs b/crates/tor-cert/src/encode.rs index b0abb7006..3f35c3fea 100644 --- a/crates/tor-cert/src/encode.rs +++ b/crates/tor-cert/src/encode.rs @@ -172,6 +172,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::CertifiedKey; diff --git a/crates/tor-cert/src/lib.rs b/crates/tor-cert/src/lib.rs index ac50b22bd..c07117f15 100644 --- a/crates/tor-cert/src/lib.rs +++ b/crates/tor-cert/src/lib.rs @@ -617,6 +617,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use hex_literal::hex; diff --git a/crates/tor-chanmgr/src/builder.rs b/crates/tor-chanmgr/src/builder.rs index ba5fc1401..77d6e3e25 100644 --- a/crates/tor-chanmgr/src/builder.rs +++ b/crates/tor-chanmgr/src/builder.rs @@ -234,6 +234,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::{ diff --git a/crates/tor-chanmgr/src/config.rs b/crates/tor-chanmgr/src/config.rs index adaec25b0..aeb080d19 100644 --- a/crates/tor-chanmgr/src/config.rs +++ b/crates/tor-chanmgr/src/config.rs @@ -44,6 +44,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-chanmgr/src/event.rs b/crates/tor-chanmgr/src/event.rs index 5ce555a17..d5098a854 100644 --- a/crates/tor-chanmgr/src/event.rs +++ b/crates/tor-chanmgr/src/event.rs @@ -407,6 +407,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use float_eq::assert_float_eq; diff --git a/crates/tor-chanmgr/src/mgr.rs b/crates/tor-chanmgr/src/mgr.rs index 8d83e0e7b..448bfcf5a 100644 --- a/crates/tor-chanmgr/src/mgr.rs +++ b/crates/tor-chanmgr/src/mgr.rs @@ -530,6 +530,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::Error; diff --git a/crates/tor-chanmgr/src/mgr/state.rs b/crates/tor-chanmgr/src/mgr/state.rs index c7e7c2241..722deef0d 100644 --- a/crates/tor-chanmgr/src/mgr/state.rs +++ b/crates/tor-chanmgr/src/mgr/state.rs @@ -536,6 +536,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-chanmgr/src/mgr/state/padding_test.rs b/crates/tor-chanmgr/src/mgr/state/padding_test.rs index 1c67093b0..275a2531d 100644 --- a/crates/tor-chanmgr/src/mgr/state/padding_test.rs +++ b/crates/tor-chanmgr/src/mgr/state/padding_test.rs @@ -10,6 +10,7 @@ #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] +#![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-chanmgr/src/transport/default.rs b/crates/tor-chanmgr/src/transport/default.rs index 54e792225..25d4c30ac 100644 --- a/crates/tor-chanmgr/src/transport/default.rs +++ b/crates/tor-chanmgr/src/transport/default.rs @@ -141,6 +141,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use std::str::FromStr; diff --git a/crates/tor-chanmgr/src/transport/proxied.rs b/crates/tor-chanmgr/src/transport/proxied.rs index b167a6a3a..68fd818a6 100644 --- a/crates/tor-chanmgr/src/transport/proxied.rs +++ b/crates/tor-chanmgr/src/transport/proxied.rs @@ -449,6 +449,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! #[allow(unused_imports)] use super::*; diff --git a/crates/tor-checkable/src/signed.rs b/crates/tor-checkable/src/signed.rs index 29b1f8525..935c3b92c 100644 --- a/crates/tor-checkable/src/signed.rs +++ b/crates/tor-checkable/src/signed.rs @@ -64,6 +64,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::SelfSigned; diff --git a/crates/tor-checkable/src/timed.rs b/crates/tor-checkable/src/timed.rs index 43d46d3c5..579ecdbeb 100644 --- a/crates/tor-checkable/src/timed.rs +++ b/crates/tor-checkable/src/timed.rs @@ -199,6 +199,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::{TimeValidityError, Timebound}; diff --git a/crates/tor-circmgr/src/build.rs b/crates/tor-circmgr/src/build.rs index 8acd6d4da..d058a9ac4 100644 --- a/crates/tor-circmgr/src/build.rs +++ b/crates/tor-circmgr/src/build.rs @@ -534,6 +534,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::timeouts::TimeoutEstimator; diff --git a/crates/tor-circmgr/src/config.rs b/crates/tor-circmgr/src/config.rs index 0ad0e3027..1ad7056a0 100644 --- a/crates/tor-circmgr/src/config.rs +++ b/crates/tor-circmgr/src/config.rs @@ -389,6 +389,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-circmgr/src/hspool/pool.rs b/crates/tor-circmgr/src/hspool/pool.rs index 022e72a80..32d696428 100644 --- a/crates/tor-circmgr/src/hspool/pool.rs +++ b/crates/tor-circmgr/src/hspool/pool.rs @@ -171,6 +171,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-circmgr/src/lib.rs b/crates/tor-circmgr/src/lib.rs index 426942428..758f180c4 100644 --- a/crates/tor-circmgr/src/lib.rs +++ b/crates/tor-circmgr/src/lib.rs @@ -849,6 +849,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-circmgr/src/mgr.rs b/crates/tor-circmgr/src/mgr.rs index 7a2c1c4e8..accb44849 100644 --- a/crates/tor-circmgr/src/mgr.rs +++ b/crates/tor-circmgr/src/mgr.rs @@ -1541,6 +1541,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::isolation::test::{assert_isoleq, IsolationTokenEq}; diff --git a/crates/tor-circmgr/src/mgr/streams.rs b/crates/tor-circmgr/src/mgr/streams.rs index 4dc01fbf0..ff453396a 100644 --- a/crates/tor-circmgr/src/mgr/streams.rs +++ b/crates/tor-circmgr/src/mgr/streams.rs @@ -126,6 +126,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use futures_await_test::async_test; diff --git a/crates/tor-circmgr/src/path/dirpath.rs b/crates/tor-circmgr/src/path/dirpath.rs index 5f212ce1c..b925851c2 100644 --- a/crates/tor-circmgr/src/path/dirpath.rs +++ b/crates/tor-circmgr/src/path/dirpath.rs @@ -88,6 +88,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-circmgr/src/path/exitpath.rs b/crates/tor-circmgr/src/path/exitpath.rs index d5b4bd069..5c36308d5 100644 --- a/crates/tor-circmgr/src/path/exitpath.rs +++ b/crates/tor-circmgr/src/path/exitpath.rs @@ -359,6 +359,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::path::{assert_same_path_when_owned, MaybeOwnedRelay, OwnedPath, TorPathInner}; diff --git a/crates/tor-circmgr/src/preemptive.rs b/crates/tor-circmgr/src/preemptive.rs index 49b6c5ed2..ef41f1453 100644 --- a/crates/tor-circmgr/src/preemptive.rs +++ b/crates/tor-circmgr/src/preemptive.rs @@ -96,6 +96,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use crate::{PreemptiveCircuitConfig, PreemptiveCircuitPredictor, TargetCircUsage, TargetPort}; use std::time::{Duration, Instant}; diff --git a/crates/tor-circmgr/src/timeouts.rs b/crates/tor-circmgr/src/timeouts.rs index 7b1345793..1a1bcc35c 100644 --- a/crates/tor-circmgr/src/timeouts.rs +++ b/crates/tor-circmgr/src/timeouts.rs @@ -177,6 +177,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-circmgr/src/timeouts/estimator.rs b/crates/tor-circmgr/src/timeouts/estimator.rs index 603035e5f..32301268f 100644 --- a/crates/tor-circmgr/src/timeouts/estimator.rs +++ b/crates/tor-circmgr/src/timeouts/estimator.rs @@ -163,6 +163,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use tor_persist::StateMgr; diff --git a/crates/tor-circmgr/src/timeouts/pareto.rs b/crates/tor-circmgr/src/timeouts/pareto.rs index 9b4a1bfed..60b95f828 100644 --- a/crates/tor-circmgr/src/timeouts/pareto.rs +++ b/crates/tor-circmgr/src/timeouts/pareto.rs @@ -654,6 +654,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::timeouts::TimeoutEstimator; diff --git a/crates/tor-config/src/cmdline.rs b/crates/tor-config/src/cmdline.rs index 8e0e2e71c..30bc38ab6 100644 --- a/crates/tor-config/src/cmdline.rs +++ b/crates/tor-config/src/cmdline.rs @@ -153,6 +153,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; #[test] diff --git a/crates/tor-config/src/err.rs b/crates/tor-config/src/err.rs index 9c3bc5ea5..da4ba49b3 100644 --- a/crates/tor-config/src/err.rs +++ b/crates/tor-config/src/err.rs @@ -176,6 +176,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-config/src/lib.rs b/crates/tor-config/src/lib.rs index a2c32e29a..a25d85af6 100644 --- a/crates/tor-config/src/lib.rs +++ b/crates/tor-config/src/lib.rs @@ -434,6 +434,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate as tor_config; diff --git a/crates/tor-config/src/list_builder.rs b/crates/tor-config/src/list_builder.rs index 654f20f53..1b6fcc981 100644 --- a/crates/tor-config/src/list_builder.rs +++ b/crates/tor-config/src/list_builder.rs @@ -747,6 +747,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use derive_builder::Builder; diff --git a/crates/tor-config/src/load.rs b/crates/tor-config/src/load.rs index 72db0d8c4..50bfebd53 100644 --- a/crates/tor-config/src/load.rs +++ b/crates/tor-config/src/load.rs @@ -663,6 +663,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::*; diff --git a/crates/tor-config/src/misc.rs b/crates/tor-config/src/misc.rs index 735f84447..3fe08f8ec 100644 --- a/crates/tor-config/src/misc.rs +++ b/crates/tor-config/src/misc.rs @@ -395,6 +395,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-config/src/mut_cfg.rs b/crates/tor-config/src/mut_cfg.rs index 18898df30..1d0db85f3 100644 --- a/crates/tor-config/src/mut_cfg.rs +++ b/crates/tor-config/src/mut_cfg.rs @@ -73,6 +73,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-config/src/path.rs b/crates/tor-config/src/path.rs index 810431f9c..4e7f1c935 100644 --- a/crates/tor-config/src/path.rs +++ b/crates/tor-config/src/path.rs @@ -380,6 +380,7 @@ mod test_serde { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-config/src/sources.rs b/crates/tor-config/src/sources.rs index b89be22bc..62b37c26e 100644 --- a/crates/tor-config/src/sources.rs +++ b/crates/tor-config/src/sources.rs @@ -437,6 +437,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-congestion/src/rtt.rs b/crates/tor-congestion/src/rtt.rs index 7864ce8cf..96e563d7e 100644 --- a/crates/tor-congestion/src/rtt.rs +++ b/crates/tor-congestion/src/rtt.rs @@ -260,6 +260,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use crate::rtt::RoundtripTimeEstimator; use std::sync::atomic::{AtomicBool, Ordering}; diff --git a/crates/tor-consdiff/src/lib.rs b/crates/tor-consdiff/src/lib.rs index abefa32b6..4d1724220 100644 --- a/crates/tor-consdiff/src/lib.rs +++ b/crates/tor-consdiff/src/lib.rs @@ -568,6 +568,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-dirclient/src/lib.rs b/crates/tor-dirclient/src/lib.rs index e270b63ee..3e59e157c 100644 --- a/crates/tor-dirclient/src/lib.rs +++ b/crates/tor-dirclient/src/lib.rs @@ -481,6 +481,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use tor_rtmock::{io::stream_pair, time::MockSleepProvider}; diff --git a/crates/tor-dirclient/src/request.rs b/crates/tor-dirclient/src/request.rs index d7375283e..f01241a1b 100644 --- a/crates/tor-dirclient/src/request.rs +++ b/crates/tor-dirclient/src/request.rs @@ -628,6 +628,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-dirclient/src/response.rs b/crates/tor-dirclient/src/response.rs index cd34068ea..d8db81e68 100644 --- a/crates/tor-dirclient/src/response.rs +++ b/crates/tor-dirclient/src/response.rs @@ -179,6 +179,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-dirclient/src/util.rs b/crates/tor-dirclient/src/util.rs index b0a8aef54..74b95e2b9 100644 --- a/crates/tor-dirclient/src/util.rs +++ b/crates/tor-dirclient/src/util.rs @@ -33,6 +33,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-dirmgr/src/authority.rs b/crates/tor-dirmgr/src/authority.rs index 20a51bf12..ad062be64 100644 --- a/crates/tor-dirmgr/src/authority.rs +++ b/crates/tor-dirmgr/src/authority.rs @@ -87,6 +87,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use tor_netdoc::doc::authcert::AuthCertKeyIds; diff --git a/crates/tor-dirmgr/src/bootstrap.rs b/crates/tor-dirmgr/src/bootstrap.rs index 785215cf6..1bd3ca091 100644 --- a/crates/tor-dirmgr/src/bootstrap.rs +++ b/crates/tor-dirmgr/src/bootstrap.rs @@ -708,6 +708,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::storage::DynStore; diff --git a/crates/tor-dirmgr/src/bridgedesc/bdtest.rs b/crates/tor-dirmgr/src/bridgedesc/bdtest.rs index ea157db4e..4b03cade7 100644 --- a/crates/tor-dirmgr/src/bridgedesc/bdtest.rs +++ b/crates/tor-dirmgr/src/bridgedesc/bdtest.rs @@ -10,6 +10,7 @@ #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] +#![allow(clippy::needless_pass_by_value)] //! use std::future::Future; diff --git a/crates/tor-dirmgr/src/config.rs b/crates/tor-dirmgr/src/config.rs index a8ea5aa23..e93858fad 100644 --- a/crates/tor-dirmgr/src/config.rs +++ b/crates/tor-dirmgr/src/config.rs @@ -334,6 +334,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! #![allow(clippy::unnecessary_wraps)] use super::*; diff --git a/crates/tor-dirmgr/src/docid.rs b/crates/tor-dirmgr/src/docid.rs index 9486a6a64..1b5bb181b 100644 --- a/crates/tor-dirmgr/src/docid.rs +++ b/crates/tor-dirmgr/src/docid.rs @@ -292,6 +292,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use tor_basic_utils::test_rng::testing_rng; diff --git a/crates/tor-dirmgr/src/docmeta.rs b/crates/tor-dirmgr/src/docmeta.rs index 109b637b0..9e600fea9 100644 --- a/crates/tor-dirmgr/src/docmeta.rs +++ b/crates/tor-dirmgr/src/docmeta.rs @@ -142,6 +142,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-dirmgr/src/event.rs b/crates/tor-dirmgr/src/event.rs index d8e0fa58f..da2d2ddf4 100644 --- a/crates/tor-dirmgr/src/event.rs +++ b/crates/tor-dirmgr/src/event.rs @@ -826,6 +826,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use std::time::Duration; diff --git a/crates/tor-dirmgr/src/lib.rs b/crates/tor-dirmgr/src/lib.rs index a30b2dcb4..8b0feaf41 100644 --- a/crates/tor-dirmgr/src/lib.rs +++ b/crates/tor-dirmgr/src/lib.rs @@ -1143,6 +1143,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::docmeta::{AuthCertMeta, ConsensusMeta}; diff --git a/crates/tor-dirmgr/src/retry.rs b/crates/tor-dirmgr/src/retry.rs index 8bd1e0305..d6e057a19 100644 --- a/crates/tor-dirmgr/src/retry.rs +++ b/crates/tor-dirmgr/src/retry.rs @@ -123,6 +123,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use tor_basic_utils::test_rng::testing_rng; diff --git a/crates/tor-dirmgr/src/shared_ref.rs b/crates/tor-dirmgr/src/shared_ref.rs index 11ac4451c..1a8b61d92 100644 --- a/crates/tor-dirmgr/src/shared_ref.rs +++ b/crates/tor-dirmgr/src/shared_ref.rs @@ -104,6 +104,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; #[test] diff --git a/crates/tor-dirmgr/src/state.rs b/crates/tor-dirmgr/src/state.rs index c609567c3..d8b9e16f1 100644 --- a/crates/tor-dirmgr/src/state.rs +++ b/crates/tor-dirmgr/src/state.rs @@ -1250,6 +1250,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! #![allow(clippy::cognitive_complexity)] use super::*; diff --git a/crates/tor-dirmgr/src/storage.rs b/crates/tor-dirmgr/src/storage.rs index 580dcd282..a53d1ade8 100644 --- a/crates/tor-dirmgr/src/storage.rs +++ b/crates/tor-dirmgr/src/storage.rs @@ -354,6 +354,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use tempfile::tempdir; diff --git a/crates/tor-error/src/internal.rs b/crates/tor-error/src/internal.rs index 1e4778c38..592810fdc 100644 --- a/crates/tor-error/src/internal.rs +++ b/crates/tor-error/src/internal.rs @@ -263,6 +263,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-error/src/report.rs b/crates/tor-error/src/report.rs index 68c094fe4..0f5ea70ad 100644 --- a/crates/tor-error/src/report.rs +++ b/crates/tor-error/src/report.rs @@ -106,6 +106,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use std::io; diff --git a/crates/tor-error/src/retriable.rs b/crates/tor-error/src/retriable.rs index 17e175b3b..24909aa28 100644 --- a/crates/tor-error/src/retriable.rs +++ b/crates/tor-error/src/retriable.rs @@ -272,6 +272,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-events/src/lib.rs b/crates/tor-events/src/lib.rs index b4f2d46e3..30e4d00d4 100644 --- a/crates/tor-events/src/lib.rs +++ b/crates/tor-events/src/lib.rs @@ -298,6 +298,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use crate::{ broadcast, event_has_subscribers, EventReactor, StreamExt, TorEvent, TorEventKind, diff --git a/crates/tor-geoip/src/lib.rs b/crates/tor-geoip/src/lib.rs index b4e5948c0..a01f8f97c 100644 --- a/crates/tor-geoip/src/lib.rs +++ b/crates/tor-geoip/src/lib.rs @@ -402,6 +402,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-guardmgr/src/bridge/config.rs b/crates/tor-guardmgr/src/bridge/config.rs index 06df2ff06..b21f8efde 100644 --- a/crates/tor-guardmgr/src/bridge/config.rs +++ b/crates/tor-guardmgr/src/bridge/config.rs @@ -633,6 +633,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-guardmgr/src/config.rs b/crates/tor-guardmgr/src/config.rs index 4cafc4d11..9346f288b 100644 --- a/crates/tor-guardmgr/src/config.rs +++ b/crates/tor-guardmgr/src/config.rs @@ -43,6 +43,7 @@ pub(crate) mod testing { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-guardmgr/src/dirstatus.rs b/crates/tor-guardmgr/src/dirstatus.rs index 236612479..987c7eaca 100644 --- a/crates/tor-guardmgr/src/dirstatus.rs +++ b/crates/tor-guardmgr/src/dirstatus.rs @@ -74,6 +74,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-guardmgr/src/fallback/set.rs b/crates/tor-guardmgr/src/fallback/set.rs index 0664396b5..1a37b623e 100644 --- a/crates/tor-guardmgr/src/fallback/set.rs +++ b/crates/tor-guardmgr/src/fallback/set.rs @@ -238,6 +238,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-guardmgr/src/filter.rs b/crates/tor-guardmgr/src/filter.rs index ddb64fbfd..335296405 100644 --- a/crates/tor-guardmgr/src/filter.rs +++ b/crates/tor-guardmgr/src/filter.rs @@ -164,6 +164,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use float_eq::assert_float_eq; diff --git a/crates/tor-guardmgr/src/guard.rs b/crates/tor-guardmgr/src/guard.rs index 5e4d93e20..090e0d3a3 100644 --- a/crates/tor-guardmgr/src/guard.rs +++ b/crates/tor-guardmgr/src/guard.rs @@ -946,6 +946,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::ids::FirstHopId; diff --git a/crates/tor-guardmgr/src/lib.rs b/crates/tor-guardmgr/src/lib.rs index 41d349b0b..c13703fe2 100644 --- a/crates/tor-guardmgr/src/lib.rs +++ b/crates/tor-guardmgr/src/lib.rs @@ -1851,6 +1851,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use tor_linkspec::{HasAddrs, HasRelayIds}; diff --git a/crates/tor-guardmgr/src/sample.rs b/crates/tor-guardmgr/src/sample.rs index f7796344d..3374ca112 100644 --- a/crates/tor-guardmgr/src/sample.rs +++ b/crates/tor-guardmgr/src/sample.rs @@ -1029,6 +1029,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use tor_linkspec::{HasRelayIds, RelayIdType}; use tor_netdir::{NetDir, Relay}; diff --git a/crates/tor-guardmgr/src/skew.rs b/crates/tor-guardmgr/src/skew.rs index 470fa4a93..0233d64b4 100644 --- a/crates/tor-guardmgr/src/skew.rs +++ b/crates/tor-guardmgr/src/skew.rs @@ -240,6 +240,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use float_eq::assert_float_eq; diff --git a/crates/tor-guardmgr/src/util.rs b/crates/tor-guardmgr/src/util.rs index b5160b48d..4f2dc6ece 100644 --- a/crates/tor-guardmgr/src/util.rs +++ b/crates/tor-guardmgr/src/util.rs @@ -72,6 +72,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use tor_basic_utils::test_rng::testing_rng; diff --git a/crates/tor-hsclient/src/connect.rs b/crates/tor-hsclient/src/connect.rs index dbb9d595c..5c3253fd3 100644 --- a/crates/tor-hsclient/src/connect.rs +++ b/crates/tor-hsclient/src/connect.rs @@ -1483,6 +1483,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! #![allow(dead_code, unused_variables)] // TODO HS TESTS delete, after tests are completed diff --git a/crates/tor-hsclient/src/isol_map.rs b/crates/tor-hsclient/src/isol_map.rs index 7e0787eed..2d8297d3a 100644 --- a/crates/tor-hsclient/src/isol_map.rs +++ b/crates/tor-hsclient/src/isol_map.rs @@ -241,6 +241,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-hsclient/src/state.rs b/crates/tor-hsclient/src/state.rs index 8973eebac..abb8fb734 100644 --- a/crates/tor-hsclient/src/state.rs +++ b/crates/tor-hsclient/src/state.rs @@ -735,6 +735,7 @@ pub(crate) mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::*; diff --git a/crates/tor-hscrypto/src/ops.rs b/crates/tor-hscrypto/src/ops.rs index dcda9329a..1ee5e78dc 100644 --- a/crates/tor-hscrypto/src/ops.rs +++ b/crates/tor-hscrypto/src/ops.rs @@ -54,6 +54,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-hscrypto/src/pk.rs b/crates/tor-hscrypto/src/pk.rs index 2dce447fe..5bc054dd0 100644 --- a/crates/tor-hscrypto/src/pk.rs +++ b/crates/tor-hscrypto/src/pk.rs @@ -512,6 +512,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use hex_literal::hex; diff --git a/crates/tor-hscrypto/src/time.rs b/crates/tor-hscrypto/src/time.rs index dec95fee7..0ec159769 100644 --- a/crates/tor-hscrypto/src/time.rs +++ b/crates/tor-hscrypto/src/time.rs @@ -178,6 +178,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-keymgr/src/err.rs b/crates/tor-keymgr/src/err.rs index 040c2790f..4beee0534 100644 --- a/crates/tor-keymgr/src/err.rs +++ b/crates/tor-keymgr/src/err.rs @@ -57,6 +57,7 @@ mod tests { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use tor_error::ErrorKind; diff --git a/crates/tor-keymgr/src/key_specifier.rs b/crates/tor-keymgr/src/key_specifier.rs index 5a7d8ac68..18bc2bed7 100644 --- a/crates/tor-keymgr/src/key_specifier.rs +++ b/crates/tor-keymgr/src/key_specifier.rs @@ -116,6 +116,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-keymgr/src/key_type/ssh.rs b/crates/tor-keymgr/src/key_type/ssh.rs index 4e035d69b..79596e105 100644 --- a/crates/tor-keymgr/src/key_type/ssh.rs +++ b/crates/tor-keymgr/src/key_type/ssh.rs @@ -247,6 +247,7 @@ mod tests { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-keymgr/src/keystore/arti.rs b/crates/tor-keymgr/src/keystore/arti.rs index e2208865b..396aacbd1 100644 --- a/crates/tor-keymgr/src/keystore/arti.rs +++ b/crates/tor-keymgr/src/keystore/arti.rs @@ -171,6 +171,7 @@ mod tests { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::{ArtiPath, CTorPath}; diff --git a/crates/tor-keymgr/src/mgr.rs b/crates/tor-keymgr/src/mgr.rs index c28c7a487..7773b04f9 100644 --- a/crates/tor-keymgr/src/mgr.rs +++ b/crates/tor-keymgr/src/mgr.rs @@ -190,6 +190,7 @@ mod tests { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::{ArtiPath, ErasedKey, KeyType}; diff --git a/crates/tor-linkspec/src/decode.rs b/crates/tor-linkspec/src/decode.rs index 10f9b50fd..b3ab29ccc 100644 --- a/crates/tor-linkspec/src/decode.rs +++ b/crates/tor-linkspec/src/decode.rs @@ -131,6 +131,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use crate::OwnedChanTarget; diff --git a/crates/tor-linkspec/src/ids.rs b/crates/tor-linkspec/src/ids.rs index a46feabba..002d33d6e 100644 --- a/crates/tor-linkspec/src/ids.rs +++ b/crates/tor-linkspec/src/ids.rs @@ -361,6 +361,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use hex_literal::hex; use serde_test::{assert_tokens, Token}; diff --git a/crates/tor-linkspec/src/ids/by_id.rs b/crates/tor-linkspec/src/ids/by_id.rs index 4f99ab83f..eb3a7cac1 100644 --- a/crates/tor-linkspec/src/ids/by_id.rs +++ b/crates/tor-linkspec/src/ids/by_id.rs @@ -171,6 +171,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-linkspec/src/ids/set.rs b/crates/tor-linkspec/src/ids/set.rs index 9ed062dcf..ce32c6b72 100644 --- a/crates/tor-linkspec/src/ids/set.rs +++ b/crates/tor-linkspec/src/ids/set.rs @@ -146,6 +146,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-linkspec/src/ls.rs b/crates/tor-linkspec/src/ls.rs index 4853743e5..3049c8af0 100644 --- a/crates/tor-linkspec/src/ls.rs +++ b/crates/tor-linkspec/src/ls.rs @@ -244,6 +244,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use hex_literal::hex; diff --git a/crates/tor-linkspec/src/owned.rs b/crates/tor-linkspec/src/owned.rs index 46584b242..832d8c7f1 100644 --- a/crates/tor-linkspec/src/owned.rs +++ b/crates/tor-linkspec/src/owned.rs @@ -290,6 +290,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-linkspec/src/traits.rs b/crates/tor-linkspec/src/traits.rs index 3be260b27..425e766d9 100644 --- a/crates/tor-linkspec/src/traits.rs +++ b/crates/tor-linkspec/src/traits.rs @@ -361,6 +361,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use hex_literal::hex; diff --git a/crates/tor-linkspec/src/transport.rs b/crates/tor-linkspec/src/transport.rs index e020cf132..04723d09b 100644 --- a/crates/tor-linkspec/src/transport.rs +++ b/crates/tor-linkspec/src/transport.rs @@ -761,6 +761,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-linkspec/src/verbatim.rs b/crates/tor-linkspec/src/verbatim.rs index cb2a14d39..797b2358c 100644 --- a/crates/tor-linkspec/src/verbatim.rs +++ b/crates/tor-linkspec/src/verbatim.rs @@ -75,6 +75,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use crate::OwnedCircTarget; diff --git a/crates/tor-llcrypto/src/pk.rs b/crates/tor-llcrypto/src/pk.rs index 1a673f5ee..fbefc6208 100644 --- a/crates/tor-llcrypto/src/pk.rs +++ b/crates/tor-llcrypto/src/pk.rs @@ -77,6 +77,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! #[test] fn validatable_ed_sig() { diff --git a/crates/tor-llcrypto/src/pk/keymanip.rs b/crates/tor-llcrypto/src/pk/keymanip.rs index afd170276..9b9259b3e 100644 --- a/crates/tor-llcrypto/src/pk/keymanip.rs +++ b/crates/tor-llcrypto/src/pk/keymanip.rs @@ -337,6 +337,7 @@ mod tests { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-llcrypto/src/util/ct.rs b/crates/tor-llcrypto/src/util/ct.rs index 575444e00..458f94a28 100644 --- a/crates/tor-llcrypto/src/util/ct.rs +++ b/crates/tor-llcrypto/src/util/ct.rs @@ -136,6 +136,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-llcrypto/src/util/rand_compat.rs b/crates/tor-llcrypto/src/util/rand_compat.rs index 510ef9a17..1990099ed 100644 --- a/crates/tor-llcrypto/src/util/rand_compat.rs +++ b/crates/tor-llcrypto/src/util/rand_compat.rs @@ -135,6 +135,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use tor_basic_utils::test_rng::testing_rng; diff --git a/crates/tor-netdir/src/hsdir_params.rs b/crates/tor-netdir/src/hsdir_params.rs index 959189260..4dde0529e 100644 --- a/crates/tor-netdir/src/hsdir_params.rs +++ b/crates/tor-netdir/src/hsdir_params.rs @@ -251,6 +251,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use hex_literal::hex; diff --git a/crates/tor-netdir/src/hsdir_ring.rs b/crates/tor-netdir/src/hsdir_ring.rs index 5cef0eddb..2d0d984f1 100644 --- a/crates/tor-netdir/src/hsdir_ring.rs +++ b/crates/tor-netdir/src/hsdir_ring.rs @@ -261,6 +261,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-netdir/src/lib.rs b/crates/tor-netdir/src/lib.rs index cff7c887f..d4474f0e4 100644 --- a/crates/tor-netdir/src/lib.rs +++ b/crates/tor-netdir/src/lib.rs @@ -1985,6 +1985,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! #![allow(clippy::cognitive_complexity)] use super::*; diff --git a/crates/tor-netdir/src/params.rs b/crates/tor-netdir/src/params.rs index c3db9b02f..bf5e395f1 100644 --- a/crates/tor-netdir/src/params.rs +++ b/crates/tor-netdir/src/params.rs @@ -470,6 +470,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use std::string::String; diff --git a/crates/tor-netdir/src/testnet.rs b/crates/tor-netdir/src/testnet.rs index 5d8540f37..35c6dc250 100644 --- a/crates/tor-netdir/src/testnet.rs +++ b/crates/tor-netdir/src/testnet.rs @@ -290,6 +290,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; #[test] diff --git a/crates/tor-netdir/src/weight.rs b/crates/tor-netdir/src/weight.rs index 982eae712..0b5b2c662 100644 --- a/crates/tor-netdir/src/weight.rs +++ b/crates/tor-netdir/src/weight.rs @@ -411,6 +411,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use netstatus::RelayWeight as RW; diff --git a/crates/tor-netdoc/src/build.rs b/crates/tor-netdoc/src/build.rs index 578f7bac9..1f25b43c0 100644 --- a/crates/tor-netdoc/src/build.rs +++ b/crates/tor-netdoc/src/build.rs @@ -337,6 +337,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-netdoc/src/doc/authcert.rs b/crates/tor-netdoc/src/doc/authcert.rs index e940afc97..03ad0b023 100644 --- a/crates/tor-netdoc/src/doc/authcert.rs +++ b/crates/tor-netdoc/src/doc/authcert.rs @@ -378,6 +378,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::{Error, Pos}; diff --git a/crates/tor-netdoc/src/doc/authcert/build.rs b/crates/tor-netdoc/src/doc/authcert/build.rs index c349fab67..65b1e6628 100644 --- a/crates/tor-netdoc/src/doc/authcert/build.rs +++ b/crates/tor-netdoc/src/doc/authcert/build.rs @@ -140,6 +140,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use hex_literal::hex; diff --git a/crates/tor-netdoc/src/doc/hsdesc.rs b/crates/tor-netdoc/src/doc/hsdesc.rs index 125a91131..0341f7d38 100644 --- a/crates/tor-netdoc/src/doc/hsdesc.rs +++ b/crates/tor-netdoc/src/doc/hsdesc.rs @@ -571,6 +571,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use std::time::Duration; diff --git a/crates/tor-netdoc/src/doc/hsdesc/build.rs b/crates/tor-netdoc/src/doc/hsdesc/build.rs index ecb675f99..69747632c 100644 --- a/crates/tor-netdoc/src/doc/hsdesc/build.rs +++ b/crates/tor-netdoc/src/doc/hsdesc/build.rs @@ -250,6 +250,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use std::net::Ipv4Addr; diff --git a/crates/tor-netdoc/src/doc/hsdesc/build/inner.rs b/crates/tor-netdoc/src/doc/hsdesc/build/inner.rs index 8796f187e..c91eb768b 100644 --- a/crates/tor-netdoc/src/doc/hsdesc/build/inner.rs +++ b/crates/tor-netdoc/src/doc/hsdesc/build/inner.rs @@ -206,6 +206,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-netdoc/src/doc/hsdesc/build/middle.rs b/crates/tor-netdoc/src/doc/hsdesc/build/middle.rs index c166bbe93..3c0f50abe 100644 --- a/crates/tor-netdoc/src/doc/hsdesc/build/middle.rs +++ b/crates/tor-netdoc/src/doc/hsdesc/build/middle.rs @@ -136,6 +136,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-netdoc/src/doc/hsdesc/build/outer.rs b/crates/tor-netdoc/src/doc/hsdesc/build/outer.rs index 87a6f94a1..88753fc41 100644 --- a/crates/tor-netdoc/src/doc/hsdesc/build/outer.rs +++ b/crates/tor-netdoc/src/doc/hsdesc/build/outer.rs @@ -114,6 +114,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use std::time::UNIX_EPOCH; diff --git a/crates/tor-netdoc/src/doc/hsdesc/desc_enc.rs b/crates/tor-netdoc/src/doc/hsdesc/desc_enc.rs index 94ee40bc1..f731e3744 100644 --- a/crates/tor-netdoc/src/doc/hsdesc/desc_enc.rs +++ b/crates/tor-netdoc/src/doc/hsdesc/desc_enc.rs @@ -238,6 +238,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-netdoc/src/doc/hsdesc/inner.rs b/crates/tor-netdoc/src/doc/hsdesc/inner.rs index 038b1eb0c..5ff7d5135 100644 --- a/crates/tor-netdoc/src/doc/hsdesc/inner.rs +++ b/crates/tor-netdoc/src/doc/hsdesc/inner.rs @@ -436,6 +436,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use std::iter; diff --git a/crates/tor-netdoc/src/doc/hsdesc/middle.rs b/crates/tor-netdoc/src/doc/hsdesc/middle.rs index 9f53a617b..f89692e39 100644 --- a/crates/tor-netdoc/src/doc/hsdesc/middle.rs +++ b/crates/tor-netdoc/src/doc/hsdesc/middle.rs @@ -255,6 +255,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use hex_literal::hex; diff --git a/crates/tor-netdoc/src/doc/hsdesc/outer.rs b/crates/tor-netdoc/src/doc/hsdesc/outer.rs index 91dcb67df..a543b5be8 100644 --- a/crates/tor-netdoc/src/doc/hsdesc/outer.rs +++ b/crates/tor-netdoc/src/doc/hsdesc/outer.rs @@ -296,6 +296,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::doc::hsdesc::test_data::{TEST_DATA, TEST_SUBCREDENTIAL}; diff --git a/crates/tor-netdoc/src/doc/microdesc.rs b/crates/tor-netdoc/src/doc/microdesc.rs index 1708c0f1b..5f2ce3b96 100644 --- a/crates/tor-netdoc/src/doc/microdesc.rs +++ b/crates/tor-netdoc/src/doc/microdesc.rs @@ -467,6 +467,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use hex_literal::hex; diff --git a/crates/tor-netdoc/src/doc/microdesc/build.rs b/crates/tor-netdoc/src/doc/microdesc/build.rs index 164dab5c4..60ecb7b79 100644 --- a/crates/tor-netdoc/src/doc/microdesc/build.rs +++ b/crates/tor-netdoc/src/doc/microdesc/build.rs @@ -157,6 +157,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-netdoc/src/doc/netstatus.rs b/crates/tor-netdoc/src/doc/netstatus.rs index eefe0b174..1b6e1215f 100644 --- a/crates/tor-netdoc/src/doc/netstatus.rs +++ b/crates/tor-netdoc/src/doc/netstatus.rs @@ -1815,6 +1815,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use hex_literal::hex; diff --git a/crates/tor-netdoc/src/doc/netstatus/build.rs b/crates/tor-netdoc/src/doc/netstatus/build.rs index 2b760803f..cd5d502f3 100644 --- a/crates/tor-netdoc/src/doc/netstatus/build.rs +++ b/crates/tor-netdoc/src/doc/netstatus/build.rs @@ -398,6 +398,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::doc::netstatus::RelayFlags; diff --git a/crates/tor-netdoc/src/doc/routerdesc.rs b/crates/tor-netdoc/src/doc/routerdesc.rs index e288df40c..3f06254bf 100644 --- a/crates/tor-netdoc/src/doc/routerdesc.rs +++ b/crates/tor-netdoc/src/doc/routerdesc.rs @@ -895,6 +895,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; const TESTDATA: &str = include_str!("../../testdata/routerdesc1.txt"); diff --git a/crates/tor-netdoc/src/parse/parser.rs b/crates/tor-netdoc/src/parse/parser.rs index 3be5cc5b8..74a0d4914 100644 --- a/crates/tor-netdoc/src/parse/parser.rs +++ b/crates/tor-netdoc/src/parse/parser.rs @@ -316,6 +316,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::SectionRules; use crate::parse::keyword::Keyword; diff --git a/crates/tor-netdoc/src/parse/tokenize.rs b/crates/tor-netdoc/src/parse/tokenize.rs index eaf2d89d7..0070e3344 100644 --- a/crates/tor-netdoc/src/parse/tokenize.rs +++ b/crates/tor-netdoc/src/parse/tokenize.rs @@ -725,6 +725,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! #![allow(clippy::cognitive_complexity)] use super::*; diff --git a/crates/tor-netdoc/src/types/family.rs b/crates/tor-netdoc/src/types/family.rs index af733c6a0..859e3c2a1 100644 --- a/crates/tor-netdoc/src/types/family.rs +++ b/crates/tor-netdoc/src/types/family.rs @@ -96,6 +96,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::Result; diff --git a/crates/tor-netdoc/src/types/misc.rs b/crates/tor-netdoc/src/types/misc.rs index 491904a15..0ae590873 100644 --- a/crates/tor-netdoc/src/types/misc.rs +++ b/crates/tor-netdoc/src/types/misc.rs @@ -503,6 +503,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use itertools::Itertools; use std::iter; diff --git a/crates/tor-netdoc/src/types/policy.rs b/crates/tor-netdoc/src/types/policy.rs index c6fa97a08..7ed108342 100644 --- a/crates/tor-netdoc/src/types/policy.rs +++ b/crates/tor-netdoc/src/types/policy.rs @@ -172,6 +172,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::Result; diff --git a/crates/tor-netdoc/src/types/policy/addrpolicy.rs b/crates/tor-netdoc/src/types/policy/addrpolicy.rs index 514353864..58e4b8688 100644 --- a/crates/tor-netdoc/src/types/policy/addrpolicy.rs +++ b/crates/tor-netdoc/src/types/policy/addrpolicy.rs @@ -302,6 +302,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-netdoc/src/types/policy/portpolicy.rs b/crates/tor-netdoc/src/types/policy/portpolicy.rs index 328571453..31346d6d6 100644 --- a/crates/tor-netdoc/src/types/policy/portpolicy.rs +++ b/crates/tor-netdoc/src/types/policy/portpolicy.rs @@ -169,6 +169,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-netdoc/src/types/version.rs b/crates/tor-netdoc/src/types/version.rs index 2d0b2a405..1cd3f1e9b 100644 --- a/crates/tor-netdoc/src/types/version.rs +++ b/crates/tor-netdoc/src/types/version.rs @@ -189,6 +189,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-netdoc/src/util/batching_split_before.rs b/crates/tor-netdoc/src/util/batching_split_before.rs index 732a03ab7..ba4adbd29 100644 --- a/crates/tor-netdoc/src/util/batching_split_before.rs +++ b/crates/tor-netdoc/src/util/batching_split_before.rs @@ -326,6 +326,7 @@ mod tests { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::util::*; diff --git a/crates/tor-netdoc/src/util/intern.rs b/crates/tor-netdoc/src/util/intern.rs index f5e0a7cec..c5bb8ea44 100644 --- a/crates/tor-netdoc/src/util/intern.rs +++ b/crates/tor-netdoc/src/util/intern.rs @@ -89,6 +89,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-netdoc/src/util/str.rs b/crates/tor-netdoc/src/util/str.rs index 047706297..7d9d1b900 100644 --- a/crates/tor-netdoc/src/util/str.rs +++ b/crates/tor-netdoc/src/util/str.rs @@ -101,6 +101,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! #[test] diff --git a/crates/tor-persist/src/fs.rs b/crates/tor-persist/src/fs.rs index ec8db95a6..522f1f0e0 100644 --- a/crates/tor-persist/src/fs.rs +++ b/crates/tor-persist/src/fs.rs @@ -259,6 +259,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use std::{collections::HashMap, time::Duration}; diff --git a/crates/tor-persist/src/fs/clean.rs b/crates/tor-persist/src/fs/clean.rs index 70ab05e41..ef33d830e 100644 --- a/crates/tor-persist/src/fs/clean.rs +++ b/crates/tor-persist/src/fs/clean.rs @@ -109,6 +109,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-persist/src/testing.rs b/crates/tor-persist/src/testing.rs index dffb349e0..1f7d37b80 100644 --- a/crates/tor-persist/src/testing.rs +++ b/crates/tor-persist/src/testing.rs @@ -184,6 +184,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use serde::{Deserialize, Serialize}; diff --git a/crates/tor-proto/src/channel/circmap.rs b/crates/tor-proto/src/channel/circmap.rs index 48fa5b08d..cacd049bc 100644 --- a/crates/tor-proto/src/channel/circmap.rs +++ b/crates/tor-proto/src/channel/circmap.rs @@ -249,6 +249,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use futures::channel::{mpsc, oneshot}; diff --git a/crates/tor-proto/src/channel/padding.rs b/crates/tor-proto/src/channel/padding.rs index 94747db70..735bb29d1 100644 --- a/crates/tor-proto/src/channel/padding.rs +++ b/crates/tor-proto/src/channel/padding.rs @@ -413,6 +413,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-proto/src/channel/unique_id.rs b/crates/tor-proto/src/channel/unique_id.rs index dd4f3d633..5fd8e75b7 100644 --- a/crates/tor-proto/src/channel/unique_id.rs +++ b/crates/tor-proto/src/channel/unique_id.rs @@ -71,6 +71,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; #[test] diff --git a/crates/tor-proto/src/circuit.rs b/crates/tor-proto/src/circuit.rs index 4d5d64373..6233a9ba8 100644 --- a/crates/tor-proto/src/circuit.rs +++ b/crates/tor-proto/src/circuit.rs @@ -1200,6 +1200,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-proto/src/circuit/celltypes.rs b/crates/tor-proto/src/circuit/celltypes.rs index 3885bdb1b..ebab6eeae 100644 --- a/crates/tor-proto/src/circuit/celltypes.rs +++ b/crates/tor-proto/src/circuit/celltypes.rs @@ -93,6 +93,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-proto/src/circuit/halfstream.rs b/crates/tor-proto/src/circuit/halfstream.rs index 9c69cb53b..f6a328f39 100644 --- a/crates/tor-proto/src/circuit/halfstream.rs +++ b/crates/tor-proto/src/circuit/halfstream.rs @@ -81,6 +81,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::{ diff --git a/crates/tor-proto/src/circuit/sendme.rs b/crates/tor-proto/src/circuit/sendme.rs index 4f6a4b450..d8201b0c7 100644 --- a/crates/tor-proto/src/circuit/sendme.rs +++ b/crates/tor-proto/src/circuit/sendme.rs @@ -296,6 +296,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use tor_basic_utils::test_rng::testing_rng; diff --git a/crates/tor-proto/src/circuit/streammap.rs b/crates/tor-proto/src/circuit/streammap.rs index 0edf837ed..ce59970c0 100644 --- a/crates/tor-proto/src/circuit/streammap.rs +++ b/crates/tor-proto/src/circuit/streammap.rs @@ -264,6 +264,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::{circuit::sendme::StreamSendWindow, stream::DataCmdChecker}; diff --git a/crates/tor-proto/src/crypto/cell.rs b/crates/tor-proto/src/crypto/cell.rs index 4fff94e25..2ae20c476 100644 --- a/crates/tor-proto/src/crypto/cell.rs +++ b/crates/tor-proto/src/crypto/cell.rs @@ -484,6 +484,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use rand::RngCore; diff --git a/crates/tor-proto/src/crypto/handshake/fast.rs b/crates/tor-proto/src/crypto/handshake/fast.rs index 4f7bb1d9e..a2f86f77e 100644 --- a/crates/tor-proto/src/crypto/handshake/fast.rs +++ b/crates/tor-proto/src/crypto/handshake/fast.rs @@ -108,6 +108,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use crate::crypto::handshake::{ClientHandshake, KeyGenerator, ServerHandshake}; diff --git a/crates/tor-proto/src/crypto/handshake/hs_ntor.rs b/crates/tor-proto/src/crypto/handshake/hs_ntor.rs index deddf049a..266c64449 100644 --- a/crates/tor-proto/src/crypto/handshake/hs_ntor.rs +++ b/crates/tor-proto/src/crypto/handshake/hs_ntor.rs @@ -543,6 +543,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use hex_literal::hex; diff --git a/crates/tor-proto/src/crypto/handshake/ntor_v3.rs b/crates/tor-proto/src/crypto/handshake/ntor_v3.rs index 85e5b9e1c..969f57bed 100644 --- a/crates/tor-proto/src/crypto/handshake/ntor_v3.rs +++ b/crates/tor-proto/src/crypto/handshake/ntor_v3.rs @@ -638,6 +638,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use hex_literal::hex; diff --git a/crates/tor-proto/src/crypto/ll/kdf.rs b/crates/tor-proto/src/crypto/ll/kdf.rs index be7b0be80..fed05c2c9 100644 --- a/crates/tor-proto/src/crypto/ll/kdf.rs +++ b/crates/tor-proto/src/crypto/ll/kdf.rs @@ -129,6 +129,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use hex_literal::hex; diff --git a/crates/tor-proto/src/util/ct.rs b/crates/tor-proto/src/util/ct.rs index d2bbe53e2..58ac9630a 100644 --- a/crates/tor-proto/src/util/ct.rs +++ b/crates/tor-proto/src/util/ct.rs @@ -27,6 +27,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! #[test] fn test_bytes_eq() { diff --git a/crates/tor-proto/src/util/skew.rs b/crates/tor-proto/src/util/skew.rs index 4c85e6cca..724b3f42d 100644 --- a/crates/tor-proto/src/util/skew.rs +++ b/crates/tor-proto/src/util/skew.rs @@ -155,6 +155,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-proto/src/util/ts.rs b/crates/tor-proto/src/util/ts.rs index 00a039083..f9377f03c 100644 --- a/crates/tor-proto/src/util/ts.rs +++ b/crates/tor-proto/src/util/ts.rs @@ -96,6 +96,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-protover/src/lib.rs b/crates/tor-protover/src/lib.rs index f44149dff..4a4743704 100644 --- a/crates/tor-protover/src/lib.rs +++ b/crates/tor-protover/src/lib.rs @@ -476,6 +476,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-ptmgr/src/ipc.rs b/crates/tor-ptmgr/src/ipc.rs index be17ec5e3..d11a6a2c4 100644 --- a/crates/tor-ptmgr/src/ipc.rs +++ b/crates/tor-ptmgr/src/ipc.rs @@ -811,6 +811,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use crate::ipc::{PtMessage, PtStatus}; diff --git a/crates/tor-rpcbase/src/dispatch.rs b/crates/tor-rpcbase/src/dispatch.rs index a395ce86d..5500c245b 100644 --- a/crates/tor-rpcbase/src/dispatch.rs +++ b/crates/tor-rpcbase/src/dispatch.rs @@ -299,6 +299,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use crate::{Method, NoUpdates}; diff --git a/crates/tor-rpcbase/src/err.rs b/crates/tor-rpcbase/src/err.rs index 250f058ff..75e6cac19 100644 --- a/crates/tor-rpcbase/src/err.rs +++ b/crates/tor-rpcbase/src/err.rs @@ -146,6 +146,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-rpcbase/src/obj.rs b/crates/tor-rpcbase/src/obj.rs index 6bacf0a1c..1c834e696 100644 --- a/crates/tor-rpcbase/src/obj.rs +++ b/crates/tor-rpcbase/src/obj.rs @@ -340,6 +340,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-rpcbase/src/obj/cast.rs b/crates/tor-rpcbase/src/obj/cast.rs index 0707f1860..5c559e8ad 100644 --- a/crates/tor-rpcbase/src/obj/cast.rs +++ b/crates/tor-rpcbase/src/obj/cast.rs @@ -187,6 +187,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-rpcbase/src/typeid.rs b/crates/tor-rpcbase/src/typeid.rs index fb8ce7720..a0ff1b812 100644 --- a/crates/tor-rpcbase/src/typeid.rs +++ b/crates/tor-rpcbase/src/typeid.rs @@ -80,6 +80,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use assert_impl::assert_impl; diff --git a/crates/tor-rtcompat/src/async_std.rs b/crates/tor-rtcompat/src/async_std.rs index d29a0ea9d..dced917f7 100644 --- a/crates/tor-rtcompat/src/async_std.rs +++ b/crates/tor-rtcompat/src/async_std.rs @@ -159,6 +159,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-rtcompat/src/impls/rustls.rs b/crates/tor-rtcompat/src/impls/rustls.rs index 6cded7a01..f096a2fa5 100644 --- a/crates/tor-rtcompat/src/impls/rustls.rs +++ b/crates/tor-rtcompat/src/impls/rustls.rs @@ -242,6 +242,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-rtcompat/src/timer.rs b/crates/tor-rtcompat/src/timer.rs index 64e02bc7d..554420f8e 100644 --- a/crates/tor-rtcompat/src/timer.rs +++ b/crates/tor-rtcompat/src/timer.rs @@ -203,6 +203,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! #![allow(clippy::erasing_op)] use super::*; diff --git a/crates/tor-rtcompat/src/tokio.rs b/crates/tor-rtcompat/src/tokio.rs index 6391eadb8..697af2ff5 100644 --- a/crates/tor-rtcompat/src/tokio.rs +++ b/crates/tor-rtcompat/src/tokio.rs @@ -229,6 +229,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-rtmock/src/io.rs b/crates/tor-rtmock/src/io.rs index f33c7d383..5efa3b06f 100644 --- a/crates/tor-rtmock/src/io.rs +++ b/crates/tor-rtmock/src/io.rs @@ -192,6 +192,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-rtmock/src/net.rs b/crates/tor-rtmock/src/net.rs index 58cbb9ab8..7dae1e5ff 100644 --- a/crates/tor-rtmock/src/net.rs +++ b/crates/tor-rtmock/src/net.rs @@ -574,6 +574,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use futures::io::{AsyncReadExt, AsyncWriteExt}; diff --git a/crates/tor-rtmock/src/task.rs b/crates/tor-rtmock/src/task.rs index 329aca135..1cf29246a 100644 --- a/crates/tor-rtmock/src/task.rs +++ b/crates/tor-rtmock/src/task.rs @@ -656,6 +656,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use futures::channel::mpsc; diff --git a/crates/tor-rtmock/src/time.rs b/crates/tor-rtmock/src/time.rs index 164dce7f8..824095c37 100644 --- a/crates/tor-rtmock/src/time.rs +++ b/crates/tor-rtmock/src/time.rs @@ -458,6 +458,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use tor_rtcompat::test_with_all_runtimes; diff --git a/crates/tor-socksproto/src/handshake.rs b/crates/tor-socksproto/src/handshake.rs index 6a9121831..6d3006219 100644 --- a/crates/tor-socksproto/src/handshake.rs +++ b/crates/tor-socksproto/src/handshake.rs @@ -96,6 +96,7 @@ mod test_roundtrip { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; diff --git a/crates/tor-socksproto/src/handshake/proxy.rs b/crates/tor-socksproto/src/handshake/proxy.rs index 8389799c5..942803bc1 100644 --- a/crates/tor-socksproto/src/handshake/proxy.rs +++ b/crates/tor-socksproto/src/handshake/proxy.rs @@ -309,6 +309,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*; use hex_literal::hex; diff --git a/crates/tor-socksproto/src/msg.rs b/crates/tor-socksproto/src/msg.rs index c21987bb0..83f3691e3 100644 --- a/crates/tor-socksproto/src/msg.rs +++ b/crates/tor-socksproto/src/msg.rs @@ -423,6 +423,7 @@ mod test { #![allow(clippy::unwrap_used)] #![allow(clippy::unchecked_duration_subtraction)] #![allow(clippy::useless_vec)] + #![allow(clippy::needless_pass_by_value)] //! use super::*;