Merge branch 'update-keymgr-todo' into 'main'

keymgr: Change "TODO hs" to "TODO HSS".

See merge request tpo/core/arti!1264
This commit is contained in:
Alexander Færøy 2023-06-20 13:42:28 +00:00
commit 2fa8a4e56c
3 changed files with 4 additions and 3 deletions

View File

@ -1,6 +1,6 @@
//! Traits for converting keys to and from OpenSSH format.
//
// TODO hs: OpenSSH keys can have passphrases. While the current implementation isn't able to
// TODO HSS (#902): OpenSSH keys can have passphrases. While the current implementation isn't able to
// handle such keys, we will eventually need to support them (this will be a breaking API change).
use ssh_key::private::KeypairData;

View File

@ -105,6 +105,7 @@ impl KeyStore for ArtiNativeKeyStore {
}
fn has_key_bundle(&self, _key_spec: &dyn KeySpecifier) -> Result<bool> {
todo!()
// TODO HSS (#903): implement
Ok(true)
}
}

View File

@ -64,7 +64,7 @@ impl KeyMgr {
/// If the key already exists, it is overwritten.
///
// TODO hs: would it be useful for this API to return a Result<Option<K>> here (i.e. the old key)?
// TODO hs: define what "key bundle" means
// TODO HSS (#903): define what "key bundle" means
pub fn insert<K: ToEncodableKey>(&self, key: K, key_spec: &dyn KeySpecifier) -> Result<()> {
// TODO hs: maybe we should designate an explicit 'primary' store instead of implicitly
// preferring the first one.