From 32c2bc4bc1459950d33d2a0dd71f508cb4ff20cf Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Sun, 18 Oct 2020 17:06:15 -0400 Subject: [PATCH] Clarify TODOs in tor-protover --- tor-protover/src/lib.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tor-protover/src/lib.rs b/tor-protover/src/lib.rs index 8710caa0a..7e8f93c3d 100644 --- a/tor-protover/src/lib.rs +++ b/tor-protover/src/lib.rs @@ -393,15 +393,16 @@ fn dumpmask(mut mask: u64) -> String { let zeros = mask.trailing_zeros(); mask >>= zeros; shift += zeros; - // We'd like to do it this way, but trailing_ones() is not yet - // in stable Rust. (TODO) + // TODO: We'd like to do it this way, but trailing_ones() is + // not yet in enough versions of stable Rust. (It landed in + // Rust 1.46.) // let ones = mask.trailing_ones(); let ones = (!mask).trailing_zeros(); append(&mut result, shift, shift + ones - 1); shift += ones; if ones == 64 { // We have to do this check to avoid overflow when formatting - // the range 0-63. XXXX (It's a bit ugly, isn't it?) + // the range `0-63`. break; } mask >>= ones;