Merge branch 'future_proof_lints' into 'main'

add_warning: Change missing_docs,unreachable_pub to warn

Closes #951

See merge request tpo/core/arti!1470

crates/arti-bench/src/main.rs

@@ -6,9 +6,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/arti-client/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/arti-config/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/arti-hyper/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/arti-rpcserver/src/lib.rs

@@ -2,9 +2,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/arti-testing/src/main.rs

@@ -51,9 +51,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/arti/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/arti/src/main.rs

@@ -5,9 +5,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/caret/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/equix/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/fs-mistrust/src/lib.rs

@@ -9,9 +9,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/hashx/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/retry-error/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/safelog/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-async-utils/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-basic-utils/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-bytes/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-cell/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-cert/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-chanmgr/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-checkable/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-circmgr/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-config/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-congestion/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-consdiff/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-dirclient/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-dirmgr/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-error/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-events/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-geoip/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-guardmgr/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-hsclient/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-hscrypto/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-hspow/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-hsservice/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-keymgr/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-linkspec/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-llcrypto/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-netdir/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-netdoc/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-persist/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-proto/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-protover/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-ptmgr/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-rpcbase/src/lib.rs

@@ -2,9 +2,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-rtcompat/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-rtmock/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-socksproto/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

crates/tor-units/src/lib.rs

@@ -3,9 +3,9 @@
 // @@ begin lint list maintained by maint/add_warning @@
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]

maint/add_warning

@@ -10,12 +10,17 @@ import subprocess
 
 # ---------- actual list of lints to apply (or disapply) ----------
 
+# NOTE: We should NEVER have a `deny` for a built-in rustc lint.
+# It's okay to deny clippy lints, but if we deny rustc lints,
+# a future version of the compiler might refuse to build our code
+# entirely.
+
 WANT_LINTS = """
 #![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))]
 #![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))]
-#![deny(missing_docs)]
+#![warn(missing_docs)]
 #![warn(noop_method_call)]
-#![deny(unreachable_pub)]
+#![warn(unreachable_pub)]
 #![warn(clippy::all)]
 #![deny(clippy::await_holding_lock)]
 #![deny(clippy::cargo_common_metadata)]