diff --git a/crates/arti-client/src/err.rs b/crates/arti-client/src/err.rs index 377e9670e..9d9d1139b 100644 --- a/crates/arti-client/src/err.rs +++ b/crates/arti-client/src/err.rs @@ -21,6 +21,9 @@ macro_rules! define_according_to_cfg_error_details { { $vis:vis } => { /// to check what kind of error it is, #[derive(Error, Debug)] // TODO #[derive(Clone)] // we need to make everything inside Clone first +// TODO Use assert_impl! or something to ensure this is Send Sync Clone Debug Display 'static +// as per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/262#note_2772823 +// bullet point 5 #[allow(clippy::exhaustive_structs)] pub struct TorError { /// The actual error diff --git a/crates/tor-chanmgr/src/err.rs b/crates/tor-chanmgr/src/err.rs index b49b8ce5d..bd26712d0 100644 --- a/crates/tor-chanmgr/src/err.rs +++ b/crates/tor-chanmgr/src/err.rs @@ -34,6 +34,11 @@ pub enum Error { /// Who we were talking to peer: SocketAddr, + // TODO + // /// What we were doing + // action: &'static str, + // as per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/262#note_2772820 + /// What happened. Might be some TLS library error wrapped up in io::Error #[source] source: Arc,