From 4003e032d6e8d7e49d48a024e4a73857eabca570 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Mon, 26 Jun 2023 12:42:08 -0400 Subject: [PATCH] Remove spurious todo-hs items in tor-cert. I am not sure why we wrote these comments, but they are incorrect: I've investigated the C code and found only 3 key types. The "unimplemented" types that the TODO comment here complains about are in fact certificate types. --- crates/tor-cert/src/lib.rs | 6 ------ 1 file changed, 6 deletions(-) diff --git a/crates/tor-cert/src/lib.rs b/crates/tor-cert/src/lib.rs index 751d9e701..3741e9318 100644 --- a/crates/tor-cert/src/lib.rs +++ b/crates/tor-cert/src/lib.rs @@ -150,10 +150,6 @@ caret_int! { SHA256_OF_RSA = 0x02, /// Identifies the SHA256 of an X.509 certificate. SHA256_OF_X509 = 0x03, - - // 08 through 09 and 0B are used for onion services. They - // probably shouldn't be, but that's what Tor does. - // TODO hs: Add these types. } } @@ -198,8 +194,6 @@ pub enum CertifiedKey { X509Sha256Digest([u8; 32]), /// Some unrecognized key type. Unrecognized(UnrecognizedKey), - // TODO hs: Add new alternatives here for the case that we're handling key types from - // onion services. These will correspond to types in tor-hscrypto. } /// A key whose type we didn't recognize.