vincenzopalazzo
/
arti
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Explain a testing oddity in tor-dirclient.

This commit is contained in:
Nick Mathewson 2022-02-03 09:17:34 -05:00
parent c302c6a8bd
commit 7b8ad0ca2c
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
crates/tor-dirclient/src/lib.rs
View File

@ -635,7 +635,17 @@ mod test {
async {
// Send back a response.
s2_w.write_all(response).await?;
// wait a moment to give the other side time to notice it has data.
// We wait a moment to give the other side time to notice it
// has data.
//
// (Tentative diagnosis: The `async-compress` crate seems to
// be behave differently depending on whether the "close"
// comes right after the incomplete data or whether it comes
// after a delay. If there's a delay, it notices the
// truncated data and tells us about it. But when there's
// _no_delay, it treats the data as an error and doesn't
// tell our code.)
// TODO: sleeping in tests is not great.
rt2.sleep(Duration::from_millis(50)).await;
s2_w.close().await?;