Merge branch 'pt-todo-highlevel' into 'main'

Dispose of all TODO pt-client in arti-*

See merge request tpo/core/arti!909

crates/arti-client/src/client.rs

@@ -508,9 +508,6 @@ impl<R: Runtime> TorClient<R> {
         #[cfg(feature = "bridge-client")]
         let bridge_desc_mgr = Arc::new(Mutex::new(None));
 
-        // TODO pt-client: We'll need to tell the ptmgr to launch any background
-        // tasks, if it has not already done so.
-
         runtime
             .spawn(tasks_monitor_dormant(
                 dormant_recv,

crates/arti-client/src/config.rs

@@ -210,14 +210,6 @@ impl StorageConfig {
 
 /// Configuration for bridges and pluggable transports
 //
-// TODO pt-client: This type is too high up the stack:
-// It is likely that this type will want to move much lower down in the crate
-// stack so that (eg) guardmgr can actually do something useful with the `BridgeList`
-// and resolve the situation with `enabled` and so on.
-//
-// Possibly guardmgr will want to take an `Arc<dyn AsRef<BridgesConfig>>` or something;
-// that would enable passing it an "extract" from the config without actually copying it.
-//
 // We leave this as an empty struct even when bridge support is disabled,
 // as otherwise the default config file would generate an unknown section warning.
 #[derive(Debug, Clone, Builder, Eq, PartialEq)]

crates/arti/src/cfg.rs

@@ -565,10 +565,9 @@ mod test {
     ///
     /// Used by `exhaustive_1`.
     const CONFIG_KEYS_EXPECT_NO_EXAMPLE: &[&str] = &[
-        // TODO pt-client: Provide a test case that parses the (more complicated)
-        // example present in ARTI_EXAMPLE_CONFIG.
-        // https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/823#note_2854365
-        // and bullet points 2 and 3 in the doc for `exhaustive_1`, below.
+        // TODO: Provide a test case that parses the `[bridges.transports]` example.
+        // See and bullet points 2 and 3 in the doc for `exhaustive_1`, below.
+        // https://gitlab.torproject.org/tpo/core/arti/-/issues/674
         #[cfg(feature = "pt-client")]
         "bridges.transports",
         "tor_network.authorities",