From ac2c56f92da0546156a22410c81f7a5c789c5ef6 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Tue, 21 Mar 2023 12:32:15 +0000 Subject: [PATCH] Obscure various literal uses of the todo marker In each case, use a circumlocution. --- CHANGELOG.md | 2 +- maint/binary_size | 2 +- maint/fixup-features/src/main.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 08bd7bd22..76a310248 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2045,7 +2045,7 @@ release 0.1.0 (scheduled March 2022). - We store fewer needless fields from Tor directory documents. ([!151], [!165]) -- We've gone through and converted _every_ `XXXX` comment in our code (which +- We've gone through and converted _every_ XXXX comment in our code (which indicated a must-fix issue) into a ticket, or a `TODO`. ([#231]) - Our SOCKS code is much more careful about sending error messages if an error occurs before the SOCKS connection succeeds. ([!189]) diff --git a/maint/binary_size b/maint/binary_size index 85ec23b2c..8fa16ac0b 100755 --- a/maint/binary_size +++ b/maint/binary_size @@ -6,7 +6,7 @@ set -euo pipefail ORIGDIR=$(pwd) -TMPDIR=$(mktemp -d -t arti_binsize.XXXXXX) +TMPDIR=$(mktemp -d -t arti_binsize."XX""XX""XX") trap 'cd "$ORIGDIR" && rm -rf "$TMPDIR"' 0 RUST_TARGET=$(rustc -vV | sed -n 's|host: ||p') diff --git a/maint/fixup-features/src/main.rs b/maint/fixup-features/src/main.rs index 127ab4aeb..f7ce92322 100644 --- a/maint/fixup-features/src/main.rs +++ b/maint/fixup-features/src/main.rs @@ -120,7 +120,7 @@ fn arti_dependencies(dependencies: &Table) -> Vec { /// A complaint that we add to features which are not reachable according to /// rule 3. -const COMPLAINT: &str = "# XXXX Add this to a top-level feature!\n"; +const COMPLAINT: &str = "# XX\x58X Add this to a top-level feature!\n"; impl Crate { /// Try to read a crate's Cargo.toml from a given filename.