Add comments about the absence of tap_key in microdesc.

This commit is contained in:
Nick Mathewson 2021-11-30 14:05:13 -05:00
parent 9afe5c09e7
commit e2a7289aa7
2 changed files with 7 additions and 1 deletions

View File

@ -71,6 +71,8 @@ pub struct Microdesc {
ed25519_id: ed25519::Ed25519Identity,
// addr is obsolete and doesn't go here any more
// pr is obsolete and doesn't go here any more.
// The legacy "tap" onion-key is obsolete, and though we parse it, we don't
// save it.
}
impl Microdesc {
@ -262,7 +264,8 @@ impl Microdesc {
util::str::str_offset(s, first.kwd_str()).unwrap()
};
// Legacy (tap) onion key
// Legacy (tap) onion key. We parse this to make sure it's well-formed,
// but then we discard it immediately, since we never want to use it.
let _: rsa::PublicKey = body
.required(ONION_KEY)?
.parse_obj::<RsaPublic>("RSA PUBLIC KEY")?

View File

@ -20,3 +20,6 @@ We can delete older sections here after we bump the releases.
## Since Arti 0.0.2
tor-proto: MODIFIED
(New constructor for HsNtorClientInput)
tor-netdoc: BREAKING
(No more tap_key function in MicrodescBuilder)