From e4ac39e6389a3fdb25b2ae9014106c1885241e3e Mon Sep 17 00:00:00 2001
From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed, 30 Nov 2022 15:09:58 +0000
Subject: [PATCH] bridge config: Add a TODO about a redundant clone

---
 crates/tor-guardmgr/src/bridge/config.rs | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/crates/tor-guardmgr/src/bridge/config.rs b/crates/tor-guardmgr/src/bridge/config.rs
index 9974dea2a..6455cb771 100644
--- a/crates/tor-guardmgr/src/bridge/config.rs
+++ b/crates/tor-guardmgr/src/bridge/config.rs
@@ -370,6 +370,9 @@ impl FromStr for BridgeConfigBuilder {
                 let (transport, addr, settings) = target.into_parts();
                 let addr: Option<BridgeAddr> = addr.into();
                 let addrs = addr.into_iter().collect_vec();
+                // TODO transport.to_string() clones transport and then drops it
+                // PtTransportName::into_inner ought to exist but was deleted
+                // in 119e5f6f754251e0d2db7731f9a7044764f4653e
                 (transport.to_string(), addrs, settings.into_inner())
             }
             other => {