channel padding: chanmgr: Clarify a comment

As per
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/586#note_2813574
This commit is contained in:
Ian Jackson 2022-06-17 11:54:46 +01:00
parent 65e6683b0b
commit ff228e5d9c
1 changed files with 3 additions and 3 deletions

View File

@ -211,9 +211,9 @@ impl<CF: ChannelFactory> AbstractChanMgr<CF> {
// others, and return it.
self.channels
.replace_with_config(ident.clone(), |channels_config| {
// This isn't great. We switch to the newly-created channel
// just to tell it how and whether to do padding. Ideally we
// would pass the config at some suitable point during
// This isn't great. We context switch to the newly-created
// channel just to tell it how and whether to do padding. Ideally
// we would pass the config at some suitable point during
// building. However, that would involve the channel taking a
// copy of the config, and that must happen in the same channel
// manager lock acquisition span as the one where we insert the