> Check the Read Me file for Cargo Husky crate for details
>
> https://github.com/rhysd/cargo-husky#readme
These changes allow for local `git commit` and `git push` related hooks to more
closely match remote CI/CD operations. Most notably the `cargo clippy...` lint
command from ".gitlab-ci.yml" file now may guard against committing/pushing
code that would otherwise cause CI/CD pipeline failures.
(While messing around with test coverage on `in_same_subnet`, I
found that there was a copy-paste error where we were using v4_bits
when v6_bits would have been appropriate.)
> Check `implicit_clone` section of Clippy documentation for details;
>
> https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone
This adds, and addresses, the following Clippy configuration to crates;
#![deny(clippy::implicit_clone)]
And moves related line within `maint/add_warning.py` file. My intent is to
mitigate extra edits after merging, so please let me know if I need to do this
last bit differently.
> Check `missing_panics_doc` section of Clippy documentation for details;
>
> https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
This adds the following Clippy configuration to crates;
#![deny(clippy::missing_panics_doc)]
And adds necessary doc-comments to methods that may panic.
These aren't true coverage improvements; they're just either
improving the coverage of test code, or telling the coverage tool
that it shouldn't worry about code in the fuzzers.
> Check `cast_lossless` section of Clippy documentation for details;
>
> https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
This adds the following Clippy configuration to crates;
#![deny(clippy::cast_lossless)]
And applies suggested Clippy and `cargo fmt` fixes.
Our path-spec says that, if we don't have enough build-time data to
make a good estimate for our timeouts, we should periodically try
launching testing circuits just to see how long they take to build.
Here we implement that. The implementation is a bit wonky because
of how our crates are factored; see arti#161 for more info.
Closes#145.
Closes#57.