Ian Jackson
1f067c0237
tor-netdoc: Suppress new "unused_macro_rules" lint in one place
...
The compiler can apparently tell that we aren't generating compile
errors! Also that we're not yet using a feature provided here.
(New lint in currently Nightly.)
2022-05-27 17:36:52 +01:00
Nick Mathewson
4326aa1de9
Regenerate version bump from previous commit.
...
This commit was made by reverting the previous commit, then
re-running the script I used to generate it. In theory there should
be no semantic changes: only changes due to improved formatting from
cargo edit.
2022-05-27 10:18:52 -04:00
Nick Mathewson
b232365a75
Semantic version changes for Arti 0.4.0 release
...
I followed the following procedure to make these changes:
* I used maint/changed_crates to find out which crates had changed
since 0.3.0.
* I used grep and maint/list_crates to sort those crates in
topological (dependency) order.
* I looked through semver_status to find which crates were listed as
having semver-relevant changes (new APIs and breaking changes).
* I scanned through the git logs of the crates with no
semver-relevant changes listed to confirm that, indeed, they had
no changes. For those crates, I incremented their patch-level
version _without_ changing the version that other crates depend on.
* I scanned through the git logs of the crates with no
semver-relevant changes listed to confirm that, indeed, they had
no obvious breaking changes.
* I treated all crates that depend on `arti` and/or `arti-client` as
having breaking changes.
* I identified crates that depend on crates that have changed, even
if they have not changed themselves, and identified them as having
a non-breaking change.
* For all of the crates, I used `cargo set-version -p $CRATE --bump
$STATUS` (where `STATUS` is `patch` or `minor`) to update the
versions, and the depended-upon versions.
2022-05-27 09:01:20 -04:00
Nick Mathewson
45d21d2520
Bump versions of trivially-changed crates.
...
These crates had only clippy fixes that do not affect their
behavior:
tor-bytes
tor-cell
tor-events
tor-linkspec
tor-netdir
tor-socksproto
This crate only had the cargo-husky dependency removed, which
does not affect compatibility:
tor-llcrypto
Since these changes have no compatibility effects, it is not
necessary to bump the versions of these crates which other crates
depend on.
2022-05-27 08:52:44 -04:00
Nick Mathewson
fbc5218af6
Update tor-config README.md.
2022-05-27 08:34:52 -04:00
Nick Mathewson
b4a87687f5
Fix a link with nightly rustdoc
2022-05-26 15:40:39 -04:00
Nick Mathewson
ae08a023fb
Merge branch 'tests-20220525' into 'main'
...
Add a few coverage-driven tests
See merge request tpo/core/arti!536
2022-05-26 14:35:32 +00:00
Nick Mathewson
c33a9d1f4e
Remove some stray dbg!() calls.
2022-05-26 09:59:48 -04:00
Nick Mathewson
68b0419752
Merge branch 'standardise-shell' into 'main'
...
Standardise shell
Closes #425
See merge request tpo/core/arti!533
2022-05-26 12:53:14 +00:00
Ian Jackson
4bf87d61ca
Merge branch 'config-split' into 'main'
...
Break TorClientConfig out of ArtiConfig and warn on unknown config keys
Closes #459 and #417
See merge request tpo/core/arti!529
2022-05-26 10:40:43 +00:00
Ian Jackson
c5a8e453b9
tor-config: load: clippy: adopt two suggestions
...
We can have mem::take, hooray.
2022-05-26 11:03:48 +01:00
Ian Jackson
42ccb68446
tor-config: load: Add missing "not".
...
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807331
2022-05-26 10:57:26 +01:00
Ian Jackson
f5561c8cdb
tor-config: load: Make UnrecognizedKeys not pub
...
This was a slip.
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807330
2022-05-26 10:57:04 +01:00
trinity-1686a
b380c25e66
update readmes
2022-05-25 22:25:58 +02:00
Nick Mathewson
60023ef656
Test a few more corner cases in tor-persist
...
Also, if we get an IoError from a call to fs-mistrust, report it as
an IoError.
2022-05-25 15:57:19 -04:00
Nick Mathewson
bbc7470dc5
More tests for ClockSkew.
2022-05-25 15:57:19 -04:00
Nick Mathewson
7c86e0a6b3
Merge branch 'no-disable-arti-permission-checks' into 'main'
...
ci: don't disable arti permission checks, fix resulting issues
See merge request tpo/core/arti!530
2022-05-25 19:42:32 +00:00
Ian Jackson
ed95d50d49
tor-config: load: Add reversed test
2022-05-25 19:15:47 +01:00
Ian Jackson
ce96f0d9ce
tor-config: Add duplicative doc comments as per review
2022-05-25 19:15:47 +01:00
Ian Jackson
21a064d4f8
tor-config: load: example: Document what it does and who might write it
2022-05-25 19:15:47 +01:00
Ian Jackson
3eab61603a
tor-config: load: Add a newline
...
This makes the function a tiny bit clearer.
2022-05-25 19:15:47 +01:00
Ian Jackson
bf97190a9f
tor-config: load: Write actual definition of the Resolvable trait
...
This is not a doc comment because we don't want it to be public: it
must refer to private fields, etc.
2022-05-25 19:15:47 +01:00
Ian Jackson
80ddae3d4b
arti: Better doc for ArtiCombinedConfig
2022-05-25 19:15:47 +01:00
Ian Jackson
2b65e1250e
tor-config: load: Explain why not write out macro call n times
2022-05-25 19:15:47 +01:00
Ian Jackson
1ee2be9d6d
tor-config: docs: add more docs about load, esp. traits
2022-05-25 19:15:47 +01:00
Ian Jackson
337b4a7231
tor-config: docs: add a lot of context and overview and xrefs
2022-05-25 19:15:47 +01:00
Ian Jackson
40b433d4ba
tor-config: load: Avoid destructuring assignment
...
Not available in our MSRV.
2022-05-25 19:15:47 +01:00
Ian Jackson
b552c4e2bf
tor-config: load: Intersection: add more commentary
2022-05-25 19:15:47 +01:00
Ian Jackson
5661df823f
tor-config: load: Drop a needless call to .into_iter()
...
I think this is a leftover from a previous version of this expression.
2022-05-25 19:15:47 +01:00
Ian Jackson
a8a3661503
tor-config: load: Fix a misleading comment
...
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807070
2022-05-25 19:15:47 +01:00
Ian Jackson
964794bfa0
tor-config: load: Rename shorter_let
...
Instead of the wrong "prefix_len". As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807068
2022-05-25 19:15:47 +01:00
Ian Jackson
26715c5550
tor-config: load: Docs
2022-05-25 19:15:47 +01:00
Ian Jackson
4f62c3ded1
tor-config: Typo fixes (as per review comments)
2022-05-25 19:15:47 +01:00
Ian Jackson
28c1f707a1
tor-config: load: Introduce UnrecognizedKeys enum
...
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807078
This is in fact much clearer than the Option.
2022-05-25 19:15:47 +01:00
Ian Jackson
151d28c90f
Run rustfmt following renaming
...
Split into its own commit to avoid churn in the rename commits.
2022-05-25 16:41:50 +01:00
Ian Jackson
0803296bd6
tor-config: Rename resolve_return_unrecognized, ..._ignore_...
...
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807077
2022-05-25 16:41:05 +01:00
Ian Jackson
9f426e2c57
tor-config: Rename "ignored" to "unrecognized" throughout
...
As per review comments
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807076
2022-05-25 16:40:02 +01:00
Ian Jackson
e9538a7eef
Merge branch 'no_nochange' into 'main'
...
DirMgr:: Remove Error::NoChange as redundant.
Closes #484
See merge request tpo/core/arti!532
2022-05-25 14:35:32 +00:00
Alex Xu (Hello71)
85b4b5620d
fs-mistrust: allow symlinks to have any permissions
2022-05-25 10:27:45 -04:00
Ian Jackson
4b0459d204
Merge branch 'bug475' into 'main'
...
ConfigurationSources: Allow config files to be world-readable.
Closes #475
See merge request tpo/core/arti!528
2022-05-25 14:23:12 +00:00
Nick Mathewson
52a338a378
Merge branch 'socks-errors' into 'main'
...
reply socks error on more codepath
Closes #258
See merge request tpo/core/arti!531
2022-05-25 13:13:18 +00:00
Nick Mathewson
0caa5bcba5
DirMgr:: Remove Error::NoChange as redundant.
...
Now that the relevant functions now report changed/not-changed
status via a boolean out-parameter (see !527 ), there's no reason to
have a separate NoChanged error case.
Closes #484 .
2022-05-25 08:58:37 -04:00
Nick Mathewson
3b837eb7f4
Typo fixes (automated with "typos").
2022-05-24 19:21:12 -04:00
trinity-1686a
801380780f
reply socks error on more codepath
2022-05-25 00:02:14 +02:00
Nick Mathewson
92f0f97fe8
Merge branch 'isolation-example' into 'main'
...
add example for Isolation
Closes #414
See merge request tpo/core/arti!524
2022-05-24 19:34:14 +00:00
eta
608d0cbcc2
Merge branch 'bug482' into 'main'
...
DirMgr: Stop load-from-cache process when there is no change.
Closes #482
See merge request tpo/core/arti!527
2022-05-24 19:33:42 +00:00
Ian Jackson
9c88158740
tor-config: Example for load module
2022-05-24 20:14:57 +01:00
Ian Jackson
bb8e205b0d
tor-config: Tests for ignored config key handling
2022-05-24 20:14:57 +01:00
Ian Jackson
09f26f2d68
tor-config: Track and (by default) warn on ignored config keys
2022-05-24 20:14:57 +01:00
Ian Jackson
e1bc599db2
tor-config: Tests for support functions for tracking ignored keys
2022-05-24 20:14:57 +01:00