Commit Graph

7761 Commits

Author SHA1 Message Date
Nick Mathewson 4cf972d69b tor-proto API: Use new_ref, not clone.
Semantically, cloning a Channel or Circuit is actually increasing an
internal reference count.  We should name the functions to reflect
that, to be more explicit about what we're doing.
2020-10-29 12:11:36 -04:00
Nick Mathewson 06675c180c update the TODO 2020-10-27 14:58:34 -04:00
Nick Mathewson 5989b843cc Add a simple test for stream creation. 2020-10-27 14:40:23 -04:00
Nick Mathewson 705d9c061f Add a test for extending a circuit with ntor. 2020-10-27 14:26:22 -04:00
Nick Mathewson 911185ec38 circuit: test meta-cell receiving 2020-10-27 13:41:31 -04:00
Nick Mathewson b90ca2acd7 Downgrade an XXXXM3 message. 2020-10-27 13:11:57 -04:00
Nick Mathewson f8e1e6976f Unify interface for detecting stream close. 2020-10-27 13:09:17 -04:00
Nick Mathewson 4cded7a05a Add a test for sending a cell. 2020-10-27 13:03:39 -04:00
Nick Mathewson 8f5d239c21 Expand test to handle building circuit with ntor. 2020-10-27 12:23:18 -04:00
Nick Mathewson 483425ba4b Make a test for create_firsthop_fast. WOW that was hard. 2020-10-27 11:55:24 -04:00
Nick Mathewson dcf0936396 Make circuit reactors also have a run_once() method for testing. 2020-10-27 11:54:11 -04:00
Nick Mathewson 5bd85e57ec Add a fake, reactorless channel, for use in testing circuits 2020-10-27 10:16:05 -04:00
Nick Mathewson e2f7fe3827 Remove use of Cell<> in tor_proto.
I was confused about what this was for, I guess.
2020-10-27 10:14:28 -04:00
Nick Mathewson 94042b60b8 Rename CircIDRange to CircIdRange 2020-10-27 09:51:28 -04:00
Nick Mathewson ee9ad7f59d Run "cargo upgrade". 2020-10-26 14:56:06 -04:00
Nick Mathewson b93e4b76c8 Remove a bunch of dbg! calls. 2020-10-26 14:33:14 -04:00
Nick Mathewson a796f7bf6a Use event_listener to find out about sendme replenishment.
Previously we would fail if a sendme window was exhausted and two
tasks were waiting for it to be replenished at the same time.
2020-10-26 14:25:46 -04:00
Nick Mathewson 4348faff3c Resolve a bunch of XXXM3 comments in tor-proto. 2020-10-26 14:03:25 -04:00
Nick Mathewson 4d9c08669e Improve documentation in tor-proto 2020-10-26 13:08:46 -04:00
Nick Mathewson d3b71bc177 More documentation in tor-netdoc. 2020-10-26 11:51:53 -04:00
Nick Mathewson 94231230b0 Improve documentation in tor-cell 2020-10-26 11:51:11 -04:00
Nick Mathewson db94abadcc rudimentary test for channelbuilder. 2020-10-26 09:29:59 -04:00
Nick Mathewson 1b86818085 Tests for sending bad/good cell types on a channel 2020-10-26 09:23:42 -04:00
Nick Mathewson 498bc3633d Clean up some XXXXs in channel::reactor.rs 2020-10-26 09:23:10 -04:00
Nick Mathewson 6d6cff5176 Tests for receving incoming DESTROY cell. 2020-10-26 09:06:52 -04:00
Nick Mathewson 937d924b0a channel::reactor: Tests for handling incoming RELAY cells 2020-10-26 09:06:52 -04:00
Nick Mathewson 46c991a087 Test for rejecting CREATED cells 2020-10-26 09:06:52 -04:00
Nick Mathewson 494c4679b5 Add a CircEnt::DestroySent circuit state.
A circuit enters DestroySent after it's sent a DESTROY cell. We use
this state to make sure that we don't receive too many cells on a
destroyed circuit, _and_ so that we don't block such cells
completely.
2020-10-26 09:06:52 -04:00
Nick Mathewson 32b025de1d Use better return type in advance_from_opening 2020-10-25 23:37:25 -04:00
Nick Mathewson 8c09981427 Use from_bytes name for Ed25519Identity 2020-10-25 20:32:47 -04:00
Nick Mathewson fa01a50f32 Rename CircID and StreamID to end with Id instead, for consistency 2020-10-25 20:29:01 -04:00
Nick Mathewson fbf200ae6f Add some tests for channel reactor and related code. 2020-10-25 15:09:06 -04:00
Nick Mathewson 0e91d97f76 Add a test for running and shutting down reactors.
This took a long time since I needed to learn about futures and
executors, but I think it'll work out okay.
2020-10-25 14:12:51 -04:00
Nick Mathewson e20bfaab0f channel: Refactor the point when we split the framed codec.
We used to do this during creating the channel in Channel::new, but
now we do it one step before, so that it's easier to construct
channels for testing.
2020-10-25 12:42:53 -04:00
Nick Mathewson 510a27f2d3 channel: Move looping part of run_impl() into run().
This lets us turn run-impl() into a run_once() function for easier
testing.
2020-10-25 12:06:36 -04:00
Nick Mathewson d1e5d54c24 Move cell logging into ChannelImpl 2020-10-23 10:19:56 -04:00
Nick Mathewson e1b741f0fc circuit: Remove the needlessly separated ReactorCore type. 2020-10-23 09:49:33 -04:00
Nick Mathewson 913db08384 channel: Remove the needlessly separated ReactorCore type. 2020-10-23 09:47:40 -04:00
Nick Mathewson 9ef63a01e3 Test for finish-handshake function 2020-10-23 09:04:10 -04:00
Nick Mathewson b80b0b7019 handshake: tests for invalid signatures 2020-10-23 08:52:21 -04:00
Nick Mathewson 9b46f04f58 Add tests for handshakes certifying the wrong thing 2020-10-23 08:45:40 -04:00
Nick Mathewson 04f22a122e Tests for handshakes with missing certs
Also handle tor_cell::Error::ChanProto better.
2020-10-23 08:34:35 -04:00
Nick Mathewson f13c759f0f Use an enum for the return value of StreamMap::terminate 2020-10-22 13:42:45 -04:00
Nick Mathewson 2de91b1c16 Initial tests for tor_proto::circuit::streammap 2020-10-22 13:35:18 -04:00
Nick Mathewson b5f019ccf1 Tests for tor_proto::circuit::halfstream 2020-10-22 12:36:39 -04:00
Nick Mathewson 60e7d3f3c1 tor-proto: Add tests for circuit::sendme 2020-10-22 12:07:28 -04:00
Nick Mathewson 19c48a2de5 Add tests for tor_proto::circuit::celltypes 2020-10-21 17:59:58 -04:00
Nick Mathewson 9d1c279f65 Test a trivial succeeding case of link cert validation 2020-10-21 15:40:58 -04:00
Nick Mathewson 11cd138c74 Fix a security issue (!) in link handshake validation.
When making sure that the peer had the right RSA identity, we
were comparing the RSA identity with itself, not with the RSA
identity we expected.

Found via unit testing (!).
2020-10-21 15:37:55 -04:00
Nick Mathewson 29464c4559 Fix comments in tor-cert. 2020-10-21 15:37:05 -04:00