vincenzopalazzo
/
arti
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
6,196 Commits 3 Branches 23 Tags 19 MiB
Commit Graph

6196 Commits

Author SHA1 Message Date
gabi-250 c7f924ff35 tor-netdir: Expand on comment for HsRingRings::iter 2023-03-30 16:02:27 +00:00
Alexander Færøy c8a8aeae50 Merge branch 'send' into 'main' 
tor-circmgr: Make take_or_launch_stub_circuit future Send

See merge request tpo/core/arti!1096
 2023-03-30 15:58:32 +00:00
gabi-250 2cd36a4c44 Merge branch 'ring' into 'main' 
tor-netdir: Implement `HsDirRing::find_pos`

See merge request tpo/core/arti!1095
 2023-03-30 15:37:42 +00:00
gabi-250 e7e305f9cd tor-netdir: Minor docs fixes 2023-03-30 15:37:07 +00:00
Ian Jackson ab7e628555 CONTRIBUTING.md: Explicitly support --document-private-items 
We have many internal doc comments with curated links etc., so we
should actually mention that formatting and reading those can be
useful.
 2023-03-30 16:34:57 +01:00
Ian Jackson 922df2a10f CONTRIBUTING.md: Recommend --workspace when building docs 2023-03-30 16:34:53 +01:00
Ian Jackson 3746ad8c84 CONTRIBUTING.md: Add some refs for git autosquash 
One ref to the official docs, one to a reasonable-looking blog post I
found via DDG.

Suggested in
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1079#note_2889631
 2023-03-30 16:32:04 +01:00
Ian Jackson f7f3ad37ff CONTRIBUTING.md: Discourage contributors from rebasing (typo fix) 2023-03-30 16:32:00 +01:00
Nick Mathewson b62c46f0b5 CONTRIBUTING.md: Improve wording re not squashing 2023-03-30 16:31:36 +01:00
Ian Jackson 8882df7c51 CONTRIBUTING.md: Document X X X convention 
The placement in the "Where are some good places to start hacking?"
section is rather awkward, but I didn't see where else to put it.
 2023-03-30 16:31:36 +01:00
Ian Jackson ee9486f52d CONTRIBUTING.md: Add more notes about TODOs 
The placement in the "Where are some good places to start hacking?"
section is rather awkward, but I didn't see where else to put it.
 2023-03-30 16:31:36 +01:00
Ian Jackson a55ed63c6c CONTRIBUTING.md: Discourage contributors from rebasing 2023-03-30 16:31:36 +01:00
Ian Jackson 23c7bd9174 Run rustfmt 
Apply this churn, which I deferred for ease of review.
 2023-03-30 15:58:47 +01:00
Ian Jackson a14d18d295 arti-client: Call HsCircPool::launch_background_tasks 
I found that I had the bug where I forgot to call this function, and
reached
   bad_api_usage!("The circuit launcher wasn't initialized")

The possibility of such a bug is a hazard of this API pattern.
 2023-03-30 15:58:09 +01:00
Ian Jackson 577940853f tor-netdir: Implmeent HsDirRing::find_pos 2023-03-30 15:53:51 +01:00
Ian Jackson 3ed9dca842 tor-hsconn: Rename ConnError (from HsClientConnError) 
The old name was unwieldy and other crates can just as well name it by
the crate scope.
 2023-03-30 15:49:07 +01:00
Ian Jackson 255b9cac96 arti-client: When making hs conn, wait for bootstrap 
Not doing this was a bug.  The bug was possible because of some code
duplication between the exit and hs paths.  Add a comment about that.
 2023-03-30 15:49:07 +01:00
Ian Jackson 926abf3ade tor-client: Pass a netdir for each request 
This will be more convenient inside tor-hsclient.  In arti-client,
this mirrors the way TorClient::get_or_launch_exit_circ works.
 2023-03-30 15:49:07 +01:00
Ian Jackson 9b831933ef tor-netdir: Provide accessor for params field of HsDirParams 2023-03-30 15:47:06 +01:00
Ian Jackson 544d0e6d18 tor-netdir: Implement hs_dirs accessor 2023-03-30 15:47:06 +01:00
Ian Jackson 3c39c2f544 tor-netdir: hs_dirs accessor: change semantics, type, and name 
Don't have it take the TP, so that the caller must call it multiple
times.  Instead, have it return all the relevant relays.
 2023-03-30 15:47:06 +01:00
Ian Jackson e15f3c5348 tor-netdir: Provide hs_all_time_periods instead of ..._secondary_... 
I don't think the server-side support will want to explicitly call
current and then secondary.  Rather, it will want to iterate over all
the relevant ones.

And fix the name, and add another comment about whether we need this.
 2023-03-30 15:47:06 +01:00
Ian Jackson 4cf3cd00ef tor-netdir: Rename hs_time_period 
Change its name to hs_* like we do with things at this layer.

But, it turns out, that at least for hs client connections to fetch
the descriptor, I don't seem to need to call it yet ?  Maybe it's not
needed.
 2023-03-30 15:47:06 +01:00
Ian Jackson db028a6d34 tor-netdir: Sort out HsDirOp 
* Change its name to Hs* like we do with things at this layer
* Make the Upload variant cfg-conditional
 2023-03-30 15:47:06 +01:00
Ian Jackson 4d3d79a511 tor-netdir: Reorganise iteration over hsdir rings 
Provide iter_for_op, by changing iter into iter_filter_secondary and
having a new entrypoint iter.
 2023-03-30 15:47:06 +01:00
Ian Jackson 7924e995f1 tor-netdir: Provide relay_by_rs_idx 2023-03-30 15:47:06 +01:00
Ian Jackson dd493307f9 tor-circmgr: Make take_or_launch_stub_circuit future Send 
thread_rng() isn't Send.  We can fix this by not holding it over an
await point.
 2023-03-30 15:46:15 +01:00
Ian Jackson db968033cf tor-netdir: Make the hsdir ring be a TiVec 
This eliminates an untyped `usize` index.
 2023-03-30 15:43:48 +01:00
gabi-250 2ec38b4cdf Merge branch 'upgrades-20220330' into 'main' 
Upgrade some dependencies in preparation for tomorrow's release

See merge request tpo/core/arti!1093
 2023-03-30 13:24:46 +00:00
Nick Mathewson 26ee1feeb1 Upgrade dependency to latest rusqlite. 2023-03-30 08:33:44 -04:00
Nick Mathewson 289c30c5f0 Upgrade dependency to latest async-native-tls. 2023-03-30 08:32:18 -04:00
Nick Mathewson c6cbc2f4d6 Initial changelog draft for 1.1.3 2023-03-30 08:30:15 -04:00
Nick Mathewson 58dfe040f9 Merge branch 'async-utils' into 'main' 
Move functionality from tor_basic_utils to tor_async_utils

See merge request tpo/core/arti!1091
 2023-03-29 18:28:50 +00:00
Nick Mathewson a62affd66e Move functionality from tor_basic_utils to tor_async_utils 
This commit is mostly code movement; I'd recommend reviewing it
with git's `--color-moved` option.
 2023-03-29 13:57:11 -04:00
Nick Mathewson 1ee4a98a27 Make a new empty tor-async-utils crate. 2023-03-29 09:02:20 -04:00
Ian Jackson 13edaf68de Merge branch 'blind' into 'main' 
key blinding: Use consistent terminology

See merge request tpo/core/arti!1085
 2023-03-29 09:44:50 +00:00
Ian Jackson edb3ac26f3 Merge branch 'hspre' into 'main' 
Miscellanious tidying up (pursuant to HS client work)

See merge request tpo/core/arti!1086
 2023-03-29 09:44:48 +00:00
Ian Jackson 7aab916f31 Merge branch 'fix-blockage-accessors' into 'main' 
arti-client: add accessors for `Blockage`

Closes #800

See merge request tpo/core/arti!1088
 2023-03-29 09:42:19 +00:00
eta a6fe3803a0 arti-client: add accessors for `Blockage` 
Fixes #800.
 2023-03-28 19:27:04 +01:00
Ian Jackson b982ee678d Tidy up an unused import warning 
Now
  cargo +stable clippy --locked --offline --workspace --all-targets
is clean.
 2023-03-28 15:49:45 +01:00
Ian Jackson 5ff24c9f84 Pass HS identity to hsclient connection function 
Obviously it will need this!
 2023-03-28 15:49:45 +01:00
Ian Jackson df8e4dd497 Pass HsCircPool to hsclient connect function, not CircMgr (fmt) 2023-03-28 15:49:45 +01:00
Ian Jackson 9b6be7eaa7 Pass HsCircPool to hsclient connect function, not CircMgr 
We separated this out in the circmgr API.  This is what the HS client
needs.  It doesn't want to participate in the general circuit pool.
 2023-03-28 15:49:45 +01:00
Ian Jackson 00e522a91a Add some missing imports 
Now
  nailing-cargo +stable clippy -p tor-hsclient --all-features --all-targets
actually works.

squash! Add some missing imports
 2023-03-28 15:49:45 +01:00
Ian Jackson 4c2a9332db tor-hscrypto: key blinding: Use consistent terminology 
* Don't ever use the words "parameter" or "param".
  These doesn't appear in the spec anywhere.

* Use `h` as the variable name for the unclamped blinding factor,
  and `blinding_factor` in function names.
 2023-03-28 12:47:14 +01:00
Ian Jackson def291dcb5 tor-llcrypto: key blinding: Use consistent terminology 
Unhelpfully, the spec uses the variable name `h` and the phrase
"blinding factor" for both the unclamped and clamped value.  The
clamped value is internal to the algorithm.

In our code:

* Don't ever use the word "parameter" or variable name `param`.
  This doesn't appear in the spec anywhere.

* Use `h` for the unclamped blinding factor, and `blinding_factor` for the
  clamped blinding factor.

* Rename `blinding_factor` function to `clamp_blinding_factor`, since
  in the spec's terminology it takes an (unclamped) "blinding factor"
  and returns a (clamped) "blinding factor".

* State explicitly what thing in the spec the `h` parameters are.
 2023-03-28 12:47:12 +01:00
Nick Mathewson d952467870 Merge branch 'hsdesc-encoder-generic-rng' into 'main' 
Make the HS encoder randomness source injectable.

See merge request tpo/core/arti!1084
 2023-03-27 22:54:09 +00:00
Gabriela Moldovan ef72e927ac
Remove hard-coded test certs. 
We can use a deterministic rng to generate predictable keypairs instead.

Signed-off-by: Gabriela Moldovan <gabi@torproject.org>
 2023-03-27 19:44:49 +01:00
Gabriela Moldovan 70d247e59c
Make the HS encoder randomness source injectable. 
This makes it possible to plug in a deterministic randomness source for
testing.

Signed-off-by: Gabriela Moldovan <gabi@torproject.org>
 2023-03-27 19:07:41 +01:00
gabi-250 a282e1f300 Merge branch 'idx' into 'main' 
tor-netdir: Try to abolish unqualified uses of idx

See merge request tpo/core/arti!1083
 2023-03-27 17:38:31 +00:00