a79a2e87be
Rename TorClient::set_stream_prefs
...
In line with the rest of the renaming.
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/256#note_2771617
2022-01-21 17:12:08 +00:00
87326afe75
Error plan: typos/fixes
2022-01-21 17:00:49 +00:00
c3f82ee14d
README,CONTRIBUTING: More links.
...
Explain how to report bugs and how get accounts on the bugtracker;
add link to the troubleshooting document.
Part of #277
2022-01-21 10:59:14 -05:00
33e70eec3d
TROUBLESHOOTING.md: More information+links about build process.
...
Part of #277
2022-01-21 10:59:14 -05:00
dcf26466f3
StreamPrefs: Re-alphabetise imports following rename
...
Placates rustfmt
2022-01-21 11:07:21 +00:00
aa4d8de16e
StreamPrefs: rename from ConnectPrefs
...
The docs even say this is about stream.
As @nickm writes in
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/252#note_2771289
we generally call end-to-end connections that are tunneled over Tor
"Streams" to distinguish them from everything else in the Tor
protocols that could possibly be called a "Connection".
That seems to apply here too.
2022-01-21 11:07:15 +00:00
695a33c1fd
Merge branch 'always-isolate' into 'main'
...
Provide isolate-all-streams function
Closes #279
See merge request tpo/core/arti!252
2022-01-20 19:08:05 +00:00
f0f296450a
Errors: fold in people's views so is mostly unattributed now
2022-01-20 18:28:06 +00:00
e762679a06
Errors: sort out markdown formatting
2022-01-20 18:27:52 +00:00
446d72329b
Errors: c&p raw text of consensus conclusions from pad to git
2022-01-20 18:27:31 +00:00
c41216ce70
Merge branch 'docs-build' into 'main'
...
CONTRIBUTING: Document how to build the docs
See merge request tpo/core/arti!255
2022-01-20 18:10:24 +00:00
7bc8941742
isolation: Rename isolate_every_stream from ..._connection
...
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/252#note_2771291
2022-01-20 17:53:09 +00:00
23c1fc8c56
isolation: Rename (internal) EveryStream enum variant
...
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/252#note_2771289
2022-01-20 17:53:09 +00:00
06c15f21b4
isolation: Much better wording for always isolate setting
2022-01-20 17:52:10 +00:00
1250fc68ce
CONTRIBUTING: Document how to build the docs
...
Eventually we may need a separate HACKING.md
2022-01-20 17:36:37 +00:00
85ed27f621
CONFIG-NOTES: finish a sentence
2022-01-20 17:28:23 +00:00
6ba3686a59
CONFIG-NOTES: Suggestions from MR review
2022-01-20 17:02:35 +00:00
b2582b29c2
Merge branch 'pathconfig_fixing' into 'main'
...
Refactor, fix, test PathConfig type
See merge request tpo/core/arti!254
2022-01-20 15:16:51 +00:00
a58e4e3688
Test for PathConfig::at_least_as_permissive_as().
...
This is totally not just an exercise to get combined test coverage
for tor-circmgr over 90% because I needed something to do that
wouldn't distract anybody else. :)
2022-01-20 09:57:19 -05:00
a5288aa15f
Rename PathConfig::more_permissive_than()
...
Since it implements a "<=" type relationship, it should be called
"at_least_as_permissive_as()." Since it's a crate-private function,
the long name isn't too bad.
2022-01-20 09:55:54 -05:00
b0ea74aa60
Remove "self" arg from PathConfig::builder()
...
This was added by mistake.
2022-01-20 09:53:12 -05:00
a57b4962b3
Merge branch 'stuff-prefs' into 'main'
...
Provide TorClient::set_default_prefs and clone_with_prefs
Closes #290
See merge request tpo/core/arti!250
2022-01-20 14:36:41 +00:00
6e94d5fd7b
Merge branch 'coverage_toolchain' into 'main'
...
with_coverage: Allow toolchain selection.
See merge request tpo/core/arti!253
2022-01-20 14:31:55 +00:00
ef5dc3cb3e
with_coverage: Allow toolchain selection.
...
There's some kind of bug in nightly that (for me) keeps grcov from
generating correct results. Instead, it misses some crates entirely.
No trouble, though: I can just use an older nightly until they get
this issue fixed!
This patch makes using a different version of nightly possible with
a new RUST_COVERAGE_TOOLCHAIN environment variable.
2022-01-20 09:01:36 -05:00
e55f8f8dad
Merge branch 'msrv' into 'main'
...
Adopt an initial MSRV policy.
Closes #283
See merge request tpo/core/arti!247
2022-01-20 13:59:37 +00:00
ced24b1974
connection preferences: Make `set_default_prefs` private for now
2022-01-20 13:52:30 +00:00
e04e41a1db
connection preferences: Make `clone_with_prefs` must_use
...
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/250#note_2771239
2022-01-20 13:50:12 +00:00
9e904167e4
isolation: Provide isolate-every-connection option
2022-01-20 12:08:22 +00:00
a5356aed65
isolation: Provide new_isolation_group method
...
In the usual case, set_isolation_group is awkward.
This is perhaps slightly duplicative with TorClient::isolated_client().
If so then perhaps the *latter* should be abolished.
2022-01-20 12:08:22 +00:00
639db26d58
isolation: Refactor to introduce a bespoke enum
...
No functional change.
This will grow a new variant shortly.
2022-01-20 12:08:22 +00:00
17920e43f8
Refactor Runtimes to use separate TLS implementations internally.
...
This will make it easier to implement them using some other TLS
provider as well, without having to duplicate all of our code.
2022-01-19 15:47:26 -05:00
8d3e4576da
Add a macro to help with opaque Runtime wrappers.
...
We're soon going to have our different Runtime types be built as
CompoundRuntime instances. We don't want to expose that detail,
though, so we'll use this macro to make them implement the right
traits.
2022-01-19 15:47:26 -05:00
dd72607601
Add a CompoundRuntime type for runtime construction.
...
This type can solve two problems at once.
First, it lets users replace parts of an existing runtime
implementation without replacing the whole thing. For example, you
can use it to override your TcpProvider implementation to solve
problems like #235 .
Second, we can use it internally to tor-rtcompat to define Runtimes
piece-by-piece. Mostly we'll use this to separate our Tls
implementations from our implementations of the rest of the Runtime.
2022-01-19 15:47:26 -05:00
9a77b23cdd
clippy: Rename a `decode_chanmsg` from `handle_`
...
As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/249#note_2771025
It doens't really handle it.
2022-01-19 18:46:13 +00:00
6c5e099be9
handshake: Use read_exact, not read and checking len
...
read_exact has a loop in it, which we need.
This means we end up separating the two sites that generate the "not a
relay" error, so we need to fish out the error construction.
As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/249#note_2771023
2022-01-19 18:45:53 +00:00
7ff16fc252
connection preferences: Provide `clone_with_prefs` method
2022-01-19 17:45:59 +00:00
4ddbb3daeb
connection preferences: Provide `set_connect_prefs` method
2022-01-19 17:45:59 +00:00
dec0e1e756
connection preferences: Take ConnectPrefs by reference
...
This may save quite a bit of copying. The callees don't need to copy
the whole struct; they copy the bits they need.
2022-01-19 17:42:43 +00:00
1437f953b6
connection preferences: Rename variable and docs to not say "flags"
...
These aren't flags. Eg, there's an isolation token in there.
2022-01-19 17:39:29 +00:00
e84ff24d11
isolation: Document orthogonality of isolated_client and isolation_group
2022-01-19 17:39:29 +00:00
c433899948
clippy: Rename a `from_foo` method that doesn't do conversion
2022-01-19 17:26:09 +00:00
1d5a480f79
Fix two bugs related to incomplete read/write
...
Discovered by clippy
2022-01-19 17:17:56 +00:00
5e16a52e1c
clippy: Suppress a warning
2022-01-19 17:12:26 +00:00
ebda5a0aca
doc/CONFIG-NOTES.md: config proposal
2022-01-19 15:04:20 +00:00
4a5daaf779
Adopt an initial MSRV policy.
...
Closes #283 .
2022-01-19 09:02:39 -05:00
db2ca6ebc4
Merge branch 'bootstrap_reporting'
2022-01-19 08:40:36 -05:00
ca35873654
Merge branch 'eta/292-2' into 'main'
...
arti-bench: add concurrency, write benchmark results out to JSON
See merge request tpo/core/arti!243
2022-01-19 13:28:23 +00:00
d1c362f308
bootstrap reporting: Documentation fixups from review.
2022-01-19 08:22:42 -05:00
24ec0bbb76
maint/changed_crates.sh: Add a missing space.
...
found by shellcheck.
2022-01-19 08:11:12 -05:00
8e0a035c33
Merge branch 'coverage_script'
2022-01-19 08:09:47 -05:00
Ian Jackson
eta
Nick Mathewson
Ian Jackson