Commit Graph

5610 Commits

Author SHA1 Message Date
Nick Mathewson 8ee04ac203 Merge branch 'logs' into 'main'
Report causes of errors

Closes #680

See merge request tpo/core/arti!997
2023-02-01 18:19:33 +00:00
Nick Mathewson 04628ca5ab Remove semver.md files now that 1.1.1 is tagged. 2023-02-01 12:46:01 -05:00
Nick Mathewson db7183a64e Merge branch 'version_bump' into 'main'
Bump crate versions in preparation for 1.1.1.

See merge request tpo/core/arti!1001
2023-02-01 16:30:28 +00:00
Nick Mathewson a2b1f20216 Bump minor version of tor-cell.
In !948 we renamed a couple of accessor functions, which is a
breaking change in `tor-cell`'s API.

In retrospect, perhaps we should have deprecated the old names and
added the new ones, so we wouldn't have to break the API.  (This is
the only API break AFAICT since 1.1.0.)
2023-02-01 10:42:58 -05:00
Nick Mathewson 7c1b6a5a81 Bump the patch version of every crate that had API additions
These crates had API or behavior changes that may affect downstream
crates. Fortunately, they're all version 0.x, and don't need minor
bumps for this.
2023-02-01 10:36:29 -05:00
Nick Mathewson 66f594a4b6 Bump the patch-level version of crates with _minor_ changes.
These changes influence behavior, but not effect compatibility.
(If I messed up, and any crate except for `arti` has non-breaking
API changes, that's still fine, since they are all version
0.x.)
2023-02-01 10:23:58 -05:00
Nick Mathewson 592d6bf8a3 Bump the patch version of each crate with _trivial_ changes.
These crates have not had changes to their behavior; as such it is
not necessary to bump their dependencies to require the new versions.
2023-02-01 10:10:36 -05:00
Nick Mathewson c42350c6bf Move tor-proto/semver.md to tor-cell
It was erroneously created in the wrong place.
2023-02-01 09:50:02 -05:00
Nick Mathewson e172a0c893 Mark arti-config as "publish=false"
We no longer use it anywhere; there is no reason to keep publishing
updates to it.
2023-02-01 09:48:09 -05:00
Nick Mathewson be5b6195b1 CHANGELOG for arti 1.1.1 2023-02-01 09:03:57 -05:00
Nick Mathewson 59e812bdbe Merge branch 'update' into 'main'
Run cargo update in preparation for release tomorrow

See merge request tpo/core/arti!1000
2023-01-31 21:02:04 +00:00
Nick Mathewson 970cc6cb29 Run cargo update in preparation for release tomorrow 2023-01-31 15:37:48 -05:00
Ian Jackson b65ebb5d38 tor-netdoc: Suppress a cfg-dependent dead code warning
This is dead code when
  cargo +stable clippy -p tor-netdir --all-features --all-targets
2023-01-31 16:17:54 +00:00
Ian Jackson 37edcd688a Use ErrorReport - run rustfmt
Split off for ease of review and possible rebase.
2023-01-30 18:52:32 +00:00
Ian Jackson e159bf57d2 Use ErrorReport for errors in error! in tor-ptmgr 2023-01-30 18:52:32 +00:00
Ian Jackson aa7397bc0f Use ErrorReport's .report() for two errors in error! in bridgedesc.rs
No functional change, just using the new idiom.
2023-01-30 18:52:32 +00:00
Ian Jackson 3a8c36e9c6 Use ErrorReport for remaining errors in error! in tor-circmgr 2023-01-30 18:52:32 +00:00
Ian Jackson 8c1830090c Use ErrorReport for errors in error! in tor-chanmgr 2023-01-30 18:52:32 +00:00
Ian Jackson 22016f233b Use tor_error::Report for remaining errors in error! in arti 2023-01-30 18:52:32 +00:00
Ian Jackson 49f3697b19 Apply safelog to DNS response serialisation errors, but report them
With safe logging disabled, print the error too.

With safe logging enabled, do not print the message or the error.
2023-01-30 18:52:32 +00:00
Ian Jackson 5c0a7e0127 Use ErrorReport for errors in error! in arti-client 2023-01-30 18:52:32 +00:00
Ian Jackson 2954568fae Use ErrorReport for errors in warn! in tor-ptmgr 2023-01-30 18:52:32 +00:00
Ian Jackson 47e226293f Use ErrorReport for errors in warn! in tor-persist 2023-01-30 18:52:32 +00:00
Ian Jackson dc9352b515 Use ErrorReport for errors in warn! in tor-dirmgr 2023-01-30 18:52:32 +00:00
Ian Jackson 25c41977ac Use ErrorReport for errors in warn! in tor-circmgr 2023-01-30 18:52:32 +00:00
Ian Jackson 410fdc9f32 Use ErrorReport for errors in warn! in tor-chanmgr 2023-01-30 18:52:32 +00:00
Ian Jackson 36ebf7d23a Use ErrorReport/Report for errors in warn! in arti 2023-01-30 18:52:32 +00:00
Ian Jackson cc6cf7f973 Use ErrorReport for errors in info! in tor-dirmgr 2023-01-30 18:04:57 +00:00
Ian Jackson 0e6be61db6 tor-dirclient: De-genericise internal fn retire_circ
Requring `Display` is wrong here, because if this is actually an
Error, Display would be wrong because it doesn't display causes.

As it happens, the `error` parameter is only ever `&str`.
2023-01-30 18:00:53 +00:00
Ian Jackson f657ef5b6c Use ErrorReport for errors in info! in tor-circmgr 2023-01-30 17:59:09 +00:00
Ian Jackson c2e4b8b7f9 Errors: Mark the type of an error, for clarity
We want to call ErrorReport::report() on Errors, but this isn't an
Error but only a string.
2023-01-30 17:52:02 +00:00
Ian Jackson 705638df22 Merge branch 'docsrs' into 'main'
Disable ./maint/check_doc_features

Closes #601

See merge request tpo/core/arti!985
2023-01-30 17:17:41 +00:00
Ian Jackson 24d00c4e8f Maine ./maint/check_doc_feature a warning
This is a fair amount of manual work to keep in sync.  I would like to
disable this, at least as a mandatory check, for now.

Fixes #601 (the request for it to become non-blocking).
The underlying issue is #581 and remains open.

Co-authored-by: trinity-1686a <trinity@deuxfleurs.fr>
2023-01-30 16:49:54 +00:00
Nick Mathewson 2afbea6a74 Merge branch 'srv_accessors' into 'main'
Export SRV information from NetDoc up to NetDir, and TimePeriod from NetDir

Closes #686

See merge request tpo/core/arti!987
2023-01-28 18:11:29 +00:00
Nick Mathewson f6cbd180a1 netdir: remove duplicate code in param calculation 2023-01-28 12:43:08 -05:00
Nick Mathewson 4e7a552171 netdir: remove the vestigial smallvec implementation I added
It's cute, but I don't think it will help performance, and I'm
undecided about whether the semantic implications are true.
2023-01-28 12:43:08 -05:00
Nick Mathewson 268a723e49 Turn compute_ring_params into a method. 2023-01-28 12:43:08 -05:00
Nick Mathewson 2490b3cdc6 Use derive_more on SharedRandVal
This may be temporary if we wind up converting to CtByteArray,
but for now it's good to be terse.
2023-01-28 12:43:08 -05:00
Ian Jackson a51c76178e Several suggestions on gitlab. 2023-01-28 12:43:08 -05:00
Nick Mathewson 5236c5cf88 netdir: Implement ring-param constructors and time period accessors
This logic is a bit tricky, so I've tried to document it and add
fairly good tests.  The silver lining is that the external API for
all of this logic will make it invisible and hidden.

There are some cases where I added functions that I think might
eventually get lowered into MdConsensus: But I don't want to lower
too much right now, since the convention for our netdoc accessors is
that they are fairly unsophisticated, and they show you the document
as it is.

Closes #686
2023-01-28 12:43:08 -05:00
Nick Mathewson 9f3e6783ca netdoc: Add Eq and a note to SharedRandVal. 2023-01-28 12:12:17 -05:00
Nick Mathewson 790b38eec8 netdoc: Add SRV accessors.
These are deliberately unsophisticated accessors, in that they return Option<>
rather than filling in missing values with the documented
fallbacks. It seems better to leave a way to distinguish the absent
case in the API.
2023-01-28 12:12:17 -05:00
Nick Mathewson c1ced84239 netdoc: Add a timestamp to SRVs per prop#342.
This breaks some experimental APIs, but since they are experimental
no semver note is needed.
2023-01-28 12:12:17 -05:00
Nick Mathewson 8ce447b7e2 netdoc: Add Iso8601 time _with_ a "T" as an argument type. 2023-01-28 12:12:17 -05:00
Nick Mathewson 4aaace640b Merge branch 'typos' into 'main'
Fix typos

See merge request tpo/core/arti!996
2023-01-28 00:18:09 +00:00
Dimitris Apostolou 3da36c5c8b
Fix typos 2023-01-28 01:31:10 +02:00
Nick Mathewson 856d3b0a8b ErrorHint: Report hints for arti_client errors. 2023-01-27 11:56:53 -05:00
Nick Mathewson b3c963e7fa ErrorHint: Add a note about lowering the permissions hint 2023-01-27 11:56:53 -05:00
Nick Mathewson ae963e3c6b ErrorHint: use anonymize_home 2023-01-27 11:56:53 -05:00
Nick Mathewson 39ad97fdc2 ErrorHint: Implement tryfrom_torpersist 2023-01-27 11:56:53 -05:00