Commit Graph

5610 Commits

Author SHA1 Message Date
Ian Jackson 125a455bdc test lint blocks: Add many many automatically
This is precisely the result of running the rune in
maint/adhoc-add-lint-blocks.
2022-12-12 18:00:30 +00:00
Ian Jackson baf78361e8 test lint blocks: Do some semi-manually
This is the hunks from running the rune in maint/adhoc-add-lint-blocks
but which require some subsequent manual fixup: usually, deleting
now-superfluous outer allows, but in some cases manually putting back
lints that the adhoc script deleted.
2022-12-12 18:00:29 +00:00
Ian Jackson a8fda4b0cd test lint blocks: Add ad hoc script for adding them 2022-12-12 18:00:26 +00:00
Ian Jackson ec7720ae91 test lint blocks: Standardise one in tor-socksproto
The previous syntax was recognised by the real script, but not by the
ad-hoc script I'm about to use to add all the missing ones.
2022-12-12 17:50:39 +00:00
Ian Jackson 00f510905d Merge branch 'coral/#663' into 'main'
Tackling issue #663 (Use humantime in tests)

See merge request tpo/core/arti!931
2022-12-12 17:41:23 +00:00
coral 25f113b8b3 Tackling issue #663 (Use humantime in tests) 2022-12-12 17:41:22 +00:00
Ian Jackson 4181ccb8cc tor-circmgr: Use ErrorReport on a logged error
To demonstrate what the use looks like.
2022-12-12 16:40:51 +00:00
Ian Jackson b132536b32 tor-error: Provide ErrorReport extension trait with .report() method 2022-12-12 16:40:51 +00:00
Ian Jackson bd46e2ae84 tor_error: Promote internal StdError alias to report
The std::error::Error repetition was getting rather repetitively
repetitious, and is about to get more so.
2022-12-12 16:40:51 +00:00
Ian Jackson 8fea4dd6d3 tor-proto: reactor tests: Use debug fmt on an error
In tests, debug fmt is usually appropriate.

Found while looking for a candidate for
  https://gitlab.torproject.org/tpo/core/arti/-/issues/680
2022-12-12 16:40:51 +00:00
Ian Jackson 05ca80950e tor-linkspec: Fix an unused lint
Otherwise:

  cargo +stable clippy -p tor-proto --all-features --all-targets

Produces:

  warning: unused import: `PtTargetAddr`
   --> crates/tor-linkspec/src/traits.rs:9:28
    |
  9 | use crate::{ChannelMethod, PtTargetAddr, RelayIdRef, RelayIdType, RelayIdTypeIter};
    |                            ^^^^^^^^^^^^
2022-12-12 15:08:31 +00:00
Ian Jackson 81e23be67e Merge branch 'sensitive-into-inner' into 'main'
Rename Sensitive::into_inner() from ::unwrap()

See merge request tpo/core/arti!926
2022-12-12 12:20:37 +00:00
Ian Jackson 5611d5cb0c Rename Sensitive::into_inner() from ::unwrap()
By analogy with similar methods on Mutex, Cell, BufReader, etc. etc.

Discussed here
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/890#note_2856885

Make it a method, as per
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/928
2022-12-12 11:52:34 +00:00
Ian Jackson 879c4cdbf3 Merge branch 'shadow-bridge' into 'main'
Test vanilla bridge in shadow

See merge request tpo/core/arti!915
2022-12-12 11:41:05 +00:00
Nick Mathewson 77c23b8474 Add another step to the release process 2022-12-10 16:16:42 -05:00
Nick Mathewson f7bc808792 Merge branch 'typos' into 'main'
Fix typos

See merge request tpo/core/arti!932
2022-12-09 16:46:14 +00:00
Dimitris Apostolou 7c1beb6171
Fix typos 2022-12-09 11:57:36 +02:00
Nick Mathewson dc2c00e282 Merge branch 'doc-config-must' into 'main'
tor-config: Document how to reject compiled-out features

Closes #654

See merge request tpo/core/arti!929
2022-12-07 13:20:09 +00:00
Nick Mathewson 64ea12d4b9 Merge branch 'shewllexpand' into 'main'
tor-config: Update to shellexpand 3.x

See merge request tpo/core/arti!927
2022-12-07 13:19:39 +00:00
Ian Jackson 4e74104e70 Merge branch 'spelling-20221206' into 'main'
A few spelling fixes for bridgedescmgr code

See merge request tpo/core/arti!925
2022-12-06 18:25:43 +00:00
Ian Jackson d88e890583 Merge branch 'persist_err_test' into 'main'
Test a couple more error cases in tor-persist, and lightly refactor

See merge request tpo/core/arti!930
2022-12-06 16:38:28 +00:00
Ian Jackson fe5aeed41f Merge branch 'safelog_tests' into 'main'
More unit tests for safelog crate

See merge request tpo/core/arti!928
2022-12-06 16:17:44 +00:00
Ian Jackson 2321d0ba0b Merge branch 'faravahar-removal' into 'main'
dirauth: Remove Faravahar

See merge request tpo/core/arti!924
2022-12-06 16:02:22 +00:00
Nick Mathewson 764eecabab Test a couple more error cases in tor-persist. 2022-12-06 10:55:26 -05:00
Ian Jackson dc3c7651ca tor-config: Document how to reject compiled-out features
Fixes #654
2022-12-06 15:51:43 +00:00
Ian Jackson f3fa77be6f tor-config: Add "particular situations" sections and mention list_builder 2022-12-06 15:51:31 +00:00
Nick Mathewson 3ab548eb1c safelog: tests for accessors. 2022-12-06 10:31:40 -05:00
Nick Mathewson 417dda9547 safelog: tests for BoxSensitive. 2022-12-06 10:28:53 -05:00
Ian Jackson ba338bdf37 tor-config: Update to shellexpand 3.x
This is the new upstream version (published by me, recently).
It has the same MSRV and one breaking change:

The caller who specifies a home dir function for substituting into
strings, must now supply a string, not Path.  Previously shellexpand
would allow the caller to supply non-unicode data, and then simply not
substitute it.  That was an infelicity in the shellexpand API.

Now this infelicity is pushed into our code.  The overall behaviour of
Arti hasn't changed as a result.  And it seems reasonable to me.

shellexpand 3.x also has a module for expanding Paths instead, in
response to requests for this filed as upstream tickets.  We *could*
use that but I am not sanguine about that approach: the Pathness would
spread throughout much of our config and file handling code.

I think we should at the very least postpone trying to work with
invalid-unicode-paths as long as we can.
2022-12-06 15:15:22 +00:00
Ian Jackson 010ffd6ea6 tor-config: home dir handling: fmt pre-patch 2022-12-06 15:11:58 +00:00
Nick Mathewson 993b4202c7 safelog: more tests for Redacted. 2022-12-06 09:34:26 -05:00
Nick Mathewson ebf985f81b Merge branch 'moria1-new-key' into 'main'
dirauth: New v3 identity key for moria1

See merge request tpo/core/arti!922
2022-12-06 14:14:46 +00:00
Nick Mathewson f204eebf11 arti-client: spelling fix. 2022-12-06 09:08:26 -05:00
Nick Mathewson 02d340e4b2 dirmgr: Spelling fixes and normali[sz]ations 2022-12-06 09:02:48 -05:00
David Goulet 5ea8c8eed0 dirauth: Remove Faravahar
See https://gitlab.torproject.org/tpo/core/tor/-/issues/40688

Signed-off-by: David Goulet <dgoulet@torproject.org>
2022-12-06 09:01:34 -05:00
David Goulet 43aa24b231 dirauth: New v3 identity key for moria1
We are rotating moria1's key due to a break-in few weeks ago. See
https://gitlab.torproject.org/tpo/core/tor/-/issues/40722 for more
details.

The original MR for C-tor (tor.git) done by Roger Dingledine, moria1's
operator, is here:
https://gitlab.torproject.org/tpo/core/tor/-/merge_requests/662

Signed-off-by: David Goulet <dgoulet@torproject.org>
2022-12-06 08:42:09 -05:00
trinity-1686a 18a12d3feb put ci log span magic strings in a dedicated script 2022-12-05 18:41:23 +01:00
eta 16305a6415 Merge branch 'optional-deps-static' into 'main'
make use of 1.60 weak dependancy features

Closes #434

See merge request tpo/core/arti!920
2022-12-05 15:21:55 +00:00
eta aefd4c7180 Merge branch 'move-docs' into 'main'
Move developer-facing documentation into a doc/dev subdir

Closes #576

See merge request tpo/core/arti!921
2022-12-05 15:20:50 +00:00
Nick Mathewson 2c240923fc Move developer-facing documentation into a doc/dev subdir
Closes #576.
2022-12-05 08:58:39 -05:00
Nick Mathewson e0aeda3071 Remove semver.md files now that 1.1.0 is released. 2022-11-30 17:10:29 -05:00
Nick Mathewson 9d01c88c8c Update bridges.md a little 2022-11-30 16:21:50 -05:00
Nick Mathewson a2f148dc4e Add a quick "how to use bridges" explanation document. 2022-11-30 16:04:36 -05:00
Nick Mathewson 40941c6079 Merge branch 'version_bump' into 'main'
Bump the minor version of every crate.

See merge request tpo/core/arti!918
2022-11-30 20:54:15 +00:00
Nick Mathewson 3be600824e Merge branch '110-changelog' into 'main'
Minor changelog edits from Alex

See merge request tpo/core/arti!919
2022-11-30 20:45:26 +00:00
trinity-1686a 39fffd8d03 make use of 1.60 opt dependancy features 2022-11-30 21:24:04 +01:00
Nick Mathewson faee3933c6 Merge branch 'remember_pts' into 'main'
Hang onto a PT object after it is launched

See merge request tpo/core/arti!917
2022-11-30 20:17:07 +00:00
Alexander Færøy 247ca6fc2f Use anti-censorship instead of anticensorship everywhere in CHANGELOG. 2022-11-30 21:13:52 +01:00
Alexander Færøy 4d08ad71e3 Update changelog: supported -> Supported in MSRV line. 2022-11-30 21:12:02 +01:00
Nick Mathewson 38bef96b99 Bump the minor version of every crate.
We made this job easy this time around: by incrementing our MSRV, we
have forced ourselves to do at least a minor bump everywhere.
2022-11-30 15:10:16 -05:00