I think we do actually do this as part of the coverage job, but that's
not really very clear (and getting the report in that job may be
annoying).
We also do it on nightly as part of the nightly test, but that's an
"allow_fail".
These are available in our MSRV now, so we don't need to handle
specially. We can just add them to the standard lint block.
(Lint block in every crate will be updated automatically in the next
commit.)
This test is known to fail "when the load is high". Recently I had to
press the "merge unverified changes" button to merge !1238, after four
consecutivew spurious failures.
IMO this is intolerable.
This is a fair amount of manual work to keep in sync. I would like to
disable this, at least as a mandatory check, for now.
Fixes#601 (the request for it to become non-blocking).
The underlying issue is #581 and remains open.
Co-authored-by: trinity-1686a <trinity@deuxfleurs.fr>
This commit replaces all occurrences of `llvm-tools-preview` with
`llvm-tools`, because it became a stable feature with Rust 1.60, thereby
making the `-preview` prefix obsolete. Beside this, `llvm-tools-preview`
is a redirection to the latter one anyway.
However, it does not work the other way around. At the moment, it is not
possible to execute the `maint/coverage` script on a NixOS system,
because the rustup component list only includes `llvm-tools`, but not
`llvm-tools-preview`, thereby making this change necessary.
Now that they have merged
https://github.com/rust-lang/rust/pull/104416 ,
our CI should pass again with the regular nightly image.
Rather than remove the pinned image entirely, I'm commenting it out,
with a comment explaining how to pin an image the next time we need
to do so.
Closes#633.
tinystr 0.6.2 (which our Cargo.toml's permit and our Cargo.lock
specifies) has an MSRV of 1.60.
The symptom with earlier Rust is this from cargo:
error: failed to select a version for the requirement `tinystr = "^0.6.0"`
(which is, on the face of it, nonsense).
This will allow us to have add_warning manage test lint blocks.
We have to stop printing all the filenames because there are too
many. Filenames still come out on error of course.
Ian Jackson
Jim Newsome
Nick Mathewson
Emil Engler
trinity-1686a
trinity-1686a
Ian Jackson
Orhun Parmaksız
Alex Xu (Hello71)