Nick Mathewson
920f7a3f53
tor-chanmgr: don't log addresses so much.
...
We now log connection attempts at debug!, and mark relay target
addresses as sensitive.
2022-08-25 10:54:50 -04:00
Nick Mathewson
063c8fc545
Note tickets for TODO items.
...
Also remove controversial paragraph that is now maybe a bug.
2022-08-25 09:36:08 -04:00
eta
31e3649b3e
Apply 1 suggestion(s) to 1 file(s)
2022-08-25 13:12:33 +00:00
Nick Mathewson
8fa1568b02
arti: Raise the default console log severity to "info"
...
Previously we logged at "debug", but that's not meant to
user-facing.
2022-08-25 09:10:42 -04:00
Nick Mathewson
709543bb48
Merge branch 'setresuid' into 'main'
...
Fix setuid testing for MacOS
See merge request tpo/core/arti!691
2022-08-25 11:42:00 +00:00
Ian Jackson
504bba2191
Fix setuid testing for MacOS
2022-08-25 12:21:33 +01:00
Nick Mathewson
679c1c9b6a
Merge branch 'no_setuid' into 'main'
...
arti_client: Refuse to build a client if we are setuid.
See merge request tpo/core/arti!689
2022-08-24 19:47:15 +00:00
Nick Mathewson
a8b3e147fe
arti_client: Refuse to build a client if we are setuid.
...
Arti is not designed to be a setuid-safe program.
Part of #523 .
2022-08-24 15:23:24 -04:00
eta
072595773e
Merge branch 'doc-feature-flags' into 'main'
...
add annotations for required features in doc
Closes #541
See merge request tpo/core/arti!681
2022-08-24 17:39:24 +00:00
trinity-1686a
075ec7557f
fix nightly lints
2022-08-24 19:10:12 +02:00
trinity-1686a
c7d2b5001c
fix test failing due to missing allow_running_as_root
2022-08-24 18:34:02 +02:00
trinity-1686a
ef162655af
switch from awk to python
2022-08-24 18:22:41 +02:00
trinity-1686a
97bb2325df
add check_doc_features to CI
2022-08-24 18:22:41 +02:00
trinity-1686a
ca99e9f635
add feature annotation to fields made visible through visible::StructFields
2022-08-24 18:22:41 +02:00
trinity-1686a
426a59b2ba
add feature annotation not added by doc_auto_cfg
2022-08-24 18:22:41 +02:00
trinity-1686a
7f939fa480
enable doc_auto_cfg feature on every crate when documenting for docs.rs
2022-08-24 18:22:41 +02:00
Nick Mathewson
187c6b48df
Merge branch 'no_root' into 'main'
...
arti: Do not allow running as root.
See merge request tpo/core/arti!688
2022-08-24 15:21:57 +00:00
Nick Mathewson
8332e613f4
test/chutney/setup: Set allow_running_as_root as needed.
2022-08-24 10:57:03 -04:00
Nick Mathewson
25c287636b
arti: Do not allow running as root.
...
This can be overridden with `application.allow_running_as_root`.
Part of #523 .
2022-08-24 10:57:03 -04:00
Nick Mathewson
44e56d35aa
First draft of "what is sensitive" document
2022-08-23 15:31:26 -04:00
Nick Mathewson
51eb0e6ca2
Merge branch 'test-old-config' into 'main'
...
Test oldest example configuration file
See merge request tpo/core/arti!684
2022-08-23 14:43:30 +00:00
Nick Mathewson
9dbf504ffe
Merge branch 'resolve-option-general' into 'main'
...
tor-config: Provide resolve_option_general, for T: !Default etc.
See merge request tpo/core/arti!685
2022-08-23 14:43:18 +00:00
Nick Mathewson
96d21cf4da
Overview of issues with bridges in 1.1.0
2022-08-23 10:36:03 -04:00
Ian Jackson
ee2580face
tor-config: resolve_option_general: Add semver note
2022-08-23 14:21:13 +01:00
Ian Jackson
0c747b8069
tor-config: resolve_option_general: Add TODO about example
2022-08-23 14:20:49 +01:00
Nick Mathewson
32c14d37bf
Fix syntax in doc comment.
2022-08-23 12:59:41 +00:00
Ian Jackson
298f6f508c
arti cfg: Write down future plans
...
Mostly cribbed from
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/684#note_2829937
2022-08-23 13:55:48 +01:00
Ian Jackson
457c17adb0
tor-config: Provide resolve_option_general, for T: !Default etc.
...
At one point in this MR I thought I was going to want this for
arti::cfg::ListenConfig (which we don't want to be Default).
In fact ListenConfig is being handled specially, but having written
this function it seemed sensible to keep it. Since resolve_option
becomes a wrapper for it, the existing tests exercise it.
2022-08-22 16:26:38 +01:00
Ian Jackson
086cf3701a
arti cfg: Test parsing of the oldest config file we still support
2022-08-22 16:26:22 +01:00
Ian Jackson
a1cc2578b3
arti cfg: Fix docs about ARTI_EXAMPLE_CONFIG
...
The defaults are now
2022-08-22 16:26:22 +01:00
eta
bca7250524
Merge branch 'ansi-term' into 'main'
...
Tolerate RUSTSEC-2021-0139 (ansi_term unmaintained)
See merge request tpo/core/arti!683
2022-08-22 15:18:22 +00:00
Ian Jackson
eb93e05552
maint/cargo_audit: Tolerate RUSTSEC-2021-0139 (ansi_term unmaintained)
2022-08-22 10:37:00 +01:00
Ian Jackson
ff962e5109
maint/cargo_audit: Honour $CARGO
...
This makes it easier to for me to test this script. (I would like to
do this to all of them but it's easier on a case-by-case basis.)
2022-08-22 10:36:53 +01:00
Nick Mathewson
83eefe1e21
Merge branch 'format-python-script' into 'main'
...
Format python script in maint
See merge request tpo/core/arti!678
2022-08-17 12:45:02 +00:00
Ian Jackson
46d9dadd02
Merge branch 'channel' into 'main'
...
Channel padding
See merge request tpo/core/arti!657
2022-08-17 10:26:25 +00:00
Ian Jackson
12c5af9b7a
doc/Compatibility.md: tick the box for link protocol 5
...
We do this now. As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2828364
2022-08-17 10:54:41 +01:00
Ian Jackson
d4ce701fa4
channel padding: Only do anything with link protocol 5
...
Or rather, if we *didn't* negotiate 4, which is too old.
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2828354
2022-08-17 10:54:41 +01:00
Ian Jackson
08a7257fe9
channel padding: Properly advertise link protocol 5
...
We already actually send and negotiate the padding, since !657 ,
but we ought to negotiate a protocol version where that's not a
violation!
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2828354
2022-08-17 10:54:41 +01:00
Ian Jackson
a0b0eca93e
tor-netdoc: if_ito: Add expansion of acronym
2022-08-17 10:54:41 +01:00
Ian Jackson
8339558ba8
channel padding: Move initial config of ChannelPaddingInstructions
...
Making ChannelPaddingInstructions::default() accurately reflect the
initial state of the reactor's padding timer simplifies the code
somewhat.
(When padding is wanted, parameters are computed and inserted
explicitly, so the only change is that if we start out dormant, we
defer setting the timer parameters until necessary.)
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2827249
2022-08-17 10:54:41 +01:00
Ian Jackson
8a484a26e6
channel padding: Parameters: default_padding replaces Default impl
...
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2827249
2022-08-17 10:54:41 +01:00
Ian Jackson
3aed28acd4
channel usage: Rename CU::UserTraffic from CU::Exit
...
As suggested in
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2827246
2022-08-17 10:54:41 +01:00
Ian Jackson
24e2c717f0
chanmgr padding: Correct docs for padding_parameters*
...
Prompted by
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2827242
These texts were out of date; one of them still mentioned
`all_zeroes`.
2022-08-17 10:54:41 +01:00
Nick Mathewson
cbd759163a
Improve comment for ChannelUsage::Exit
2022-08-17 10:54:41 +01:00
Nick Mathewson
d44c860355
Fix typo in comment
2022-08-17 10:54:41 +01:00
Ian Jackson
c97ea4fce0
tor-chanmgr tests: Fix a minimal-versions failure (actually)
2022-08-17 10:54:41 +01:00
Ian Jackson
a892a3ee62
tor-chanmgr tests: Fix a minimal-versions failure
2022-08-17 10:54:41 +01:00
Ian Jackson
074d08bee8
arti: Fix a minimal-versions failure
2022-08-17 10:54:41 +01:00
Ian Jackson
d9338293c8
Add semver notes
2022-08-17 10:54:41 +01:00
Ian Jackson
4111c63bd4
channel reactor: Add some commented-out debug for padding
2022-08-17 10:54:41 +01:00