44402f722e
tor-basic-utils: Add a test for DropNotifyWatchSender
2022-07-19 19:04:34 +01:00
c7933de0ab
tor-basic-utils: Add ref to upstream issue re drop
2022-07-19 19:00:23 +01:00
bd41e29f33
tor-basic-utils: Add comment about lack of race
...
In answer to
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/632#note_2822107
I think this is subtle enough that it deserves a comment.
2022-07-19 17:21:22 +01:00
248e6136bd
Implement ESTABLISH_INTRO relay cell
2022-07-18 21:22:43 -04:00
cb982183f9
arti-client: Do periodic task dormancy in a management task
...
This means that it is no longer possible to write code which updates
the dormant mode but forgets to notify the periodic tasks.
2022-07-18 18:13:13 +01:00
2d3f4493a4
arti-client: Make dormant_mode be an Option, None on drop
...
This will allow receivers (which we are about to introduce) to
terminate when the last client is dropped.
2022-07-18 18:13:13 +01:00
bc498bc7a0
arti-client: Provide DropNotifyWatchSender
...
There are going to be some tasks (well, right away, one task) which
will want to go away when the sender is dropped.
The docs in postage are silent, but postage:⌚ :Sender does not
have a Drop impl so I don't think we can rely on the Receivers getting
None from their Stream impl.
So we're going to have the watch send Options, which are None only
when the sender is dropped.
2022-07-18 18:13:13 +01:00
9146a03533
arti-client: Convert dormant_mode into a postage::watch
...
We are going to want to be able to wake up other tasks elsewhere in
Arti, that need to know about dormancy. We will give them a postage
watch Receiver.
Right now there are no such things yet.
2022-07-18 18:13:13 +01:00
9287e009cc
arti-client: Make DormantMode have a Default
2022-07-18 18:13:13 +01:00
f8170a9c48
arti-client: Add Bug variant to error
...
We're going to want this in a moment.
2022-07-18 18:13:13 +01:00
7acdd21750
Provide maybe_send on postage: ⌚ :Sender, via extension trait
...
We need to replace the AtomicBool for dormant mode with something that
can wake up tasks. postage::watch is the right shape.
But we want to be able to update it but suppress no-op updates.
(There is going to be a call site where no-op updates can occur.)
In the absence of a suitable upstream method as requested here
https://github.com/austinjones/postage-rs/issues/56
we introduce this facility via an extension trait.
2022-07-18 18:13:13 +01:00
bcf94f33e0
tor-cell: Derive Eq for NtorV3Extension
...
Apropos clippy complaint.
2022-07-18 17:49:59 +01:00
8d66f8ecd0
Merge branch 'dirmgr_error_cleanup' into 'main'
...
Clean up some errors in tor-dirmgr
Closes #521
See merge request tpo/core/arti!628
2022-07-18 14:40:11 +00:00
3c424c82d7
dirmgr: Add a helper to create LockFile errors.
2022-07-18 10:10:28 -04:00
26bfc5d061
Merge branch 'unused' into 'main'
...
tor-persist: Resource::Temporary: Mark with cfg
See merge request tpo/core/arti!629
2022-07-18 13:52:13 +00:00
b7de46958d
tor-persist: Resource::Temporary: Mark with cfg
...
Without this, some builds get a "variant is never constructed" warning.
2022-07-18 13:07:30 +01:00
44f37b2d07
Merge branch 'cirmgr_error_cleanup' into 'main'
...
Clean-ups in circmgr errors
See merge request tpo/core/arti!625
2022-07-15 15:58:44 +00:00
9d3beb34a3
Bump tor-dirmgr to version 0.5.1.
...
This does not require a change in any other crate, since
the change here does not affect tor-dirmgr's APIs.
2022-07-14 12:00:42 -04:00
eaf0733a6c
Changelog for tor-dirmgr 0.5.1
2022-07-14 12:00:08 -04:00
c983987782
dirmgr: Make UnrecognizedSchema more helpful
2022-07-14 09:53:17 -04:00
8cbc740d90
dirmgr: Add an instance of BadUtf8InCache
2022-07-14 09:32:01 -04:00
d1e9d4ce84
dirmgr: Clarify disk IO errors.
2022-07-14 09:27:29 -04:00
13b2a35a5d
Merge branch 'cache-filename-formatting-windows' into 'main'
...
Fix illegal formatting in cache filenames on Windows
Closes #516
See merge request tpo/core/arti!627
2022-07-14 13:06:16 +00:00
c1101f13f3
dirmgr: style edits to error messages.
2022-07-14 08:40:42 -04:00
171dd5eb63
Fix illegal formatting in cache filenames
2022-07-14 15:27:52 +03:00
87801dd4c0
Apply 1 suggestion(s) to 1 file(s)
2022-07-13 13:13:13 +00:00
ef76b273a9
circmgr: Refactor DirPathBuilder::pick_path.
...
We no longer needs to have a "return" at the end of each match
block.
2022-07-12 12:05:35 -04:00
c59d6a9211
circmgr: Use FilterCounts to explain why we couldn't build paths
2022-07-12 12:02:12 -04:00
2deb03eb61
circmgr: Use FilterCounts to explain why we couldn't find an exit.
2022-07-12 11:51:05 -04:00
98cda34fb8
netdir: Make pick() functions take FnMut closures.
...
There's no reason to enforce their being Fn closures, and allowing
them to be FnMut allows us to count which filters make us rejected
given relays.
2022-07-12 11:43:49 -04:00
ad87cdcf27
tor-basic-utils: Add a new interface to FilterCount
...
This interface allows using FilterCount with functions that expect
predicates rather than iterator chains.
I'm about to use it to get meaningful FilterCount results in the
path-selection code in circmgr.
2022-07-12 11:35:41 -04:00
8d8c61cc98
Merge branch 'docs' into 'main'
...
Fix some rustdoc links
See merge request tpo/core/arti!624
2022-07-12 14:49:18 +00:00
f098b93d0a
tor-persist: StateMgr: vagueify docs about NoLock error
...
`NoLock` is now a variant of `err::ErrorSource` but that is private.
2022-07-12 15:15:07 +01:00
1fc86e3ea9
Fix two rustdoc links
...
This type must have been renamed, I guess.
2022-07-12 15:14:47 +01:00
51f4779f75
tor-circmgr: Clarify and improve Protocol error.
2022-07-12 10:01:56 -04:00
4db7f4b9db
tor-circmgr: minor error message edits.
2022-07-12 09:39:20 -04:00
4dce7557b6
Remove the last vestiges of write_infallible.
...
Now that everything has been converted to fallible writers, we get
to finally remove write_infallible() from tor_bytes.
2022-07-11 11:18:51 -04:00
fbb6484025
tor-proto: Stop using write_infallible in handshake code.
...
This change was a bit annoying, since most of this code _can't_ fail,
and so the only reasonable response is to wrap the input in an
internal error... except for one case where we're actually encoding
a caller-provided message, so we _do_ want to wrap the EncodeError
from tor_bytes.
2022-07-11 11:18:51 -04:00
44314f5076
tor-cell: Stop using write_infallible
...
Also, stop using "expect" and "assert!" to check for errors.
2022-07-11 11:18:51 -04:00
a0a88643f8
tor-cell: Make encoding method signatures fallible.
2022-07-11 11:18:51 -04:00
8ef003c623
tor-linkspec: Stop using infallible writers.
2022-07-11 11:18:51 -04:00
11451235d5
tor-cert: Remove all usage of infallible writers.
2022-07-11 11:18:51 -04:00
2367f92c2c
tor-cert: Encoding now uses Writeable trait.
...
This lets us remove a few TODOs.
2022-07-11 11:18:51 -04:00
9b02cf004c
tor-bytes::impls: Remove usage of infallible writers.
2022-07-11 11:18:51 -04:00
9ca301faee
socksproto: Use fallible writers.
...
Also, make private a function that had formerly been `pub`.
2022-07-11 11:18:51 -04:00
5a61a6d73a
Remove "write_and_consume_infallible".
...
There were only a few of these. Removing it required porting
everything to use `write_and_consume` instead, and handling its
(potential) errors.
2022-07-11 11:18:51 -04:00
8810af7f65
Convert each write_onto_infallible implementation into write_onto.
2022-07-11 11:18:51 -04:00
e1337bee8f
Convert each write_into_infallible implementation into write_into.
...
(There was only one.)
2022-07-11 11:18:51 -04:00
26c81edeea
Define new write_into and write_onto methods with correct APIs.
2022-07-11 11:18:51 -04:00
7938f65c66
Rename "write" methods on tor-bytes to "write_infallible".
...
This comprises four renames:
```
write_onto -> write_onto_infallible
write_into -> write_into_infallible
write -> write_infallible
writer_and_consume -> write_and_consume_infallible.
```
The rest of this branch will be concerned with replacing these
`_infallible` methods with ones that return a `Result`. This is
part of #513 .
2022-07-11 11:18:51 -04:00
Ian Jackson
Yuan Lyu
Nick Mathewson
Ian Jackson
feelingnothing