vincenzopalazzo
/
arti
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3,774 Commits 3 Branches 23 Tags 19 MiB
Commit Graph

3774 Commits

Author SHA1 Message Date
Ian Jackson 4bf87d61ca Merge branch 'config-split' into 'main' 
Break TorClientConfig out of ArtiConfig and warn on unknown config keys

Closes #459 and #417

See merge request tpo/core/arti!529
 2022-05-26 10:40:43 +00:00
Ian Jackson c5a8e453b9 tor-config: load: clippy: adopt two suggestions 
We can have mem::take, hooray.
 2022-05-26 11:03:48 +01:00
Ian Jackson 42ccb68446 tor-config: load: Add missing "not". 
As per
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807331
 2022-05-26 10:57:26 +01:00
Ian Jackson f5561c8cdb tor-config: load: Make UnrecognizedKeys not pub 
This was a slip.

As per
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807330
 2022-05-26 10:57:04 +01:00
trinity-1686a 545313a899 fix docker_reproducible_build not passing its parameters properly 2022-05-26 09:44:06 +02:00
trinity-1686a 0f14847023 update comments in coverage_fuzz_corpora 2022-05-25 22:29:04 +02:00
trinity-1686a b380c25e66 update readmes 2022-05-25 22:25:58 +02:00
trinity-1686a 8eb843f2af make almost all scripts use bash and set euo pipefail 2022-05-25 22:25:58 +02:00
Nick Mathewson 60023ef656 Test a few more corner cases in tor-persist 
Also, if we get an IoError from a call to fs-mistrust, report it as
an IoError.
 2022-05-25 15:57:19 -04:00
Nick Mathewson bbc7470dc5 More tests for ClockSkew. 2022-05-25 15:57:19 -04:00
Nick Mathewson 7c86e0a6b3 Merge branch 'no-disable-arti-permission-checks' into 'main' 
ci: don't disable arti permission checks, fix resulting issues

See merge request tpo/core/arti!530
 2022-05-25 19:42:32 +00:00
Ian Jackson ed95d50d49 tor-config: load: Add reversed test 2022-05-25 19:15:47 +01:00
Ian Jackson ce96f0d9ce tor-config: Add duplicative doc comments as per review 2022-05-25 19:15:47 +01:00
Ian Jackson 21a064d4f8 tor-config: load: example: Document what it does and who might write it 2022-05-25 19:15:47 +01:00
Ian Jackson 3eab61603a tor-config: load: Add a newline 
This makes the function a tiny bit clearer.
 2022-05-25 19:15:47 +01:00
Ian Jackson bf97190a9f tor-config: load: Write actual definition of the Resolvable trait 
This is not a doc comment because we don't want it to be public: it
must refer to private fields, etc.
 2022-05-25 19:15:47 +01:00
Ian Jackson 80ddae3d4b arti: Better doc for ArtiCombinedConfig 2022-05-25 19:15:47 +01:00
Ian Jackson 2b65e1250e tor-config: load: Explain why not write out macro call n times 2022-05-25 19:15:47 +01:00
Ian Jackson 1ee2be9d6d tor-config: docs: add more docs about load, esp. traits 2022-05-25 19:15:47 +01:00
Ian Jackson 337b4a7231 tor-config: docs: add a lot of context and overview and xrefs 2022-05-25 19:15:47 +01:00
Ian Jackson 40b433d4ba tor-config: load: Avoid destructuring assignment 
Not available in our MSRV.
 2022-05-25 19:15:47 +01:00
Ian Jackson b552c4e2bf tor-config: load: Intersection: add more commentary 2022-05-25 19:15:47 +01:00
Ian Jackson 5661df823f tor-config: load: Drop a needless call to .into_iter() 
I think this is a leftover from a previous version of this expression.
 2022-05-25 19:15:47 +01:00
Ian Jackson a8a3661503 tor-config: load: Fix a misleading comment 
As per
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807070
 2022-05-25 19:15:47 +01:00
Ian Jackson 964794bfa0 tor-config: load: Rename shorter_let 
Instead of the wrong "prefix_len".  As per
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807068
 2022-05-25 19:15:47 +01:00
Ian Jackson 26715c5550 tor-config: load: Docs 2022-05-25 19:15:47 +01:00
Ian Jackson 4f62c3ded1 tor-config: Typo fixes (as per review comments) 2022-05-25 19:15:47 +01:00
Ian Jackson 28c1f707a1 tor-config: load: Introduce UnrecognizedKeys enum 
As per
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807078

This is in fact much clearer than the Option.
 2022-05-25 19:15:47 +01:00
Ian Jackson 151d28c90f Run rustfmt following renaming 
Split into its own commit to avoid churn in the rename commits.
 2022-05-25 16:41:50 +01:00
Ian Jackson 0803296bd6 tor-config: Rename resolve_return_unrecognized, ..._ignore_... 
As per
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807077
 2022-05-25 16:41:05 +01:00
Ian Jackson 9f426e2c57 tor-config: Rename "ignored" to "unrecognized" throughout 
As per review comments
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807076
 2022-05-25 16:40:02 +01:00
Ian Jackson e9538a7eef Merge branch 'no_nochange' into 'main' 
DirMgr:: Remove Error::NoChange as redundant.

Closes #484

See merge request tpo/core/arti!532
 2022-05-25 14:35:32 +00:00
Alex Xu (Hello71) 85b4b5620d fs-mistrust: allow symlinks to have any permissions 2022-05-25 10:27:45 -04:00
Alex Xu (Hello71) 4797c120d0 ci: set umask instead of ARTI_FS_DISABLE_PERMISSION_CHECKS 2022-05-25 10:27:45 -04:00
Ian Jackson 4b0459d204 Merge branch 'bug475' into 'main' 
ConfigurationSources: Allow config files to be world-readable.

Closes #475

See merge request tpo/core/arti!528
 2022-05-25 14:23:12 +00:00
Nick Mathewson bc3c9d475f Merge branch 'support_policy' into 'main' 
Initial draft policy on supported platforms and dependencies

Closes #379

See merge request tpo/core/arti!513
 2022-05-25 13:14:54 +00:00
Nick Mathewson 52a338a378 Merge branch 'socks-errors' into 'main' 
reply socks error on more codepath

Closes #258

See merge request tpo/core/arti!531
 2022-05-25 13:13:18 +00:00
Nick Mathewson 0caa5bcba5 DirMgr:: Remove Error::NoChange as redundant. 
Now that the relevant functions now report changed/not-changed
status via a boolean out-parameter (see !527), there's no reason to
have a separate NoChanged error case.

Closes #484.
 2022-05-25 08:58:37 -04:00
Nick Mathewson 3b837eb7f4 Typo fixes (automated with "typos"). 2022-05-24 19:21:12 -04:00
trinity-1686a 801380780f reply socks error on more codepath 2022-05-25 00:02:14 +02:00
Nick Mathewson 92f0f97fe8 Merge branch 'isolation-example' into 'main' 
add example for Isolation

Closes #414

See merge request tpo/core/arti!524
 2022-05-24 19:34:14 +00:00
eta 608d0cbcc2 Merge branch 'bug482' into 'main' 
DirMgr: Stop load-from-cache process when there is no change.

Closes #482

See merge request tpo/core/arti!527
 2022-05-24 19:33:42 +00:00
Ian Jackson 112cce10ba semvar_status: Document config changes 2022-05-24 20:17:23 +01:00
Ian Jackson 9c88158740 tor-config: Example for load module 2022-05-24 20:14:57 +01:00
Ian Jackson bb8e205b0d tor-config: Tests for ignored config key handling 2022-05-24 20:14:57 +01:00
Ian Jackson 09f26f2d68 tor-config: Track and (by default) warn on ignored config keys 2022-05-24 20:14:57 +01:00
Ian Jackson e1bc599db2 tor-config: Tests for support functions for tracking ignored keys 2022-05-24 20:14:57 +01:00
Ian Jackson 865ae13502 tor-config: Support functions for tracking ignored config keys 
This turns out to need quite a complicated algorithm.
 2022-05-24 20:14:57 +01:00
Ian Jackson 9e526aad7c Split TorClientConfig out of ArtiConfig, and Resolvable trait 
This gets rid of `#[serde(flatten)]` which prevents serde_ignored (and
other kinds of introspection) from working properly.

The price is now that the toplevel has to deal with two configuration
objects.

The Resolvable trait is overkill right now, but is going to do More
Things in a moment.  In particular, we need the impl on tuples, so
that the whole config can be processed in one go.
 2022-05-24 20:14:57 +01:00
Nick Mathewson 460117f2b0 Allow use of RetainMut, since we do not require Rust 1.61 yet. 2022-05-24 15:09:00 -04:00