Commit Graph

17 Commits

Author SHA1 Message Date
S0AndS0 432fd9443e WIP: Add the "unwrap_used" lint.
> Check `unwrap_used` section of Clippy documentation for details;
>
>   https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

This adds the following Clippy configuration to crates;

    #![deny(clippy::unwrap_used)]

**Warning** while tests and compiler do not show any errors, the submitted
changes are very much a Work In Progress and mistakes may have been made. Check

    https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/67

Merge Request thread for more details.
2021-08-24 15:31:31 -07:00
Nick Mathewson fe5d826942 Merge remote-tracking branch 'origin/mr/60' 2021-08-18 08:53:11 -04:00
S0AndS0 484cc24856 Add the "implicit_clone" lint.
> Check `implicit_clone` section of Clippy documentation for details;
>
>   https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone

This adds, and addresses, the following Clippy configuration to crates;

    #![deny(clippy::implicit_clone)]

And moves related line within `maint/add_warning.py` file. My intent is to
mitigate extra edits after merging, so please let me know if I need to do this
last bit differently.
2021-08-17 11:49:39 -07:00
S0AndS0 b5a58f5871 Add the "missing_panics_doc" lint.
> Check `missing_panics_doc` section of Clippy documentation for details;
>
>   https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

This adds the following Clippy configuration to crates;

    #![deny(clippy::missing_panics_doc)]

And adds necessary doc-comments to methods that may panic.
2021-08-13 15:11:04 -07:00
Nick Mathewson 9c6dd27ca1 Use add_warnings.py for clippy::cast_lossless 2021-08-13 11:36:14 -04:00
S0AndS0 657e7b2246 Add the "cast_lossless" lint.
> Check `cast_lossless` section of Clippy documentation for details;
>
>   https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless

This adds the following Clippy configuration to crates;

    #![deny(clippy::cast_lossless)]

And applies suggested Clippy and `cargo fmt` fixes.
2021-08-12 17:25:15 -07:00
Nick Mathewson 79d9eac58c Add unnecessary_wraps to the big warning list. 2021-08-06 16:20:37 -04:00
Nick Mathewson 95e8f67a4a Disable a warning from Rust 1.54 2021-07-29 10:49:40 -04:00
Nick Mathewson 1c21295d19 Merge remote-tracking branch 'origin/mr/34' 2021-06-27 14:30:49 -04:00
Nick Mathewson 920539bb05 Missing fields in tor-units/Cargo.toml. 2021-06-24 07:20:40 -04:00
Nick Mathewson b774360755 Remove "publish = false" 2021-06-24 07:04:26 -04:00
YUAN LYU 92dbf20a76 Add clippy warn needless pass by value 2021-06-21 23:27:19 -04:00
Nick Mathewson a36626d9de Run "typos" to fix a few more typos. 2021-06-17 18:45:05 -04:00
Nick Mathewson 5c87cd1eb2 Update retry-error README 2021-06-17 18:41:47 -04:00
Nick Mathewson 458bc44ca9 Use retry-error in tor-circmgr. 2021-06-17 18:34:39 -04:00
Nick Mathewson 3763dab2f1 Add deduplication for retry-error 2021-06-17 16:38:20 -04:00
Nick Mathewson be86df631d Remove anyhow dependency from tor-retry, and rename it to retry-error
Now RetryError is parameterized on an underlying error type.
2021-06-17 16:09:43 -04:00