2c0ec4e442
Tweaks on patch to add clippy::unwrap_used lint.
...
The most frequent changes are:
- Rewording messages about poisoned locks
- Correcting some error types
2021-08-27 09:05:25 -04:00
432fd9443e
WIP: Add the "unwrap_used" lint.
...
> Check `unwrap_used` section of Clippy documentation for details;
>
> https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
This adds the following Clippy configuration to crates;
#![deny(clippy::unwrap_used)]
**Warning** while tests and compiler do not show any errors, the submitted
changes are very much a Work In Progress and mistakes may have been made. Check
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/67
Merge Request thread for more details.
2021-08-24 15:31:31 -07:00
92501895fd
Fix a few things that the "typos" tool didn't like.
2021-08-20 12:11:28 -04:00
341e3937b4
Revisions based on new documented-panics lint.
...
I've tried to remove some of possible panics, and improve the
documentation for when the others might occur.
2021-08-18 09:55:39 -04:00
fe5d826942
Merge remote-tracking branch 'origin/mr/60'
2021-08-18 08:53:11 -04:00
484cc24856
Add the "implicit_clone" lint.
...
> Check `implicit_clone` section of Clippy documentation for details;
>
> https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone
This adds, and addresses, the following Clippy configuration to crates;
#![deny(clippy::implicit_clone)]
And moves related line within `maint/add_warning.py` file. My intent is to
mitigate extra edits after merging, so please let me know if I need to do this
last bit differently.
2021-08-17 11:49:39 -07:00
b5a58f5871
Add the "missing_panics_doc" lint.
...
> Check `missing_panics_doc` section of Clippy documentation for details;
>
> https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
This adds the following Clippy configuration to crates;
#![deny(clippy::missing_panics_doc)]
And adds necessary doc-comments to methods that may panic.
2021-08-13 15:11:04 -07:00
9c6dd27ca1
Use add_warnings.py for clippy::cast_lossless
2021-08-13 11:36:14 -04:00
657e7b2246
Add the "cast_lossless" lint.
...
> Check `cast_lossless` section of Clippy documentation for details;
>
> https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
This adds the following Clippy configuration to crates;
#![deny(clippy::cast_lossless)]
And applies suggested Clippy and `cargo fmt` fixes.
2021-08-12 17:25:15 -07:00
79d9eac58c
Add unnecessary_wraps to the big warning list.
2021-08-06 16:20:37 -04:00
80745dffcd
Update to rsa 0.5.0. Minor compatibility issues.
2021-08-05 17:11:44 -04:00
c813eb1a10
Add symlinks to arti-corpora
2021-08-04 15:52:24 -04:00
51d91508f7
Fix typos and other spelling mistakes
2021-07-31 18:02:35 +02:00
d23256074e
address a bunch of hopefully uncontroversial lints
2021-07-20 22:59:59 +01:00
e0797aa1a1
Revert "clippy: remove unneeded dependencies."
...
This sort of reverts 37b978ae1b
2021-07-02 08:40:44 -04:00
37b978ae1b
clippy: remove unneeded dependencies.
2021-06-27 14:32:46 -04:00
1c21295d19
Merge remote-tracking branch 'origin/mr/34'
2021-06-27 14:30:49 -04:00
b774360755
Remove "publish = false"
2021-06-24 07:04:26 -04:00
92dbf20a76
Add clippy warn needless pass by value
2021-06-21 23:27:19 -04:00
b830e81b7f
Add clippy warn needless borrow
2021-06-21 21:34:40 -04:00
e6faeaa1f8
Fix some warnings about needless & from nightly clippy
2021-06-18 07:19:24 -04:00
2102d2e2b5
Add noop_method_call warning.
...
This would have saved ahf and me a lot of confusion in debugging a
situation where we were cloning a reference of a type that didn't
implement Clone.
2021-05-27 14:32:29 -04:00
745c90e92c
Enable cargo_common_metadata warning.
2021-05-25 15:42:47 -04:00
cf59e9be77
Add automatically generated README.md files to each crate.
2021-05-25 15:41:23 -04:00
e4784932ce
tor-llcrypto: finish a sentence in the docs.
2021-05-24 12:41:05 -04:00
696202217b
Add a link tto the tor website to arti blurb.
2021-05-24 08:44:04 -04:00
50aee17871
Add tor-proto docs and tweak docs+apis elsewhere.
2021-05-21 15:40:08 -04:00
57f65b261e
tor-llcrypto: Improve documentation and move keyblinding.
2021-05-21 11:27:41 -04:00
ce6702a147
Give every Cargo.toml a repository field
2021-05-19 14:56:09 -04:00
712e6ec23c
Fill in "package.categories" on all Cargo.toml
2021-05-19 14:50:39 -04:00
411e1b35e0
Add the "unreachable_pub" lint.
...
This is a somewhat obnoxious change in its scope and requirements,
but it makes it easier to understand what the real public and
private parts of our APIs are.
2021-05-18 13:45:39 -04:00
7c7be3a3f1
Upgrade to latest RustCrypto crates.
2021-05-06 07:57:31 -04:00
8eb36cbfff
Add trait_duplication_in_bounds warning.
2021-05-03 16:30:27 -04:00
d516298b47
Add unseparated_literal_suffix lint, and fix it.
2021-05-03 16:19:01 -04:00
9737580402
Add a few more clippy warnings
2021-05-03 16:10:39 -04:00
94c93c9121
Add some more clippy warnings to our list.
2021-04-27 14:51:04 -04:00
2e3780affb
Enforce (and obey) clippy lints about exhaustive enums, structs.
...
These lints force us to declare our exported enums and
exhaustive-looking structs as non-exhaustive (so that we can add to
them in the future without breaking our API) or to explicitly
disable the warning for a given enum/struct (to say that we _intend_
for additions to be a breaking change).
2021-04-27 14:17:49 -04:00
adefe60f60
upgrade httparse and zeroize
2021-04-25 12:39:35 -04:00
67eec8ab91
upgrade dalek dependencies
2021-04-14 08:37:57 -04:00
9f44408bb9
Upgrade rsa, zstd, httpdate. Remove redundant pin-project.
2021-04-05 08:26:29 -04:00
e9e85dfce8
Resolve two clippy warnings in blind_pubkey.
2021-03-29 18:08:56 -04:00
63a4f37f2e
Merge remote-tracking branch 'origin/mr/23'
2021-03-29 17:09:05 -04:00
32a117ebc0
v3: Add two new test vectors that test key blinding clamping.
2021-03-30 00:06:26 +03:00
294c6b0897
v3: Improve error handling on key blinding.
2021-03-30 00:06:20 +03:00
3ad503866d
Fix Rust-1.51 clippy warnings about acronyms in camel case.
...
This is painful, but we shouldn't have to do it again.
2021-03-29 16:33:48 -04:00
3800c459f6
Rename Rsa{Identity,Signature} to fix clippy warning.
2021-03-29 16:14:43 -04:00
ea10259be2
Implement basic ed25519 key blinding for v3 onion services.
2021-03-29 20:29:12 +03:00
603b0436e0
Add a compatibility layer so we can upgrade rand_core.
...
dalek-crypto is stuck on rand_core 0.5.1, so we've been stuck too.
This commit introduces a compatibility module so that we can wrap
new rand_core instances to make them backward compatible.
2021-03-18 13:16:32 -04:00
6daf57957d
Add the tor project as an author.
2021-03-17 14:43:40 -04:00
ba14d43be4
Add keywords to each Cargo.toml
2021-03-17 14:41:02 -04:00
Nick Mathewson
S0AndS0
rls
Daniel Eades
YUAN LYU
George Kadianakis