Commit Graph

69 Commits

Author SHA1 Message Date
Luca Bruno c8f0623ad1 libkmod-module: check for NULL before accessing pointers
This introduces a few missing NULL-checks in public functions, and
align their docstrings with real behavior by getting rid of copy-paste
mistakes.

Signed-off-by: Luca Bruno <luca.bruno@coreos.com>
2018-04-05 14:54:43 -07:00
Lucas De Marchi f7c243ac59 Update TODO 2015-03-01 14:16:59 -03:00
Lucas De Marchi 709a465d0e Update TODO 2015-02-19 01:00:05 -02:00
Lucas De Marchi 45f38e8c40 Update TODO 2015-01-26 23:31:04 -02:00
Lucas De Marchi 895aa13478 Update TODO 2015-01-14 11:10:53 -02:00
Lucas De Marchi 419b7003af Update TODO 2014-09-23 00:21:53 -03:00
Lucas De Marchi cd923111c6 README: Move items from TODO
Put the differences between kmod and module-init-tools in the README
file so it's more visible.
2013-07-17 02:31:27 -03:00
Lucas De Marchi e975fd3115 TODO: Add some entries 2013-04-30 12:37:43 -03:00
Lucas De Marchi 681bf89afd libkmod-index: Return early if readroot failed 2013-04-23 21:26:09 -03:00
Lucas De Marchi 46939ec7be TODO: update and reorder 2013-04-09 20:20:38 -03:00
Lucas De Marchi 6c29e5c670 TODO: remove completed action 2012-11-08 02:01:59 -02:00
Lucas De Marchi 8836ff24b4 TODO: update file with tasks 2012-11-05 02:04:44 -02:00
Lucas De Marchi cc833644b2 rmmod: Deprecate --wait option
Remove --wait from usage() and give a message + sleep(10) if user is in
fact using it.
2012-10-17 18:43:17 -03:00
Lucas De Marchi 8447b865aa TODO: deprecate use of rmmod -w
As discussed with Rusty Russel, it would be nice to remove the related
code from kernel. Deprecate its use on kmod, so people know they
shouldn't be using it.
2012-08-30 14:10:47 -03:00
Lucas De Marchi c8c956b199 TODO: update tasks
- Remove dependency loop with install commands, since it's done
 - Add reasoning behind API refactor
2012-06-11 12:01:48 -03:00
Lucas De Marchi 5a2949cdf3 testsuite: create initstate file upon fake init_module() 2012-06-05 00:54:47 -03:00
Lucas De Marchi 9461893cf1 TODO: add item to implement actions in kmod 2012-04-16 20:21:45 -03:00
Lucas De Marchi 80e54cb675 TODO: update and organize items 2012-02-22 13:07:13 -02:00
Lucas De Marchi 3805274bf5 kmod-module: lookup: search modules.builtin file too
Search modules.builtin file before saying the module was not found.
Note: these "modules" should not appear as dependencies of other modules
(in modules.dep) even if they appear in modinfo. This fixes the return
code of modprobe with builtin modules.

Also fixes a small coding style issue in module_is_inkernel().
2012-02-16 21:18:00 -02:00
Dave Reisner f31d49c8b3 testsuite: add .path member to test struct
This allows us to prepend an arbitrary item to the PATH environment
variable, meaning we can favor the binaries we just built, rather than
relying on those in the filesystem.
2012-02-16 16:52:38 -02:00
Lucas De Marchi 9207df753a TODO: add tasks and bug fixes 2012-02-14 21:57:35 -02:00
Lucas De Marchi 976ea8c3ae testsuite: add tests to modprobe --show-depends
test 1 - check whether modprobe outputs the right thing when
using --show-depends is used with already loaded modules.

test 2 - check whether modprobe outputs the right thing when
using --show-depends with modules not loaded yet
2012-02-08 02:04:10 -02:00
Lucas De Marchi 269de2e0bf libkmod-module: probe: Fix ignore-loaded flag not being applied 2012-02-07 09:48:59 -02:00
Lucas De Marchi 54c43dff1b Add WARNING file for test dir and improve testsuite README 2012-02-06 19:52:58 -02:00
Lucas De Marchi c90fc61b6c TODO: add task to write testsuite/README 2012-02-03 18:11:53 -02:00
Lucas De Marchi 4bc1895674 Prepare for API bump 2012-01-31 16:05:02 -02:00
Lucas De Marchi f6ef5d6b5f testsuite: trap calls to delete_module() including simple test 2012-01-26 16:14:18 -02:00
Lucas De Marchi a41b39fb69 TODO: system() should not be used inside a library 2012-01-20 13:04:43 -02:00
Lucas De Marchi 758428a75f libkmod: dump index files
Provide a function to dump the index files to a certain fd. It could be
more optimized (particularly the functions to dump the index that were
copied and pasted from m-i-t), but it seems like the only user of it is
'modprobe -c', used for debugging purposes. So, keep it as is.
2012-01-16 16:05:46 -02:00
Lucas De Marchi bc43496a87 modprobe: dump configuration 2012-01-13 11:12:41 -02:00
Lucas De Marchi d89d7cb46a TODO: add code unification to list of tasks 2012-01-12 18:14:32 -02:00
Lucas De Marchi 8b01376742 modprobe: abort on dependency loop that cannot be broken 2012-01-12 17:14:30 -02:00
Lucas De Marchi e85b6731f9 TODO: update tasks 2012-01-12 15:37:53 -02:00
Lucas De Marchi f564394f99 TODO: update differences with m-i-t 2012-01-12 14:45:11 -02:00
Lucas De Marchi 92122614b2 modprobe: show if module is in kernel
Now with './tools/modprobe --show-depends ahci' (ahci is builtin) we have the following
output:

$ ./tools/modprobe --show-depends ahci
builtin ahci

Just like modprobe from m-i-t. Previously we had:

$ ./tools/modprobe --show-depends ahci
FATAL: Module ahci not found.
2012-01-11 21:54:25 -02:00
Dave Reisner b54f1bf06a modprobe: check for EPERM on insertion
Throw an appropriate error when an unprivileged user attempts to load a
module.
2012-01-10 22:33:05 -05:00
Lucas De Marchi 0ad5dd0837 config: deprecate 'include' and 'config' commands 2012-01-11 00:29:34 -02:00
Lucas De Marchi ca1f0f303e TODO: add task to modprobe 2012-01-10 15:45:14 -02:00
Lucas De Marchi ab8440a48a TODO: add tasks to modprobe 2012-01-10 10:19:01 -02:00
Lucas De Marchi 657722dd9d TODO: add task for providing man page 2012-01-01 06:18:16 -02:00
Lucas De Marchi c4dc3ca8a2 Add call to check if resources are valid 2012-01-01 06:18:16 -02:00
Lucas De Marchi 5a96c5f1d5 TODO: add list of things that are different on kmod 2012-01-01 06:12:00 -02:00
Dave Reisner 0e9bd2d1ca kmodprobe: post-remove module deps with 0 refcnt 2011-12-31 18:21:00 -05:00
Lucas De Marchi 3af535c97b TODO: format and add task 2011-12-27 17:32:55 -02:00
Gustavo Sverzut Barbieri 009ed664d7 update TODO
depmod was done, and without map support
2011-12-27 12:09:16 -02:00
Lucas De Marchi 088a6a83dc TODO: add task in modprobe's compatibility 2011-12-26 16:05:55 -02:00
Gustavo Sverzut Barbieri 674f8590e3 elf: implement kmod_module_get_dependency_symbols()
Uses kmod_elf_get_dependency_symbols() that looks into ".symtab" for
UNDEF symbols and matches the name from ".strtab" to "__versions" to
get crc.

Likely the public API should unify the symbol information getters and
list release, they are almost the same.
2011-12-24 01:44:31 -02:00
Gustavo Sverzut Barbieri 0cc3ccfd52 Introduce kmod-modinfo. 2011-12-19 15:06:49 -02:00
Gustavo Sverzut Barbieri 0e3e2f436e kmod-modprobe: implement --dump-modversions 2011-12-19 15:06:49 -02:00
Gustavo Sverzut Barbieri f841e63d7a TODO: add idea about single file with all compressed modules. 2011-12-19 12:34:37 -02:00