2018-08-03 16:29:38 +01:00
from fixtures import * # noqa: F401,F403
from lightning import RpcError
from utils import DEVELOPER , only_one , wait_for , sync_blockheight
import pytest
import time
import unittest
def test_connect ( node_factory ) :
l1 , l2 = node_factory . line_graph ( 2 , fundchannel = False )
openingd: take peer before we're opening, wait for explicit funding msg.
Prior to this, lightningd would hand uninteresting peers back to connectd,
which would then return it to lightningd if it sent a non-gossip msg,
or if lightningd asked it to release the peer.
Now connectd hands the peer to lightningd once we've done the init
handshake, which hands it off to openingd.
This is a deep structural change, so we do the minimum here and cleanup
in the following patches.
Lightningd:
1. Remove peer_nongossip handling from connect_control and peer_control.
2. Remove list of outstanding fundchannel command; it was only needed to
find the race between us asking connectd to release the peer and it
reconnecting.
3. We can no longer tell if the remote end has started trying to fund a
channel (until it has succeeded): it's very transitory anyway so not
worth fixing.
4. We now always have a struct peer, and allocate an uncommitted_channel
for it, though it may never be used if neither end funds a channel.
5. We start funding on messages for openingd: we can get a funder_reply
or a fundee, or an error in response to our request to fund a channel.
so we handle all of them.
6. A new peer_start_openingd() is called after connectd hands us a peer.
7. json_fund_channel just looks through local peers; there are none
hidden in connectd any more.
8. We sometimes start a new openingd just to send an error message.
Openingd:
1. We always have information we need to accept them funding a channel (in
the init message).
2. We have to listen for three fds: peer, gossip and master, so we opencode
the poll.
3. We have an explicit message to start trying to fund a channel.
4. We can be told to send a message in our init message.
Testing:
1. We don't handle some things gracefully yet, so two tests are disabled.
2. 'hand_back_peer .*: now local again' from connectd is no longer a message,
openingd says 'Handed peer, entering loop' once its managing it.
3. peer['state'] used to be set to 'GOSSIPING' (otherwise this field doesn't
exist; 'state' is now per-channel. It doesn't exist at all now.
4. Some tests now need to turn on IO logging in openingd, not connectd.
5. There's a gap between connecting on one node and having connectd on
the peer hand over the connection to openingd. Our tests sometimes
checked getpeers() on the peer, and didn't see anything, so line_graph
needed updating.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-08-08 15:10:58 +01:00
# These should be in openingd.
assert l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) [ ' connected ' ]
assert l2 . rpc . getpeer ( l1 . info [ ' id ' ] ) [ ' connected ' ]
assert len ( l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) [ ' channels ' ] ) == 0
assert len ( l2 . rpc . getpeer ( l1 . info [ ' id ' ] ) [ ' channels ' ] ) == 0
2018-08-03 16:29:38 +01:00
# Reconnect should be a noop
ret = l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , port = l2 . port )
assert ret [ ' id ' ] == l2 . info [ ' id ' ]
ret = l2 . rpc . connect ( l1 . info [ ' id ' ] , host = ' localhost ' , port = l1 . port )
assert ret [ ' id ' ] == l1 . info [ ' id ' ]
# Should still only have one peer!
assert len ( l1 . rpc . listpeers ( ) ) == 1
assert len ( l2 . rpc . listpeers ( ) ) == 1
# Should get reasonable error if unknown addr for peer.
with pytest . raises ( RpcError , match = r ' No address known ' ) :
l1 . rpc . connect ( ' 032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e ' )
# Should get reasonable error if connection refuse.
with pytest . raises ( RpcError , match = r ' Connection establishment: Connection refused ' ) :
l1 . rpc . connect ( ' 032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e ' , ' localhost ' , 1 )
# Should get reasonable error if wrong key for peer.
with pytest . raises ( RpcError , match = r ' Cryptographic handshake: ' ) :
l1 . rpc . connect ( ' 032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e ' , ' localhost ' , l2 . port )
def test_connect_standard_addr ( node_factory ) :
""" Test standard node@host:port address
"""
l1 , l2 , l3 = node_factory . get_nodes ( 3 )
# node@host
ret = l1 . rpc . connect ( " {} @ {} " . format ( l2 . info [ ' id ' ] , ' localhost ' ) , port = l2 . port )
assert ret [ ' id ' ] == l2 . info [ ' id ' ]
# node@host:port
ret = l1 . rpc . connect ( " {} @localhost: {} " . format ( l3 . info [ ' id ' ] , l3 . port ) )
assert ret [ ' id ' ] == l3 . info [ ' id ' ]
# node@[ipv6]:port --- not supported by our CI
# ret = l1.rpc.connect("{}@[::1]:{}".format(l3.info['id'], l3.port))
# assert ret['id'] == l3.info['id']
def test_reconnect_channel_peers ( node_factory , executor ) :
l1 = node_factory . get_node ( may_reconnect = True )
l2 = node_factory . get_node ( may_reconnect = True )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . fund_channel ( l2 , 10 * * 6 )
l2 . restart ( )
# Should reconnect.
wait_for ( lambda : only_one ( l1 . rpc . listpeers ( l2 . info [ ' id ' ] ) [ ' peers ' ] ) [ ' connected ' ] )
wait_for ( lambda : only_one ( l2 . rpc . listpeers ( l1 . info [ ' id ' ] ) [ ' peers ' ] ) [ ' connected ' ] )
# Connect command should succeed.
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
# Stop l2 and wait for l1 to notice.
l2 . stop ( )
wait_for ( lambda : not only_one ( l1 . rpc . listpeers ( l2 . info [ ' id ' ] ) [ ' peers ' ] ) [ ' connected ' ] )
# Now should fail.
with pytest . raises ( RpcError , match = r ' Connection refused ' ) :
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
# Wait for exponential backoff to give us a 2 second window.
l1 . daemon . wait_for_log ( ' ...will try again in 2 seconds ' )
# It should now succeed when it restarts.
l2 . start ( )
# Multiples should be fine!
fut1 = executor . submit ( l1 . rpc . connect , l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
fut2 = executor . submit ( l1 . rpc . connect , l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
fut3 = executor . submit ( l1 . rpc . connect , l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
fut1 . result ( 10 )
fut2 . result ( 10 )
fut3 . result ( 10 )
def test_balance ( node_factory ) :
l1 , l2 = node_factory . line_graph ( 2 , fundchannel = True )
p1 = only_one ( l1 . rpc . getpeer ( peer_id = l2 . info [ ' id ' ] , level = ' info ' ) [ ' channels ' ] )
p2 = only_one ( l2 . rpc . getpeer ( l1 . info [ ' id ' ] , ' info ' ) [ ' channels ' ] )
assert p1 [ ' msatoshi_to_us ' ] == 10 * * 6 * 1000
assert p1 [ ' msatoshi_total ' ] == 10 * * 6 * 1000
assert p2 [ ' msatoshi_to_us ' ] == 0
assert p2 [ ' msatoshi_total ' ] == 10 * * 6 * 1000
def test_bad_opening ( node_factory ) :
# l1 asks for a too-long locktime
l1 = node_factory . get_node ( options = { ' watchtime-blocks ' : 100 } )
l2 = node_factory . get_node ( options = { ' max-locktime-blocks ' : 99 } )
ret = l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
assert ret [ ' id ' ] == l2 . info [ ' id ' ]
openingd: take peer before we're opening, wait for explicit funding msg.
Prior to this, lightningd would hand uninteresting peers back to connectd,
which would then return it to lightningd if it sent a non-gossip msg,
or if lightningd asked it to release the peer.
Now connectd hands the peer to lightningd once we've done the init
handshake, which hands it off to openingd.
This is a deep structural change, so we do the minimum here and cleanup
in the following patches.
Lightningd:
1. Remove peer_nongossip handling from connect_control and peer_control.
2. Remove list of outstanding fundchannel command; it was only needed to
find the race between us asking connectd to release the peer and it
reconnecting.
3. We can no longer tell if the remote end has started trying to fund a
channel (until it has succeeded): it's very transitory anyway so not
worth fixing.
4. We now always have a struct peer, and allocate an uncommitted_channel
for it, though it may never be used if neither end funds a channel.
5. We start funding on messages for openingd: we can get a funder_reply
or a fundee, or an error in response to our request to fund a channel.
so we handle all of them.
6. A new peer_start_openingd() is called after connectd hands us a peer.
7. json_fund_channel just looks through local peers; there are none
hidden in connectd any more.
8. We sometimes start a new openingd just to send an error message.
Openingd:
1. We always have information we need to accept them funding a channel (in
the init message).
2. We have to listen for three fds: peer, gossip and master, so we opencode
the poll.
3. We have an explicit message to start trying to fund a channel.
4. We can be told to send a message in our init message.
Testing:
1. We don't handle some things gracefully yet, so two tests are disabled.
2. 'hand_back_peer .*: now local again' from connectd is no longer a message,
openingd says 'Handed peer, entering loop' once its managing it.
3. peer['state'] used to be set to 'GOSSIPING' (otherwise this field doesn't
exist; 'state' is now per-channel. It doesn't exist at all now.
4. Some tests now need to turn on IO logging in openingd, not connectd.
5. There's a gap between connecting on one node and having connectd on
the peer hand over the connection to openingd. Our tests sometimes
checked getpeers() on the peer, and didn't see anything, so line_graph
needed updating.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-08-08 15:10:58 +01:00
l1 . daemon . wait_for_log ( ' openingd-.*: Handed peer, entering loop ' )
l2 . daemon . wait_for_log ( ' openingd-.*: Handed peer, entering loop ' )
2018-08-03 16:29:38 +01:00
l1 . fundwallet ( 10 * * 6 + 1000000 )
with pytest . raises ( RpcError ) :
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 10 * * 6 )
l2 . daemon . wait_for_log ( ' to_self_delay 100 larger than 99 ' )
def test_second_channel ( node_factory ) :
l1 = node_factory . get_node ( )
l2 = node_factory . get_node ( )
l3 = node_factory . get_node ( )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . rpc . connect ( l3 . info [ ' id ' ] , ' localhost ' , l3 . port )
l1 . fund_channel ( l2 , 10 * * 6 )
l1 . fund_channel ( l3 , 10 * * 6 )
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_disconnect ( node_factory ) :
# These should all make us fail
disconnects = [ ' -WIRE_INIT ' ,
' @WIRE_INIT ' ,
' +WIRE_INIT ' ]
l1 = node_factory . get_node ( disconnect = disconnects )
l2 = node_factory . get_node ( )
with pytest . raises ( RpcError ) :
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
with pytest . raises ( RpcError ) :
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
with pytest . raises ( RpcError ) :
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
# Should have 3 connect fails.
for d in disconnects :
l1 . daemon . wait_for_log ( ' Failed connected out for {} '
. format ( l2 . info [ ' id ' ] ) )
# Should still only have one peer!
assert len ( l1 . rpc . listpeers ( ) ) == 1
assert len ( l2 . rpc . listpeers ( ) ) == 1
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_disconnect_funder ( node_factory ) :
# Now error on funder side duringchannel open.
disconnects = [ ' -WIRE_OPEN_CHANNEL ' ,
' @WIRE_OPEN_CHANNEL ' ,
' +WIRE_OPEN_CHANNEL ' ,
' -WIRE_FUNDING_CREATED ' ,
' @WIRE_FUNDING_CREATED ' ]
l1 = node_factory . get_node ( disconnect = disconnects )
l2 = node_factory . get_node ( )
l1 . fundwallet ( 2000000 )
for d in disconnects :
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
with pytest . raises ( RpcError ) :
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 20000 )
assert l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) is None
# This one will succeed.
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 20000 )
# Should still only have one peer!
assert len ( l1 . rpc . listpeers ( ) ) == 1
assert len ( l2 . rpc . listpeers ( ) ) == 1
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_disconnect_fundee ( node_factory ) :
# Now error on fundee side during channel open.
disconnects = [ ' -WIRE_ACCEPT_CHANNEL ' ,
' @WIRE_ACCEPT_CHANNEL ' ,
' +WIRE_ACCEPT_CHANNEL ' ]
l1 = node_factory . get_node ( )
l2 = node_factory . get_node ( disconnect = disconnects )
l1 . fundwallet ( 2000000 )
for d in disconnects :
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
with pytest . raises ( RpcError ) :
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 20000 )
assert l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) is None
# This one will succeed.
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 20000 )
# Should still only have one peer!
assert len ( l1 . rpc . listpeers ( ) ) == 1
assert len ( l2 . rpc . listpeers ( ) ) == 1
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_disconnect_half_signed ( node_factory ) :
# Now, these are the corner cases. Fundee sends funding_signed,
# but funder doesn't receive it.
disconnects = [ ' @WIRE_FUNDING_SIGNED ' ]
l1 = node_factory . get_node ( )
l2 = node_factory . get_node ( disconnect = disconnects )
l1 . fundwallet ( 2000000 )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
with pytest . raises ( RpcError ) :
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 20000 )
# Fundee remembers, funder doesn't.
assert l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) is None
assert l2 . rpc . getpeer ( l1 . info [ ' id ' ] ) [ ' id ' ] == l1 . info [ ' id ' ]
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_reconnect_signed ( node_factory ) :
# This will fail *after* both sides consider channel opening.
disconnects = [ ' +WIRE_FUNDING_SIGNED ' ]
l1 = node_factory . get_node ( may_reconnect = True )
l2 = node_factory . get_node ( disconnect = disconnects ,
may_reconnect = True )
l1 . fundwallet ( 2000000 )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 20000 )
# They haven't forgotten each other.
assert l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) [ ' id ' ] == l2 . info [ ' id ' ]
assert l2 . rpc . getpeer ( l1 . info [ ' id ' ] ) [ ' id ' ] == l1 . info [ ' id ' ]
# Technically, this is async to fundchannel (and could reconnect first)
l1 . daemon . wait_for_logs ( [ ' sendrawtx exit 0 ' ,
' Peer has reconnected, state CHANNELD_AWAITING_LOCKIN ' ] )
l1 . bitcoin . generate_block ( 6 )
l1 . daemon . wait_for_log ( ' to CHANNELD_NORMAL ' )
l2 . daemon . wait_for_log ( ' to CHANNELD_NORMAL ' )
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_reconnect_openingd ( node_factory ) :
# Openingd thinks we're still opening; funder reconnects..
disconnects = [ ' 0WIRE_ACCEPT_CHANNEL ' ]
l1 = node_factory . get_node ( may_reconnect = True )
l2 = node_factory . get_node ( disconnect = disconnects ,
may_reconnect = True )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . fundwallet ( 2000000 )
# l2 closes on l1, l1 forgets.
with pytest . raises ( RpcError ) :
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 20000 )
assert l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) is None
# Reconnect.
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
2018-08-09 01:25:29 +01:00
# We should get a message about reconnecting.
l2 . daemon . wait_for_log ( ' Killing openingd: Reconnected ' )
l2 . daemon . wait_for_log ( ' lightning_openingd.*Handed peer, entering loop ' )
2018-08-03 16:29:38 +01:00
# Should work fine.
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 20000 )
l1 . daemon . wait_for_log ( ' sendrawtx exit 0 ' )
# Just to be sure, second openingd hand over to channeld.
openingd: take peer before we're opening, wait for explicit funding msg.
Prior to this, lightningd would hand uninteresting peers back to connectd,
which would then return it to lightningd if it sent a non-gossip msg,
or if lightningd asked it to release the peer.
Now connectd hands the peer to lightningd once we've done the init
handshake, which hands it off to openingd.
This is a deep structural change, so we do the minimum here and cleanup
in the following patches.
Lightningd:
1. Remove peer_nongossip handling from connect_control and peer_control.
2. Remove list of outstanding fundchannel command; it was only needed to
find the race between us asking connectd to release the peer and it
reconnecting.
3. We can no longer tell if the remote end has started trying to fund a
channel (until it has succeeded): it's very transitory anyway so not
worth fixing.
4. We now always have a struct peer, and allocate an uncommitted_channel
for it, though it may never be used if neither end funds a channel.
5. We start funding on messages for openingd: we can get a funder_reply
or a fundee, or an error in response to our request to fund a channel.
so we handle all of them.
6. A new peer_start_openingd() is called after connectd hands us a peer.
7. json_fund_channel just looks through local peers; there are none
hidden in connectd any more.
8. We sometimes start a new openingd just to send an error message.
Openingd:
1. We always have information we need to accept them funding a channel (in
the init message).
2. We have to listen for three fds: peer, gossip and master, so we opencode
the poll.
3. We have an explicit message to start trying to fund a channel.
4. We can be told to send a message in our init message.
Testing:
1. We don't handle some things gracefully yet, so two tests are disabled.
2. 'hand_back_peer .*: now local again' from connectd is no longer a message,
openingd says 'Handed peer, entering loop' once its managing it.
3. peer['state'] used to be set to 'GOSSIPING' (otherwise this field doesn't
exist; 'state' is now per-channel. It doesn't exist at all now.
4. Some tests now need to turn on IO logging in openingd, not connectd.
5. There's a gap between connecting on one node and having connectd on
the peer hand over the connection to openingd. Our tests sometimes
checked getpeers() on the peer, and didn't see anything, so line_graph
needed updating.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-08-08 15:10:58 +01:00
l2 . daemon . wait_for_log ( ' lightning_openingd.*UPDATE WIRE_OPENING_FUNDEE ' )
2018-08-03 16:29:38 +01:00
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_reconnect_normal ( node_factory ) :
# Should reconnect fine even if locked message gets lost.
disconnects = [ ' -WIRE_FUNDING_LOCKED ' ,
' @WIRE_FUNDING_LOCKED ' ,
' +WIRE_FUNDING_LOCKED ' ]
l1 = node_factory . get_node ( disconnect = disconnects ,
may_reconnect = True )
l2 = node_factory . get_node ( may_reconnect = True )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . fund_channel ( l2 , 10 * * 6 )
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_reconnect_sender_add1 ( node_factory ) :
# Fail after add is OK, will cause payment failure though.
disconnects = [ ' -WIRE_UPDATE_ADD_HTLC-nocommit ' ,
' +WIRE_UPDATE_ADD_HTLC-nocommit ' ,
' @WIRE_UPDATE_ADD_HTLC-nocommit ' ]
l1 = node_factory . get_node ( disconnect = disconnects ,
may_reconnect = True )
l2 = node_factory . get_node ( may_reconnect = True )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . fund_channel ( l2 , 10 * * 6 )
amt = 200000000
rhash = l2 . rpc . invoice ( amt , ' test_reconnect_sender_add1 ' , ' desc ' ) [ ' payment_hash ' ]
assert only_one ( l2 . rpc . listinvoices ( ' test_reconnect_sender_add1 ' ) [ ' invoices ' ] ) [ ' status ' ] == ' unpaid '
route = [ { ' msatoshi ' : amt , ' id ' : l2 . info [ ' id ' ] , ' delay ' : 5 , ' channel ' : ' 1:1:1 ' } ]
for i in range ( 0 , len ( disconnects ) ) :
l1 . rpc . sendpay ( route , rhash )
with pytest . raises ( RpcError ) :
l1 . rpc . waitsendpay ( rhash )
# Wait for reconnection.
l1 . daemon . wait_for_log ( ' Already have funding locked in ' )
# This will send commit, so will reconnect as required.
l1 . rpc . sendpay ( route , rhash )
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_reconnect_sender_add ( node_factory ) :
disconnects = [ ' -WIRE_COMMITMENT_SIGNED ' ,
' @WIRE_COMMITMENT_SIGNED ' ,
' +WIRE_COMMITMENT_SIGNED ' ,
' -WIRE_REVOKE_AND_ACK ' ,
' @WIRE_REVOKE_AND_ACK ' ,
' +WIRE_REVOKE_AND_ACK ' ]
l1 = node_factory . get_node ( disconnect = disconnects ,
may_reconnect = True )
l2 = node_factory . get_node ( may_reconnect = True )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . fund_channel ( l2 , 10 * * 6 )
amt = 200000000
rhash = l2 . rpc . invoice ( amt , ' testpayment ' , ' desc ' ) [ ' payment_hash ' ]
assert only_one ( l2 . rpc . listinvoices ( ' testpayment ' ) [ ' invoices ' ] ) [ ' status ' ] == ' unpaid '
route = [ { ' msatoshi ' : amt , ' id ' : l2 . info [ ' id ' ] , ' delay ' : 5 , ' channel ' : ' 1:1:1 ' } ]
# This will send commit, so will reconnect as required.
l1 . rpc . sendpay ( route , rhash )
# Should have printed this for every reconnect.
for i in range ( 0 , len ( disconnects ) ) :
l1 . daemon . wait_for_log ( ' Already have funding locked in ' )
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_reconnect_receiver_add ( node_factory ) :
disconnects = [ ' -WIRE_COMMITMENT_SIGNED ' ,
' @WIRE_COMMITMENT_SIGNED ' ,
' +WIRE_COMMITMENT_SIGNED ' ,
' -WIRE_REVOKE_AND_ACK ' ,
' @WIRE_REVOKE_AND_ACK ' ,
' +WIRE_REVOKE_AND_ACK ' ]
l1 = node_factory . get_node ( may_reconnect = True )
l2 = node_factory . get_node ( disconnect = disconnects ,
may_reconnect = True )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . fund_channel ( l2 , 10 * * 6 )
amt = 200000000
rhash = l2 . rpc . invoice ( amt , ' testpayment2 ' , ' desc ' ) [ ' payment_hash ' ]
assert only_one ( l2 . rpc . listinvoices ( ' testpayment2 ' ) [ ' invoices ' ] ) [ ' status ' ] == ' unpaid '
route = [ { ' msatoshi ' : amt , ' id ' : l2 . info [ ' id ' ] , ' delay ' : 5 , ' channel ' : ' 1:1:1 ' } ]
l1 . rpc . sendpay ( route , rhash )
for i in range ( len ( disconnects ) ) :
l1 . daemon . wait_for_log ( ' Already have funding locked in ' )
assert only_one ( l2 . rpc . listinvoices ( ' testpayment2 ' ) [ ' invoices ' ] ) [ ' status ' ] == ' paid '
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_reconnect_receiver_fulfill ( node_factory ) :
# Ordering matters: after +WIRE_UPDATE_FULFILL_HTLC, channeld
# will continue and try to send WIRE_COMMITMENT_SIGNED: if
# that's the next failure, it will do two in one run.
disconnects = [ ' @WIRE_UPDATE_FULFILL_HTLC ' ,
' +WIRE_UPDATE_FULFILL_HTLC ' ,
' -WIRE_UPDATE_FULFILL_HTLC ' ,
' -WIRE_COMMITMENT_SIGNED ' ,
' @WIRE_COMMITMENT_SIGNED ' ,
' +WIRE_COMMITMENT_SIGNED ' ,
' -WIRE_REVOKE_AND_ACK ' ,
' @WIRE_REVOKE_AND_ACK ' ,
' +WIRE_REVOKE_AND_ACK ' ]
l1 = node_factory . get_node ( may_reconnect = True )
l2 = node_factory . get_node ( disconnect = disconnects ,
may_reconnect = True )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . fund_channel ( l2 , 10 * * 6 )
amt = 200000000
rhash = l2 . rpc . invoice ( amt , ' testpayment2 ' , ' desc ' ) [ ' payment_hash ' ]
assert only_one ( l2 . rpc . listinvoices ( ' testpayment2 ' ) [ ' invoices ' ] ) [ ' status ' ] == ' unpaid '
route = [ { ' msatoshi ' : amt , ' id ' : l2 . info [ ' id ' ] , ' delay ' : 5 , ' channel ' : ' 1:1:1 ' } ]
l1 . rpc . sendpay ( route , rhash )
for i in range ( len ( disconnects ) ) :
l1 . daemon . wait_for_log ( ' Already have funding locked in ' )
assert only_one ( l2 . rpc . listinvoices ( ' testpayment2 ' ) [ ' invoices ' ] ) [ ' status ' ] == ' paid '
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_shutdown_reconnect ( node_factory ) :
disconnects = [ ' -WIRE_SHUTDOWN ' ,
' @WIRE_SHUTDOWN ' ,
' +WIRE_SHUTDOWN ' ]
l1 = node_factory . get_node ( disconnect = disconnects ,
may_reconnect = True )
l2 = node_factory . get_node ( may_reconnect = True )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
chan = l1 . fund_channel ( l2 , 10 * * 6 )
l1 . pay ( l2 , 200000000 )
assert l1 . bitcoin . rpc . getmempoolinfo ( ) [ ' size ' ] == 0
# This should return with an error, then close.
with pytest . raises ( RpcError , match = r ' Channel close negotiation not finished ' ) :
l1 . rpc . close ( chan , False , 0 )
l1 . daemon . wait_for_log ( ' to CHANNELD_SHUTTING_DOWN ' )
l2 . daemon . wait_for_log ( ' to CHANNELD_SHUTTING_DOWN ' )
l1 . daemon . wait_for_log ( ' to CLOSINGD_SIGEXCHANGE ' )
l2 . daemon . wait_for_log ( ' to CLOSINGD_SIGEXCHANGE ' )
# And should put closing into mempool (happens async, so
# CLOSINGD_COMPLETE may come first).
l1 . daemon . wait_for_logs ( [ ' sendrawtx exit 0 ' , ' to CLOSINGD_COMPLETE ' ] )
l2 . daemon . wait_for_logs ( [ ' sendrawtx exit 0 ' , ' to CLOSINGD_COMPLETE ' ] )
assert l1 . bitcoin . rpc . getmempoolinfo ( ) [ ' size ' ] == 1
def test_shutdown_awaiting_lockin ( node_factory , bitcoind ) :
l1 = node_factory . get_node ( )
l2 = node_factory . get_node ( options = { ' funding-confirms ' : 3 } )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . fundwallet ( 10 * * 6 + 1000000 )
chanid = l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 10 * * 6 ) [ ' channel_id ' ]
# Technically, this is async to fundchannel.
l1 . daemon . wait_for_log ( ' sendrawtx exit 0 ' )
bitcoind . generate_block ( 1 )
# This should return with an error, then close.
with pytest . raises ( RpcError , match = r ' Channel close negotiation not finished ' ) :
l1 . rpc . close ( chanid , False , 0 )
l1 . daemon . wait_for_log ( ' CHANNELD_AWAITING_LOCKIN to CHANNELD_SHUTTING_DOWN ' )
l2 . daemon . wait_for_log ( ' CHANNELD_AWAITING_LOCKIN to CHANNELD_SHUTTING_DOWN ' )
l1 . daemon . wait_for_log ( ' CHANNELD_SHUTTING_DOWN to CLOSINGD_SIGEXCHANGE ' )
l2 . daemon . wait_for_log ( ' CHANNELD_SHUTTING_DOWN to CLOSINGD_SIGEXCHANGE ' )
# And should put closing into mempool (happens async, so
# CLOSINGD_COMPLETE may come first).
l1 . daemon . wait_for_logs ( [ ' sendrawtx exit 0 ' , ' to CLOSINGD_COMPLETE ' ] )
l2 . daemon . wait_for_logs ( [ ' sendrawtx exit 0 ' , ' to CLOSINGD_COMPLETE ' ] )
assert bitcoind . rpc . getmempoolinfo ( ) [ ' size ' ] == 1
bitcoind . generate_block ( 1 )
l1 . daemon . wait_for_log ( ' to ONCHAIN ' )
l2 . daemon . wait_for_log ( ' to ONCHAIN ' )
bitcoind . generate_block ( 100 )
wait_for ( lambda : l1 . rpc . listpeers ( ) [ ' peers ' ] == [ ] )
wait_for ( lambda : l2 . rpc . listpeers ( ) [ ' peers ' ] == [ ] )
def test_funding_change ( node_factory , bitcoind ) :
""" Add some funds, fund a channel, and make sure we remember the change
"""
l1 , l2 = node_factory . line_graph ( 2 , fundchannel = False )
l1 . fundwallet ( 10000000 )
bitcoind . generate_block ( 1 )
sync_blockheight ( bitcoind , [ l1 ] )
outputs = l1 . db_query ( ' SELECT value FROM outputs WHERE status=0; ' )
assert only_one ( outputs ) [ ' value ' ] == 10000000
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 1000000 )
outputs = { r [ ' status ' ] : r [ ' value ' ] for r in l1 . db_query (
' SELECT status, SUM(value) AS value FROM outputs GROUP BY status; ' ) }
# The 10m out is spent and we have a change output of 9m-fee
assert outputs [ 0 ] > 8990000
assert outputs [ 2 ] == 10000000
def test_funding_all ( node_factory , bitcoind ) :
""" Add some funds, fund a channel using all funds, make sure no funds remain
"""
l1 , l2 = node_factory . line_graph ( 2 , fundchannel = False )
l1 . fundwallet ( 0.1 * 10 * * 8 )
bitcoind . generate_block ( 1 )
sync_blockheight ( bitcoind , [ l1 ] )
outputs = l1 . db_query ( ' SELECT value FROM outputs WHERE status=0; ' )
assert only_one ( outputs ) [ ' value ' ] == 10000000
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , " all " )
outputs = l1 . db_query ( ' SELECT value FROM outputs WHERE status=0; ' )
assert len ( outputs ) == 0
def test_funding_all_too_much ( node_factory ) :
""" Add more than max possible funds, fund a channel using all funds we can.
"""
l1 , l2 = node_factory . line_graph ( 2 , fundchannel = False )
l1 . fundwallet ( 2 * * 24 + 10000 )
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , " all " )
assert only_one ( l1 . rpc . listfunds ( ) [ ' outputs ' ] ) [ ' status ' ] == ' unconfirmed '
assert only_one ( l1 . rpc . listfunds ( ) [ ' channels ' ] ) [ ' channel_total_sat ' ] == 2 * * 24 - 1
def test_funding_fail ( node_factory , bitcoind ) :
""" Add some funds, fund a channel without enough funds """
# Previous runs with same bitcoind can leave funds!
max_locktime = 5 * 6 * 24
l1 = node_factory . get_node ( random_hsm = True , options = { ' max-locktime-blocks ' : max_locktime } )
l2 = node_factory . get_node ( options = { ' watchtime-blocks ' : max_locktime + 1 } )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
funds = 1000000
addr = l1 . rpc . newaddr ( ) [ ' address ' ]
l1 . bitcoin . rpc . sendtoaddress ( addr , funds / 10 * * 8 )
bitcoind . generate_block ( 1 )
# Wait for it to arrive.
wait_for ( lambda : len ( l1 . rpc . listfunds ( ) [ ' outputs ' ] ) > 0 )
# Fail because l1 dislikes l2's huge locktime.
with pytest . raises ( RpcError , match = r ' to_self_delay \ d+ larger than \ d+ ' ) :
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , int ( funds / 10 ) )
assert only_one ( l1 . rpc . listpeers ( ) [ ' peers ' ] ) [ ' connected ' ]
assert only_one ( l2 . rpc . listpeers ( ) [ ' peers ' ] ) [ ' connected ' ]
# Restart l2 without ridiculous locktime.
del l2 . daemon . opts [ ' watchtime-blocks ' ]
l2 . restart ( )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
# We don't have enough left to cover fees if we try to spend it all.
with pytest . raises ( RpcError , match = r ' Cannot afford transaction ' ) :
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , funds )
# Should still be connected.
assert only_one ( l1 . rpc . listpeers ( ) [ ' peers ' ] ) [ ' connected ' ]
2018-08-09 01:25:29 +01:00
l2 . daemon . wait_for_log ( ' lightning_openingd-.*: Handed peer, entering loop ' )
2018-08-03 16:29:38 +01:00
assert only_one ( l2 . rpc . listpeers ( ) [ ' peers ' ] ) [ ' connected ' ]
# This works.
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , int ( funds / 10 ) )
def test_funding_toolarge ( node_factory , bitcoind ) :
""" Try to create a giant channel """
l1 = node_factory . get_node ( )
l2 = node_factory . get_node ( )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
# Send funds.
amount = 2 * * 24
bitcoind . rpc . sendtoaddress ( l1 . rpc . newaddr ( ) [ ' address ' ] , amount / 10 * * 8 + 0.01 )
bitcoind . generate_block ( 1 )
# Wait for it to arrive.
wait_for ( lambda : len ( l1 . rpc . listfunds ( ) [ ' outputs ' ] ) > 0 )
# Fail to open (too large)
with pytest . raises ( RpcError , match = r ' Amount exceeded 16777215 ' ) :
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , amount )
# This should work.
amount = amount - 1
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , amount )
def test_lockin_between_restart ( node_factory , bitcoind ) :
l1 = node_factory . get_node ( may_reconnect = True )
l2 = node_factory . get_node ( options = { ' funding-confirms ' : 3 } ,
may_reconnect = True )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . fundwallet ( 10 * * 6 + 1000000 )
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 10 * * 6 ) [ ' tx ' ]
# l1 goes down.
l1 . stop ( )
# Now 120 blocks go by...
bitcoind . generate_block ( 120 )
# Restart
l1 . start ( )
# All should be good.
l1 . daemon . wait_for_log ( ' to CHANNELD_NORMAL ' )
l2 . daemon . wait_for_log ( ' to CHANNELD_NORMAL ' )
def test_funding_while_offline ( node_factory , bitcoind ) :
l1 = node_factory . get_node ( )
addr = l1 . rpc . newaddr ( ) [ ' address ' ]
sync_blockheight ( bitcoind , [ l1 ] )
# l1 goes down.
l1 . stop ( )
# We send funds
bitcoind . rpc . sendtoaddress ( addr , ( 10 * * 6 + 1000000 ) / 10 * * 8 )
# Now 120 blocks go by...
bitcoind . generate_block ( 120 )
# Restart
l1 . start ( )
sync_blockheight ( bitcoind , [ l1 ] )
assert len ( l1 . rpc . listfunds ( ) [ ' outputs ' ] ) == 1
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_channel_persistence ( node_factory , bitcoind , executor ) :
# Start two nodes and open a channel (to remember). l2 will
# mysteriously die while committing the first HTLC so we can
# check that HTLCs reloaded from the DB work.
l1 = node_factory . get_node ( may_reconnect = True )
l2 = node_factory . get_node ( disconnect = [ ' =WIRE_COMMITMENT_SIGNED-nocommit ' ] ,
may_reconnect = True )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
# Neither node should have a channel open, they are just connected
for n in ( l1 , l2 ) :
assert ( n . db_query ( ' SELECT COUNT(id) as count FROM channels; ' ) [ 0 ] [ ' count ' ] == 0 )
l1 . fund_channel ( l2 , 100000 )
peers = l1 . rpc . listpeers ( ) [ ' peers ' ]
assert ( only_one ( peers [ 0 ] [ ' channels ' ] ) [ ' state ' ] == ' CHANNELD_NORMAL ' )
# Both nodes should now have exactly one channel in the database
for n in ( l1 , l2 ) :
assert ( n . db_query ( ' SELECT COUNT(id) as count FROM channels; ' ) [ 0 ] [ ' count ' ] == 1 )
# Fire off a sendpay request, it'll get interrupted by a restart
executor . submit ( l1 . pay , l2 , 10000 )
# Wait for it to be committed to, i.e., stored in the DB
l1 . daemon . wait_for_log ( ' peer_in WIRE_COMMITMENT_SIGNED ' )
# Stop l2, l1 will reattempt to connect
print ( " Killing l2 in mid HTLC " )
l2 . daemon . kill ( )
# Clear the disconnect and timer stop so we can proceed normally
del l2 . daemon . opts [ ' dev-disconnect ' ]
# Wait for l1 to notice
wait_for ( lambda : ' connected ' not in only_one ( l1 . rpc . listpeers ( ) [ ' peers ' ] [ 0 ] [ ' channels ' ] ) )
# Now restart l2 and it should reload peers/channels from the DB
l2 . start ( )
wait_for ( lambda : len ( l2 . rpc . listpeers ( ) [ ' peers ' ] ) == 1 )
# Wait for the restored HTLC to finish
wait_for ( lambda : only_one ( l1 . rpc . listpeers ( ) [ ' peers ' ] [ 0 ] [ ' channels ' ] ) [ ' msatoshi_to_us ' ] == 99990000 , interval = 1 )
wait_for ( lambda : len ( [ p for p in l1 . rpc . listpeers ( ) [ ' peers ' ] if p [ ' connected ' ] ] ) , interval = 1 )
wait_for ( lambda : len ( [ p for p in l2 . rpc . listpeers ( ) [ ' peers ' ] if p [ ' connected ' ] ] ) , interval = 1 )
# Now make sure this is really functional by sending a payment
l1 . pay ( l2 , 10000 )
# L1 doesn't actually update msatoshi_to_us until it receives
# revoke_and_ack from L2, which can take a little bit.
wait_for ( lambda : only_one ( l1 . rpc . listpeers ( ) [ ' peers ' ] [ 0 ] [ ' channels ' ] ) [ ' msatoshi_to_us ' ] == 99980000 )
assert only_one ( l2 . rpc . listpeers ( ) [ ' peers ' ] [ 0 ] [ ' channels ' ] ) [ ' msatoshi_to_us ' ] == 20000
# Finally restart l1, and make sure it remembers
l1 . restart ( )
assert only_one ( l1 . rpc . listpeers ( ) [ ' peers ' ] [ 0 ] [ ' channels ' ] ) [ ' msatoshi_to_us ' ] == 99980000
# Now make sure l1 is watching for unilateral closes
l2 . rpc . dev_fail ( l1 . info [ ' id ' ] )
l2 . daemon . wait_for_log ( ' Failing due to dev-fail command ' )
l2 . daemon . wait_for_log ( ' sendrawtx exit 0 ' )
bitcoind . generate_block ( 1 )
# L1 must notice.
l1 . daemon . wait_for_log ( ' to ONCHAIN ' )
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 for --dev-broadcast-interval " )
def test_channel_reenable ( node_factory ) :
l1 , l2 = node_factory . line_graph ( 2 , opts = { ' may_reconnect ' : True } , fundchannel = True , announce = True )
l1 . daemon . wait_for_log ( ' Received node_announcement for node {} ' . format ( l2 . info [ ' id ' ] ) )
l2 . daemon . wait_for_log ( ' Received node_announcement for node {} ' . format ( l1 . info [ ' id ' ] ) )
# Both directions should be active before the restart
wait_for ( lambda : [ c [ ' active ' ] for c in l1 . rpc . listchannels ( ) [ ' channels ' ] ] == [ True , True ] )
# Restart l2, will cause l1 to reconnect
l2 . restart ( )
# Now they should sync and re-establish again
l1 . daemon . wait_for_logs ( [ ' Received channel_update for channel \\ d+:1:1.1. ' ,
' Received channel_update for channel \\ d+:1:1.0. ' ] )
l2 . daemon . wait_for_logs ( [ ' Received channel_update for channel \\ d+:1:1.1. ' ,
' Received channel_update for channel \\ d+:1:1.0. ' ] )
wait_for ( lambda : [ c [ ' active ' ] for c in l1 . rpc . listchannels ( ) [ ' channels ' ] ] == [ True , True ] )
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_update_fee ( node_factory , bitcoind ) :
l1 , l2 = node_factory . line_graph ( 2 , fundchannel = True )
chanid = l1 . get_channel_scid ( l2 )
# Make l1 send out feechange.
l1 . rpc . dev_setfees ( ' 14000 ' )
l2 . daemon . wait_for_log ( ' peer updated fee to 14000 ' )
# Now make sure an HTLC works.
# (First wait for route propagation.)
l1 . wait_channel_active ( chanid )
sync_blockheight ( bitcoind , [ l1 , l2 ] )
# Make payments.
l1 . pay ( l2 , 200000000 )
l2 . pay ( l1 , 100000000 )
# Now shutdown cleanly.
with pytest . raises ( RpcError , match = r ' Channel close negotiation not finished ' ) :
l1 . rpc . close ( chanid , False , 0 )
l1 . daemon . wait_for_log ( ' to CLOSINGD_COMPLETE ' )
l2 . daemon . wait_for_log ( ' to CLOSINGD_COMPLETE ' )
# And should put closing into mempool.
l1 . daemon . wait_for_log ( ' sendrawtx exit 0 ' )
l2 . daemon . wait_for_log ( ' sendrawtx exit 0 ' )
bitcoind . generate_block ( 1 )
l1 . daemon . wait_for_log ( ' to ONCHAIN ' )
l2 . daemon . wait_for_log ( ' to ONCHAIN ' )
bitcoind . generate_block ( 99 )
l1 . daemon . wait_for_log ( ' onchaind complete, forgetting peer ' )
l2 . daemon . wait_for_log ( ' onchaind complete, forgetting peer ' )
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_update_all_fees ( node_factory ) :
l1 , l2 = node_factory . line_graph ( 2 , fundchannel = True )
# Set all fees as positional parameters.
l1 . rpc . dev_setfees ( ' 12345 ' , ' 6789 ' , ' 123 ' )
l1 . daemon . wait_for_log ( ' dev-setfees: fees now 12345/6789/123 ' )
l2 . daemon . wait_for_log ( ' peer updated fee to 12345 ' )
# Call setfees with fees passed as named parameters in different order.
l1 . rpc . dev_setfees ( slow = ' 123 ' , normal = ' 4567 ' , immediate = ' 8901 ' )
l1 . daemon . wait_for_log ( ' dev-setfees: fees now 8901/4567/123 ' )
l2 . daemon . wait_for_log ( ' peer updated fee to 8901 ' )
# Set one value at a time.
l1 . rpc . dev_setfees ( slow = ' 321 ' )
l1 . daemon . wait_for_log ( ' dev-setfees: fees now 8901/4567/321 ' )
l1 . rpc . dev_setfees ( normal = ' 7654 ' )
l1 . daemon . wait_for_log ( ' dev-setfees: fees now 8901/7654/321 ' )
l1 . rpc . dev_setfees ( immediate = ' 21098 ' )
l1 . daemon . wait_for_log ( ' dev-setfees: fees now 21098/7654/321 ' )
l2 . daemon . wait_for_log ( ' peer updated fee to 21098 ' )
# Verify that all fees are indeed optional in setfees call.
l1 . rpc . dev_setfees ( )
l1 . daemon . wait_for_log ( ' dev-setfees: fees now 21098/7654/321 ' )
# This should return finish closing.
l1 . rpc . close ( l1 . get_channel_scid ( l2 ) )
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_fee_limits ( node_factory ) :
# FIXME: Test case where opening denied.
l1 , l2 = node_factory . line_graph ( 2 , opts = { ' dev-max-fee-multiplier ' : 5 } , fundchannel = True )
# L1 asks for stupid low fees
l1 . rpc . dev_setfees ( 15 )
l1 . daemon . wait_for_log ( ' Peer permanent failure in CHANNELD_NORMAL: lightning_channeld: received ERROR channel .*: update_fee 15 outside range 1875-75000 ' )
# Make sure the resolution of this one doesn't interfere with the next!
# Note: may succeed, may fail with insufficient fee, depending on how
# bitcoind feels!
l1 . daemon . wait_for_log ( ' sendrawtx exit ' )
# Restore to normal.
l1 . rpc . dev_setfees ( 15000 )
# Try with node which sets --ignore-fee-limits
l3 = node_factory . get_node ( options = { ' ignore-fee-limits ' : ' true ' } )
l1 . rpc . connect ( l3 . info [ ' id ' ] , ' localhost ' , l3 . port )
chan = l1 . fund_channel ( l3 , 10 * * 6 )
# Try stupid high fees
l1 . rpc . dev_setfees ( 15000 * 10 )
l3 . daemon . wait_for_log ( ' peer_in WIRE_UPDATE_FEE ' )
l3 . daemon . wait_for_log ( ' peer_in WIRE_COMMITMENT_SIGNED ' )
# We need to wait until both have committed and revoked the
# old state, otherwise we'll still try to commit with the old
# 15sat/byte fee
l1 . daemon . wait_for_log ( ' peer_out WIRE_REVOKE_AND_ACK ' )
# This should wait for close to complete
l1 . rpc . close ( chan )
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_update_fee_reconnect ( node_factory , bitcoind ) :
# Disconnect after first commitsig.
disconnects = [ ' +WIRE_COMMITMENT_SIGNED ' ]
l1 = node_factory . get_node ( disconnect = disconnects , may_reconnect = True )
l2 = node_factory . get_node ( may_reconnect = True )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
chan = l1 . fund_channel ( l2 , 10 * * 6 )
# Make l1 send out feechange; triggers disconnect/reconnect.
l1 . rpc . dev_setfees ( ' 14000 ' )
l1 . daemon . wait_for_log ( ' Setting REMOTE feerate to 14000 ' )
l2 . daemon . wait_for_log ( ' Setting LOCAL feerate to 14000 ' )
l1 . daemon . wait_for_log ( ' dev_disconnect: \ +WIRE_COMMITMENT_SIGNED ' )
# Wait for reconnect....
l1 . daemon . wait_for_log ( ' Applying feerate 14000 to LOCAL ' )
l1 . pay ( l2 , 200000000 )
l2 . pay ( l1 , 100000000 )
# They should both have gotten commits with correct feerate.
assert l1 . daemon . is_in_log ( ' got commitsig [0-9]*: feerate 14000 ' )
assert l2 . daemon . is_in_log ( ' got commitsig [0-9]*: feerate 14000 ' )
# Now shutdown cleanly.
l1 . rpc . close ( chan )
# And should put closing into mempool.
l1 . daemon . wait_for_log ( ' sendrawtx exit 0 ' )
l2 . daemon . wait_for_log ( ' sendrawtx exit 0 ' )
bitcoind . generate_block ( 1 )
l1 . daemon . wait_for_log ( ' to ONCHAIN ' )
l2 . daemon . wait_for_log ( ' to ONCHAIN ' )
bitcoind . generate_block ( 99 )
l1 . daemon . wait_for_log ( ' onchaind complete, forgetting peer ' )
l2 . daemon . wait_for_log ( ' onchaind complete, forgetting peer ' )
@unittest.skipIf ( not DEVELOPER , " Too slow without --dev-bitcoind-poll " )
def test_multiple_channels ( node_factory ) :
l1 = node_factory . get_node ( )
l2 = node_factory . get_node ( )
for i in range ( 3 ) :
# FIXME: we shouldn't disconnect on close?
ret = l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
assert ret [ ' id ' ] == l2 . info [ ' id ' ]
openingd: take peer before we're opening, wait for explicit funding msg.
Prior to this, lightningd would hand uninteresting peers back to connectd,
which would then return it to lightningd if it sent a non-gossip msg,
or if lightningd asked it to release the peer.
Now connectd hands the peer to lightningd once we've done the init
handshake, which hands it off to openingd.
This is a deep structural change, so we do the minimum here and cleanup
in the following patches.
Lightningd:
1. Remove peer_nongossip handling from connect_control and peer_control.
2. Remove list of outstanding fundchannel command; it was only needed to
find the race between us asking connectd to release the peer and it
reconnecting.
3. We can no longer tell if the remote end has started trying to fund a
channel (until it has succeeded): it's very transitory anyway so not
worth fixing.
4. We now always have a struct peer, and allocate an uncommitted_channel
for it, though it may never be used if neither end funds a channel.
5. We start funding on messages for openingd: we can get a funder_reply
or a fundee, or an error in response to our request to fund a channel.
so we handle all of them.
6. A new peer_start_openingd() is called after connectd hands us a peer.
7. json_fund_channel just looks through local peers; there are none
hidden in connectd any more.
8. We sometimes start a new openingd just to send an error message.
Openingd:
1. We always have information we need to accept them funding a channel (in
the init message).
2. We have to listen for three fds: peer, gossip and master, so we opencode
the poll.
3. We have an explicit message to start trying to fund a channel.
4. We can be told to send a message in our init message.
Testing:
1. We don't handle some things gracefully yet, so two tests are disabled.
2. 'hand_back_peer .*: now local again' from connectd is no longer a message,
openingd says 'Handed peer, entering loop' once its managing it.
3. peer['state'] used to be set to 'GOSSIPING' (otherwise this field doesn't
exist; 'state' is now per-channel. It doesn't exist at all now.
4. Some tests now need to turn on IO logging in openingd, not connectd.
5. There's a gap between connecting on one node and having connectd on
the peer hand over the connection to openingd. Our tests sometimes
checked getpeers() on the peer, and didn't see anything, so line_graph
needed updating.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-08-08 15:10:58 +01:00
l1 . daemon . wait_for_log ( ' openingd-.*: Handed peer, entering loop ' )
l2 . daemon . wait_for_log ( ' openingd-.*: Handed peer, entering loop ' )
2018-08-03 16:29:38 +01:00
chan = l1 . fund_channel ( l2 , 10 * * 6 )
l1 . rpc . close ( chan )
channels = only_one ( l1 . rpc . listpeers ( ) [ ' peers ' ] ) [ ' channels ' ]
assert len ( channels ) == 3
# Most in state ONCHAIN, last is CLOSINGD_COMPLETE
for i in range ( len ( channels ) - 1 ) :
assert channels [ i ] [ ' state ' ] == ' ONCHAIN '
assert channels [ - 1 ] [ ' state ' ] == ' CLOSINGD_COMPLETE '
@unittest.skipIf ( not DEVELOPER , " needs DEVELOPER=1 " )
def test_forget_channel ( node_factory ) :
l1 = node_factory . get_node ( )
l2 = node_factory . get_node ( )
l1 . fundwallet ( 10 * * 6 )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 10 * * 5 )
assert len ( l1 . rpc . listpeers ( ) [ ' peers ' ] ) == 1
# This should fail, the funding tx is in the mempool and may confirm
with pytest . raises ( RpcError , match = r ' Cowardly refusing to forget channel ' ) :
l1 . rpc . dev_forget_channel ( l2 . info [ ' id ' ] )
assert len ( l1 . rpc . listpeers ( ) [ ' peers ' ] ) == 1
# Forcing should work
l1 . rpc . dev_forget_channel ( l2 . info [ ' id ' ] , True )
assert len ( l1 . rpc . listpeers ( ) [ ' peers ' ] ) == 0
# And restarting should keep that peer forgotten
l1 . restart ( )
assert len ( l1 . rpc . listpeers ( ) [ ' peers ' ] ) == 0
def test_peerinfo ( node_factory , bitcoind ) :
l1 , l2 = node_factory . line_graph ( 2 , fundchannel = False )
# Gossiping but no node announcement yet
openingd: take peer before we're opening, wait for explicit funding msg.
Prior to this, lightningd would hand uninteresting peers back to connectd,
which would then return it to lightningd if it sent a non-gossip msg,
or if lightningd asked it to release the peer.
Now connectd hands the peer to lightningd once we've done the init
handshake, which hands it off to openingd.
This is a deep structural change, so we do the minimum here and cleanup
in the following patches.
Lightningd:
1. Remove peer_nongossip handling from connect_control and peer_control.
2. Remove list of outstanding fundchannel command; it was only needed to
find the race between us asking connectd to release the peer and it
reconnecting.
3. We can no longer tell if the remote end has started trying to fund a
channel (until it has succeeded): it's very transitory anyway so not
worth fixing.
4. We now always have a struct peer, and allocate an uncommitted_channel
for it, though it may never be used if neither end funds a channel.
5. We start funding on messages for openingd: we can get a funder_reply
or a fundee, or an error in response to our request to fund a channel.
so we handle all of them.
6. A new peer_start_openingd() is called after connectd hands us a peer.
7. json_fund_channel just looks through local peers; there are none
hidden in connectd any more.
8. We sometimes start a new openingd just to send an error message.
Openingd:
1. We always have information we need to accept them funding a channel (in
the init message).
2. We have to listen for three fds: peer, gossip and master, so we opencode
the poll.
3. We have an explicit message to start trying to fund a channel.
4. We can be told to send a message in our init message.
Testing:
1. We don't handle some things gracefully yet, so two tests are disabled.
2. 'hand_back_peer .*: now local again' from connectd is no longer a message,
openingd says 'Handed peer, entering loop' once its managing it.
3. peer['state'] used to be set to 'GOSSIPING' (otherwise this field doesn't
exist; 'state' is now per-channel. It doesn't exist at all now.
4. Some tests now need to turn on IO logging in openingd, not connectd.
5. There's a gap between connecting on one node and having connectd on
the peer hand over the connection to openingd. Our tests sometimes
checked getpeers() on the peer, and didn't see anything, so line_graph
needed updating.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-08-08 15:10:58 +01:00
assert l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) [ ' connected ' ]
assert len ( l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) [ ' channels ' ] ) == 0
2018-08-03 16:29:38 +01:00
assert l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) [ ' local_features ' ] == ' 88 '
assert l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) [ ' global_features ' ] == ' '
# Fund a channel to force a node announcement
chan = l1 . fund_channel ( l2 , 10 * * 6 )
# Now proceed to funding-depth and do a full gossip round
bitcoind . generate_block ( 5 )
l1 . daemon . wait_for_logs ( [ ' Received node_announcement for node ' + l2 . info [ ' id ' ] ] )
l2 . daemon . wait_for_logs ( [ ' Received node_announcement for node ' + l1 . info [ ' id ' ] ] )
# Should have announced the same global features as told to peer.
nodes1 = l1 . rpc . listnodes ( l2 . info [ ' id ' ] ) [ ' nodes ' ]
nodes2 = l2 . rpc . listnodes ( l2 . info [ ' id ' ] ) [ ' nodes ' ]
peer1 = l1 . rpc . getpeer ( l2 . info [ ' id ' ] )
peer2 = l2 . rpc . getpeer ( l1 . info [ ' id ' ] )
assert only_one ( nodes1 ) [ ' global_features ' ] == peer1 [ ' global_features ' ]
assert only_one ( nodes2 ) [ ' global_features ' ] == peer2 [ ' global_features ' ]
# Close the channel to forget the peer
with pytest . raises ( RpcError , match = r ' Channel close negotiation not finished ' ) :
l1 . rpc . close ( chan , False , 0 )
2018-08-09 01:25:29 +01:00
l1 . daemon . wait_for_log ( ' Forgetting peer ' )
2018-08-03 16:29:38 +01:00
bitcoind . generate_block ( 100 )
l1 . daemon . wait_for_log ( ' WIRE_ONCHAIN_ALL_IRREVOCABLY_RESOLVED ' )
l2 . daemon . wait_for_log ( ' WIRE_ONCHAIN_ALL_IRREVOCABLY_RESOLVED ' )
# The only channel was closed, everybody should have forgotten the nodes
assert l1 . rpc . listnodes ( ) [ ' nodes ' ] == [ ]
assert l2 . rpc . listnodes ( ) [ ' nodes ' ] == [ ]
def test_disconnectpeer ( node_factory , bitcoind ) :
l1 , l2 , l3 = node_factory . get_nodes ( 3 , opts = { ' may_reconnect ' : False } )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
l1 . rpc . connect ( l3 . info [ ' id ' ] , ' localhost ' , l3 . port )
# Gossiping
openingd: take peer before we're opening, wait for explicit funding msg.
Prior to this, lightningd would hand uninteresting peers back to connectd,
which would then return it to lightningd if it sent a non-gossip msg,
or if lightningd asked it to release the peer.
Now connectd hands the peer to lightningd once we've done the init
handshake, which hands it off to openingd.
This is a deep structural change, so we do the minimum here and cleanup
in the following patches.
Lightningd:
1. Remove peer_nongossip handling from connect_control and peer_control.
2. Remove list of outstanding fundchannel command; it was only needed to
find the race between us asking connectd to release the peer and it
reconnecting.
3. We can no longer tell if the remote end has started trying to fund a
channel (until it has succeeded): it's very transitory anyway so not
worth fixing.
4. We now always have a struct peer, and allocate an uncommitted_channel
for it, though it may never be used if neither end funds a channel.
5. We start funding on messages for openingd: we can get a funder_reply
or a fundee, or an error in response to our request to fund a channel.
so we handle all of them.
6. A new peer_start_openingd() is called after connectd hands us a peer.
7. json_fund_channel just looks through local peers; there are none
hidden in connectd any more.
8. We sometimes start a new openingd just to send an error message.
Openingd:
1. We always have information we need to accept them funding a channel (in
the init message).
2. We have to listen for three fds: peer, gossip and master, so we opencode
the poll.
3. We have an explicit message to start trying to fund a channel.
4. We can be told to send a message in our init message.
Testing:
1. We don't handle some things gracefully yet, so two tests are disabled.
2. 'hand_back_peer .*: now local again' from connectd is no longer a message,
openingd says 'Handed peer, entering loop' once its managing it.
3. peer['state'] used to be set to 'GOSSIPING' (otherwise this field doesn't
exist; 'state' is now per-channel. It doesn't exist at all now.
4. Some tests now need to turn on IO logging in openingd, not connectd.
5. There's a gap between connecting on one node and having connectd on
the peer hand over the connection to openingd. Our tests sometimes
checked getpeers() on the peer, and didn't see anything, so line_graph
needed updating.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-08-08 15:10:58 +01:00
assert l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) [ ' connected ' ]
assert len ( l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) [ ' channels ' ] ) == 0
assert l1 . rpc . getpeer ( l3 . info [ ' id ' ] ) [ ' connected ' ]
assert len ( l1 . rpc . getpeer ( l3 . info [ ' id ' ] ) [ ' channels ' ] ) == 0
2018-08-09 01:25:19 +01:00
wait_for ( lambda : l2 . rpc . getpeer ( l1 . info [ ' id ' ] ) is not None )
2018-08-03 16:29:38 +01:00
# Disconnect l2 from l1
l1 . rpc . disconnect ( l2 . info [ ' id ' ] )
# Make sure listpeers no longer returns the disconnected node
assert l1 . rpc . getpeer ( l2 . info [ ' id ' ] ) is None
2018-08-09 01:25:19 +01:00
wait_for ( lambda : l2 . rpc . getpeer ( l1 . info [ ' id ' ] ) is None )
2018-08-03 16:29:38 +01:00
# Make sure you cannot disconnect after disconnecting
with pytest . raises ( RpcError , match = r ' Peer not connected ' ) :
l1 . rpc . disconnect ( l2 . info [ ' id ' ] )
with pytest . raises ( RpcError , match = r ' Peer not connected ' ) :
l2 . rpc . disconnect ( l1 . info [ ' id ' ] )
# Fund channel l1 -> l3
l1 . fund_channel ( l3 , 10 * * 6 )
bitcoind . generate_block ( 5 )
# disconnecting a non gossiping peer results in error
2018-08-09 01:25:29 +01:00
with pytest . raises ( RpcError , match = r ' Peer is in state CHANNELD_NORMAL ' ) :
2018-08-03 16:29:38 +01:00
l1 . rpc . disconnect ( l3 . info [ ' id ' ] )
@unittest.skipIf ( not DEVELOPER , " needs --dev-max-funding-unconfirmed-blocks " )
def test_fundee_forget_funding_tx_unconfirmed ( node_factory , bitcoind ) :
""" Test that fundee will forget the channel if
the funding tx has been unconfirmed for too long .
"""
# Keep this low (default is 2016), since everything
# is much slower in VALGRIND mode and wait_for_log
# could time out before lightningd processes all the
# blocks.
blocks = 200
# funder
l1 = node_factory . get_node ( fake_bitcoin_cli = True )
# fundee
l2 = node_factory . get_node ( options = { " dev-max-funding-unconfirmed-blocks " : blocks } )
l1 . rpc . connect ( l2 . info [ ' id ' ] , ' localhost ' , l2 . port )
# Give funder some funds.
l1 . fundwallet ( 10 * * 7 )
# Let blocks settle.
time . sleep ( 1 )
# Prevent funder from broadcasting funding tx.
l1 . fake_bitcoind_fail ( 1 )
# Fund the channel.
# The process will complete, but funder will be unable
# to broadcast and confirm funding tx.
l1 . rpc . fundchannel ( l2 . info [ ' id ' ] , 10 * * 6 )
# Prevent l1 from timing out bitcoin-cli.
l1 . fake_bitcoind_unfail ( )
# Generate blocks until unconfirmed.
bitcoind . generate_block ( blocks )
# fundee will forget channel!
l2 . daemon . wait_for_log ( ' Forgetting channel: It has been {} blocks ' . format ( blocks ) )
# fundee will also forget and disconnect from peer.
assert len ( l2 . rpc . listpeers ( l1 . info [ ' id ' ] ) [ ' peers ' ] ) == 0
