From 2765939adb5df27876395d96694b37af048df429 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Tue, 12 Sep 2023 10:22:44 +0930 Subject: [PATCH] runes: fix weird unnecessary zero-test. This seems to be a cut & paste bug (mine, AFAICT!) from the command code: ``` rune = rune_derive_start(cmd, master_rune, tal_fmt(tmpctx, "%"PRIu64, rune_counter ? *rune_counter : 0)); ``` In that case, rune_counter was a pointer, which could be NULL. Signed-off-by: Rusty Russell --- lightningd/runes.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lightningd/runes.c b/lightningd/runes.c index a1b80f891..40b467e79 100644 --- a/lightningd/runes.c +++ b/lightningd/runes.c @@ -569,7 +569,8 @@ static struct command_result *json_createrune(struct command *cmd, ras = tal(cmd, struct rune_and_string); ras->rune = rune_derive_start(cmd, cmd->ld->runes->master, - tal_fmt(tmpctx, "%"PRIu64, cmd->ld->runes->next_unique_id ? cmd->ld->runes->next_unique_id : 0)); + tal_fmt(tmpctx, "%"PRIu64, + cmd->ld->runes->next_unique_id)); ras->runestr = rune_to_base64(tmpctx, ras->rune); for (size_t i = 0; i < tal_count(restrs); i++)