From 38fc280fad151057075181a00ccd56caa4f56cee Mon Sep 17 00:00:00 2001 From: ZmnSCPxj Date: Sat, 9 Dec 2017 13:08:40 +0000 Subject: [PATCH] Make json_withdraw check testnet flag. bitcoin_from_base58 returns a testnet flag, but json_withdraw did not actually check it. Add a basic check that the given withdraw address belongs to the same net lightningd is using. --- wallet/walletrpc.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/wallet/walletrpc.c b/wallet/walletrpc.c index d8d1e0b9d..b3fbb2abc 100644 --- a/wallet/walletrpc.c +++ b/wallet/walletrpc.c @@ -114,6 +114,18 @@ static void json_withdraw(struct command *cmd, return; } + /* Check address given is compatible with the chain we are on. */ + if (testnet != get_chainparams(cmd->ld)->testnet) { + if (testnet) { + command_fail(cmd, + "Use of testnet address on mainnet"); + } else { + command_fail(cmd, + "Use of mainnet address on testnet"); + } + return; + } + /* Select the coins */ withdraw->utxos = wallet_select_coins(cmd, cmd->ld->wallet, withdraw->amount,