vincenzopalazzo
/
rgb-cln
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

pytest: allow more elaborate bitcoin-cli override. 

In particular, this lets us intercept individual commands, such as
estimatesmartfee.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2018-08-22 09:42:57 +09:30 committed by Christian Decker
parent 3d8836c1e5
commit 5e20eedb41
3 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/test_connection.py
View File

@ -1094,7 +1094,7 @@ def test_fundee_forget_funding_tx_unconfirmed(node_factory, bitcoind):
time.sleep(1)
# Prevent funder from broadcasting funding tx.
l1.fake_bitcoind_fail(1)
l1.fake_bitcoind_fail('exit 1')
# Fund the channel.
# The process will complete, but funder will be unable
# to broadcast and confirm funding tx.

2
tests/test_misc.py
View File

@ -88,7 +88,7 @@ def test_bitcoin_failure(node_factory, bitcoind):
# Make sure we're not failing it between getblockhash and getblock.
sync_blockheight(bitcoind, [l1])
l1.fake_bitcoind_fail(1)
l1.fake_bitcoind_fail('exit 1')
# This should cause both estimatefee and getblockhash fail
l1.daemon.wait_for_logs(['estimatesmartfee .* exited with status 1',

26
tests/utils.py
View File

@ -601,15 +601,23 @@ class LightningNode(object):
# wait for sendpay to comply
self.rpc.waitsendpay(rhash)
def fake_bitcoind_fail(self, exitcode):
def fake_bitcoind_fail(self, failscript='exit 1', cmd=None):
# Create and rename, for atomicity.
f = os.path.join(self.daemon.lightning_dir, "bitcoin-cli-fail.tmp")
with open(f, "w") as text_file:
text_file.write("%d" % exitcode)
os.rename(f, os.path.join(self.daemon.lightning_dir, "bitcoin-cli-fail"))
text_file.write(failscript)
if cmd:
failfile = "bitcoin-cli-fail-{}".format(cmd)
else:
failfile = "bitcoin-cli-fail"
os.rename(f, os.path.join(self.daemon.lightning_dir, failfile))
def fake_bitcoind_unfail(self):
os.remove(os.path.join(self.daemon.lightning_dir, "bitcoin-cli-fail"))
def fake_bitcoind_unfail(self, cmd=None):
if cmd:
failfile = "bitcoin-cli-fail-{}".format(cmd)
else:
failfile = "bitcoin-cli-fail"
os.remove(os.path.join(self.daemon.lightning_dir, failfile))
class NodeFactory(object):
@ -701,8 +709,12 @@ class NodeFactory(object):
cli = os.path.join(lightning_dir, "fake-bitcoin-cli")
with open(cli, "w") as text_file:
text_file.write('#! /bin/sh\n'
'! [ -f bitcoin-cli-fail ] || exit `cat bitcoin-cli-fail`\n'
'exec bitcoin-cli "$@"\n')
'! [ -f bitcoin-cli-fail ] || . {ldir}/bitcoin-cli-fail\n'
'for a in "$@"; do\n'
'\t! [ -f bitcoin-cli-fail-"$a" ] || . {ldir}/bitcoin-cli-fail-"$a"\n'
'done\n'
'exec bitcoin-cli "$@"\n'
.format(ldir=lightning_dir))
os.chmod(cli, os.stat(cli).st_mode | stat.S_IEXEC)
daemon.opts['bitcoin-cli'] = cli