From 776674117b434937d568de78462f11ab475c09b9 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Thu, 3 Oct 2019 16:18:41 +0930 Subject: [PATCH] libwally: upgrade to v0.7.4. On master I get a crash and the following from valgrind, which seems like a libwally bug. Upgrading made it go away. ==45076== Invalid read of size 1 ==45076== at 0x1191A1: topo_add_utxos (chaintopology.c:657) ==45076== by 0x11935F: add_tip (chaintopology.c:681) ==45076== by 0x1197E6: have_new_block (chaintopology.c:761) ==45076== by 0x114BB0: process_rawblock (bitcoind.c:480) ==45076== by 0x1140A0: bcli_finished (bitcoind.c:227) ==45076== by 0x1A4CA2: destroy_conn (poll.c:244) ==45076== by 0x1A4CC2: destroy_conn_close_fd (poll.c:250) ==45076== by 0x1B28CD: notify (tal.c:235) ==45076== by 0x1B2DBC: del_tree (tal.c:397) ==45076== by 0x1B3148: tal_free (tal.c:481) ==45076== by 0x1A34C1: io_close (io.c:450) ==45076== by 0x1A53DD: io_loop (poll.c:449) ==45076== Address 0x59fc658 is 4 bytes after a block of size 4 alloc'd ==45076== at 0x483874F: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) ==45076== by 0x1BD3A5: tx_from_bytes (in /home/rusty/lightning-ltest/lightningd/lightningd) ==45076== by 0x1715C3: pull_bitcoin_tx (tx.c:411) ==45076== by 0x16B25A: bitcoin_block_from_hex (block.c:54) ==45076== by 0x114B45: process_rawblock (bitcoind.c:473) ==45076== by 0x1140A0: bcli_finished (bitcoind.c:227) ==45076== by 0x1A4CA2: destroy_conn (poll.c:244) ==45076== by 0x1A4CC2: destroy_conn_close_fd (poll.c:250) ==45076== by 0x1B28CD: notify (tal.c:235) ==45076== by 0x1B2DBC: del_tree (tal.c:397) ==45076== by 0x1B3148: tal_free (tal.c:481) ==45076== by 0x1A34C1: io_close (io.c:450) Signed-off-by: Rusty Russell --- external/libwally-core | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/external/libwally-core b/external/libwally-core index 1b7ce30c8..50042b527 160000 --- a/external/libwally-core +++ b/external/libwally-core @@ -1 +1 @@ -Subproject commit 1b7ce30c8ceb9e95820486dbc1015b04f5f8b683 +Subproject commit 50042b527cc0ee6ef27c8620d2d2550157a0958b