From 968d6d6d24e8b629b945645c27bbc095ef0a29a0 Mon Sep 17 00:00:00 2001
From: Matt Morehouse <mattmorehouse@gmail.com>
Date: Mon, 11 Dec 2023 13:12:26 -0600
Subject: [PATCH] configure: abort on UBSan failure

By default, UBSan reports runtime errors but does not stop execution.
We already abort in debug builds, and this commit makes us also abort in
regular builds when UBSan is enabled. Arguably, this is what users
expect when they enable UBSan, so it is a good default.

I know I've missed some UBSan bugs in the past because of this issue,
and dergoegge mentioned that this also happened to him.
---
 configure | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/configure b/configure
index f1dac0660..baed36e91 100755
--- a/configure
+++ b/configure
@@ -165,10 +165,7 @@ set_defaults()
 	fi
     fi
     if [ "$UBSAN" != 0 ]; then
-	CSANFLAGS="$CSANFLAGS -fsanitize=undefined"
-	if [ "$DEBUGBUILD" != 0 ]; then
-	    CSANFLAGS="$CSANFLAGS -fno-sanitize-recover=undefined"
-	fi
+	CSANFLAGS="$CSANFLAGS -fsanitize=undefined -fno-sanitize-recover=undefined"
     fi
     if [ "$FUZZING" != 0 ]; then
 	FUZZFLAGS="-fsanitize=fuzzer-no-link -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION"