vincenzopalazzo
/
rgb-cln
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

lightningd: remove always-NULL argument to add_fail. 

It's only called from the db code, and failing_channel is always NULL.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2020-02-18 10:29:58 +10:30
parent ed839bfda0
commit cec18dfd6e
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lightningd/peer_htlcs.c
View File

@ -1970,22 +1970,20 @@ static void add_fulfill(u64 id, enum side side,
static void add_fail(struct htlc_in *hin,
enum onion_type failcode,
const u8 *failing_channel_update,
const struct onionreply *failonion,
const struct failed_htlc ***failed_htlcs)
{
struct failed_htlc *newf;
if ((failcode & UPDATE) && !failing_channel_update) {
/* We don't save the outgoing channel which failed; probably
* not worth it for this corner case. So we can't set
* hin->failoutchannel to tell channeld what update to send,
* thus we turn those into a WIRE_TEMPORARY_NODE_FAILURE. */
if (failcode & UPDATE)
failcode = WIRE_TEMPORARY_NODE_FAILURE;
}
newf = mk_failed_htlc(*failed_htlcs, hin, failcode, failonion,
failing_channel_update);
NULL);
tal_arr_expand(failed_htlcs, newf);
}
@ -2025,7 +2023,6 @@ void peer_htlcs(const tal_t *ctx,
if (hin->failonion || hin->failcode)
add_fail(hin, hin->failcode,
NULL,
hin->failonion, failed_in);
if (hin->preimage)
add_fulfill(hin->key.id, REMOTE, hin->preimage,