vincenzopalazzo
/
rgb-cln
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

renepay: allow it to die gracefully without crashing lightningd. 

Suggested-by: @Lagrang3
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2023-08-07 13:35:54 +09:30
parent 2042b50978
commit f556be5d82
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lightningd/plugin.c
View File

@ -2340,7 +2340,8 @@ void plugins_set_builtin_plugins_dir(struct plugins *plugins,
take(path_join(NULL, dir,
list_of_builtin_plugins[i])),
NULL,
/* important = */ true,
/* important = */
!streq(list_of_builtin_plugins[i], "cln-renepay"),
NULL, NULL);
}

18
tests/test_plugin.py
View File

@ -4255,3 +4255,21 @@ def test_all_subscription(node_factory, directory):
# shutdown and connect are subscribed before the wildcard, so is handled by that handler
assert not l2.daemon.is_in_log(f'.*test_libplugin: all: shutdown.*')
assert not l2.daemon.is_in_log(f'.*test_libplugin: all: connect.*')
def test_renepay_not_important(node_factory):
# I mean, it's *important*, it's just not "mission-critical" just yet!
l1 = node_factory.get_node(options={'allow-deprecated-apis': True})
assert not any([p['name'] == 'cln-renepay' for p in l1.rpc.listconfigs()['important-plugins']])
assert [p['name'] for p in l1.rpc.listconfigs()['plugins'] if p['name'] == 'cln-renepay'] == ['cln-renepay']
# We can kill it without cln dying.
line = l1.daemon.is_in_log(r'.*started\([0-9]*\).*plugins/cln-renepay')
pidstr = re.search(r'.*started\(([0-9]*)\).*plugins/cln-renepay', line).group(1)
os.kill(int(pidstr), signal.SIGKILL)
l1.daemon.wait_for_log('plugin-cln-renepay: Killing plugin: exited during normal operation')
# But we don't shut down, and we can restrart.
assert [p['name'] for p in l1.rpc.listconfigs()['plugins'] if p['name'] == 'cln-renepay'] == []
l1.rpc.plugin_start(os.path.join(os.getcwd(), 'plugins/cln-renepay'))