e0a2d47903
df-rbf: reconnection tests (init_rbf + ack_rbf)
2021-03-06 15:03:56 +10:30
07153bff6a
df: cleanup error handling on lightningd side
...
Make existing methods understand how unsaved channels work, re-work
errors so that we handle everything appropriately
2021-03-06 15:03:56 +10:30
6c76dd338e
channel: move inflight + feerate methods to channel.c
...
Need these more accessible for next patch, which moves the next_feerate
info into listpeers
2021-03-06 15:03:56 +10:30
a23277af57
listpeers: include info on channels that are in-process
...
Channels that we're in negotiation for, but don't have a commitment
transaction saved for yet.
2021-03-06 15:03:56 +10:30
ff069ff924
rbf: consolidate failure paths, use "warnings"
...
We move over to the new "warning" paradigm, instead of using
an "rbf_fail" message.
Every failure is either a warning or an error; on warnings we
hang up and reconnect later, effectively resetting the state.
2021-03-06 15:03:56 +10:30
4fb95a9350
df-rbf: separate first-time channel save from update (RBF)
...
We can't "first save" a channel twice; instead we split in two and just
update the underlying channel on subsequent passes (RBFs)
2021-03-06 15:03:56 +10:30
f22fed3fd5
df-rbf: only permit the channel initiator to init RBF
...
We're *mostly* set up for both sides doing RBF, except that it reverses
the callback flow (using the plugin vs RPC calls) and we're not
currently smart enough to flip between them gracefully
2021-03-06 15:03:56 +10:30
a0cb7bd9b4
df: update reserve calculation
...
We can use the funding amount to derive the reserve requirement.
2021-03-06 15:03:56 +10:30
2719ff8c3b
df-rbf: handle rbf failures in lightningd
2021-03-06 15:03:56 +10:30
d47358848f
df-rbf: init an rbf for real, using openchannel_bumpfee
...
Reorg a bit of the RBF code so we use the same codepaths for we-init vs
they-init starts.
2021-03-06 15:03:56 +10:30
063948d51a
df-feerates: send back original + last known feerates
...
For calculating the next RBF attempt's feerate, we need some historical
information about the feerate used for this channel
2021-03-03 16:19:04 -06:00
cf170c3909
df: allow for RBF_INIT in sigs states
2021-03-03 16:19:04 -06:00
02d99acca1
dualopen: check that peer is connected for json calls
...
Before we start trying to talk to the peer, check that they're
connected.
2021-03-03 16:19:04 -06:00
d8221aae76
df: update channel_id when opening; closing; disconnecting
...
We were missing the channel_id for accepter opens; it's also a good idea
to reset it to 0xFF when we disconnect totally
2021-03-03 16:19:04 -06:00
6407ad334f
df, channel: if a channel reconnects, but it's "unsaved" still
...
Go ahead and start dualopend, but as a fresh instance.
2021-03-03 16:19:04 -06:00
779067d74c
df: check inflights when deciding whether or not to allow command
...
We were missing the inflight state checks before allowing to proceed
with a command.
2021-03-03 16:19:04 -06:00
da81d4bced
channel: skip unsaved channels
...
Now that "peer->channels" contains `unsaved` channels, skip overthem
where appropriate
2021-03-03 16:19:04 -06:00
de3599e98a
subd: remove ctype (channel_type)
...
We only needed the type check for dual_open, since it was the only
subdaemon path that used two 'types' in the subd->channel field.
2021-03-03 16:19:04 -06:00
1e9a900918
df: start of RPC for bumping the fee!
...
Doesn't call into dualopend yet
2021-03-03 16:19:04 -06:00
d49db8ad41
df: do the right thing, now that we have a cancellation routine
...
removes a fixme
2021-03-03 16:19:04 -06:00
3da2ae4d30
df: move to inflights for sigs/openchannel_signed parts of flow
...
We create an inflight once we get the commitment tx for a channel
instead of once we get the funding transaction signatures
2021-03-03 16:19:04 -06:00
8b0e88dfb3
df: move initialization over to unsaved channel
...
uncommitted_channel -> channel (but unsaved)
2021-03-03 16:19:04 -06:00
0951e2c941
df: get rid of unnecessary struct `commit_rcvd`
2021-03-03 16:19:04 -06:00
95e81ce82c
df: helper to find the last (most recent) inflight for a channel
2021-03-03 16:19:04 -06:00
628f9df320
df: consolidate callbacks for opener/accepter, move to open_attempt
2021-03-03 16:19:04 -06:00
bfb862564e
df: method for disconnecting an *unsaved* channel
...
Since we're moving over to "unsaved channels" instead of
"uncommitted_channel" struct, we need a new utility to disconnect this
channe
2021-03-03 16:19:04 -06:00
1786fcbbdc
df: migrate from "uncommitted_channel" to "open_attempt"
...
We're going to move over to "unsaved channels" instead of using a
separate "uncommitted_channel" struct. This means a peer might have a
channel that's not saved to the database yet in its channel list
2021-03-03 16:19:04 -06:00
6474779e38
df-rbf: hook for rbf_init attempt, called "rbf_channel"
...
When we get an RBF request, we ask the/a plugin what they'd like to do
about it. This pipes the request through to the plugin
2021-03-03 16:19:04 -06:00
50b8655cbe
channel: remove 'uncommitted_channel' from channel lookup
...
We're going to be removing "uncommitted_channel" from v2 open stat
2021-03-03 12:28:22 +10:30
4baa10ef68
channel: remove `psbt` and `remote_tx_sigs`
...
We just added this, but we've migrated them to the "inflight" struct
instead, as they actually pertain to an single inflight open attempt
2021-03-03 12:28:22 +10:30
99123ddbe4
dual-funding, rbf: reject RBFs that will fail the total-fee rule
...
RBFs must have a total fee greater than the last successful RBF attempt
2021-03-03 12:28:22 +10:30
0d8351155e
df-rbf: validate that the candidate funding transaction is valid
...
We need to make sure that there's at least one input that's represented
in every single RBF-attempt for this channel, to prevent "parallel"
subsequent RBFs from succeeding/opening (the multi-channel backdoor?!)
2021-03-03 12:28:22 +10:30
22078262f0
df-reinit: pass back channel_flags
...
We should also restore the channel_flags field on reinit; we use them if
we do an RBF after a reconnection
2021-03-03 12:28:22 +10:30
a489f92ee8
df-rbf: start of handling an incoming RBF attempt from peer
...
A peer init's an RBF, we start handling it
2021-03-03 12:28:22 +10:30
067f1f2eb7
df-rbf: add method to fail an RBF
...
this is a bit different than straight up failing a channel. we want to
signal that the RBF attempt failed, only
2021-03-03 12:28:22 +10:30
b8b910e4c4
df-rbf: update channel data on depth reached
...
When the funding tx reaches depth, update the channel's data to the
"correct" funding transaction info from inflights (if necessary).
This will be necessary if:
- the transaction has been successfully RBF'd and
- the lesser fee transaction is the one successfully mined, OR
- the channel is in the process of being RBF'd
2021-03-03 12:28:22 +10:30
1e4ff724a5
nit: make comments 80 chars
2021-03-03 12:28:22 +10:30
84ed942dee
df: patch hole where we wouldn't notify peer of failure
2021-02-24 10:06:42 -06:00
367e377d5a
df: use simplified version to print json
2021-02-24 10:06:42 -06:00
bdf0d60fd6
chore: fix typo in openchannel hook log
...
Nit: The underscore in "openchannel_hook" is wrong, bcause the name of
the hook is just "openchannel". The "_hook" implied this to be part of
the name.
Changelog-None
2021-02-01 09:57:15 +10:30
d1a59b6f0d
nit df: correct spelling mistake
2021-01-25 10:05:17 +10:30
7e324177de
df-tests: simultaneous openchannel_init (while in progress)
...
Reject a peer's request to open a channel while we're already in progress
2021-01-10 13:44:04 +01:00
fa539d3281
df-tests: make memleak happy by cleaning up `psbt`
...
We don't need it anymore. Normally it gets cleaned up by `cmd` but we're
done with it here.
2021-01-10 13:44:04 +01:00
ff0e2dbd28
df-tests: test_channel_opened_notification
...
We weren't sending a channel_open notification for dual-funded channels.
This is only sent for the 'accepter' side. We send it as soon as both
funding_tx sigs have been exchanged, even though it's possible the
funding transaction might be published without this having been the case.
Since we fail the channel if this happens, only notifying for good/valid
channels reaching the broadcast state is the right way to handle this.
2021-01-10 13:44:04 +01:00
959ca793b0
df-tests: test_openchannel_hook_error_handling
2021-01-10 13:44:04 +01:00
803d9701d3
df-tests: test_openchannel_hook_chaining
2021-01-10 13:44:04 +01:00
2cd95aa806
df: add a new 'channel_open_failed' notification
...
Let plugins know when a channel open has failed.
We need to notify accepters now too, so we remove the check on who's
funding the channel before sending the 'failed' message from
dualopend->master.
2021-01-10 13:44:04 +01:00
d4ec052668
df: include channel_id in openchannel2 hook
...
We already know what the channel id is, we should go ahead and pass it
on to any listening plugins -- this makes clean up easier/possible
if a open fails early on and we've got reserved utxos.
2021-01-10 13:44:04 +01:00
1393e187f9
df: don't update local shutdown scriptpubkey from dualopend
...
When we're the opener, we get the upfront shutdown scriptpubkey (if
there is one) from the `close_to` param of `openchannel_init`.
We were passing it through dualopend, but we need to break the update
chain so that our test_option_upfront_shutdown_script test works (same
as on the openingd flow.)
2021-01-10 13:44:04 +01:00
52da9be598
df: if 'openchannel2' is "rejected" we should send that error
...
We weren't really handling 'rejected' channel open requests very
elegantly, now we do.
2021-01-10 13:44:04 +01:00
niftynei
Michael Schmoock