b5f737e563
gossip: Passing alias, color and wireaddrs through to gossipd
...
First step towards `gossipd` managing the `node_announcement`.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2017-12-17 02:44:20 +00:00
67c6d4d1f1
opts: Change alias to be u8*, better matches the unicode nature
...
We are still generating only char* style aliases, but the field is
defined to be unicode, which doesn't mix too well with char.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2017-12-17 02:44:20 +00:00
19c030ea1f
routing: Make routing_state aware of its own ID
...
This is used to identify our own announcements.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2017-12-17 02:44:20 +00:00
8d6281175d
gossip: Remove HSM_FD from handshake
2017-12-17 02:44:20 +00:00
4022fc0034
wallet.c: Minor leak in wallet_invoices_load.
2017-12-15 10:41:54 +00:00
44c37b60e4
Add test for withdrawing to P2WPKH and P2WSH.
2017-12-14 03:36:40 +00:00
e26d294b60
Add support for withdrawing to BECH32 addresses.
...
Fixes : #428
2017-12-14 03:36:40 +00:00
8512e2c8ef
README.md: Add link to waitanyinvoice
2017-12-14 03:07:20 +00:00
bbbbb60863
wallet: don't leak string on update.
...
We actually don't need tal_fmt() here at all, anyway.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-13 22:46:10 +01:00
5a319c781c
wallet: don't leak UTXO array on extracting outputs.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-13 22:46:10 +01:00
9747d1a62c
database: don't leak query string.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-13 22:46:10 +01:00
65fd7ce132
bitcoind: don't leak memory on every call to bitcoin-cli.
...
Fixes : #412
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-13 22:46:10 +01:00
b00525b8c8
options: don't leak memory when people override options.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-13 22:46:10 +01:00
005f3826c9
wallet/tests: add mocks for futureproofing.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-13 22:46:10 +01:00
2931760b5b
wallet: move tests into test/ dir like other unit tests.
...
Trivial move, but makes it easy to add new ones.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-13 22:46:10 +01:00
757d45c8a3
Test withdrawal to P2SH address.
2017-12-13 03:10:04 +00:00
9842898ca4
Add support for withdrawing to P2SH addresses.
2017-12-13 03:10:04 +00:00
d43fb87871
Factor out scriptpubkey_from_address function from json_withdraw.
2017-12-13 03:10:04 +00:00
9f481226fa
Rearrange checking of withdrawal address parsing success in json_withdraw.
2017-12-13 03:10:04 +00:00
b56fea8b2a
Modify hsm_sign_withdrawal to transmit scriptpubkey to withdraw to, rather than pkh.
2017-12-13 03:10:04 +00:00
5fd74f9933
Change withdraw_tx to accept scriptpubkey rather than plain address.
2017-12-13 03:10:04 +00:00
0610f66c34
bolt11: handle r value fee spec change.
...
We don't use it yet, but now we'll decode correctly.
See: https://github.com/lightningnetwork/lightning-rfc/pull/317
lightning-rfc commit: ef053c09431442697ab46e83f9d3f86e3510a18e
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-12 11:45:44 +01:00
e9f9721ed3
devtools/bolt11-cli: handle hashed descriptions
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-12 11:45:44 +01:00
34444a99f9
docker: Added clang to build dependencies
2017-12-12 02:31:03 +00:00
7572c22a26
travis: Add clang build to build matrix
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2017-12-12 02:31:03 +00:00
61852b4603
cleanup: Use check_act* in handshake and remove unused static inline
...
This was tripping up `clang`.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2017-12-12 02:31:03 +00:00
486d321094
Avoid NULL pointer dereference in channelseq(...)
2017-12-11 16:07:57 +01:00
4452e3f3f1
Remove redundant code
2017-12-11 03:38:37 +00:00
0353ec0983
Remove trailing whitespace
2017-12-11 03:35:59 +00:00
7c09b6f478
Load defaults for purpose of help.
2017-12-11 03:21:07 +00:00
f0fa01b439
Share similar code between bitcoin_witness_p2sh_p2wpkh and bitcoin_scriptsig_p2sh_p2wpkh.
...
Note that bitcoin_witness_p2sh_p2wpkh is not actually used in current
code.
2017-12-10 12:46:25 +01:00
307e8c0180
Avoid NULL pointer dereference when new_initial_channel(...) fails
2017-12-09 16:25:57 +01:00
38fc280fad
Make json_withdraw check testnet flag.
...
bitcoin_from_base58 returns a testnet flag, but json_withdraw
did not actually check it. Add a basic check that the given
withdraw address belongs to the same net lightningd is using.
2017-12-09 16:18:59 +01:00
2ed53025f9
Remove redundant remote_shutdown_scriptpubkey assignment
2017-12-09 16:17:58 +01:00
b5c8b9b9b3
Add build artefacts generated during "make"/"make check" to .gitignore
2017-12-08 13:07:50 +01:00
61c47c09d0
Fix typos
2017-12-08 13:07:20 +01:00
5444084625
onchaind: fix reversed CSV delays.
...
Our config -> their CSV delay, their config -> our CSV delay.
Fixes : #395
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-04 13:00:57 +01:00
af5dbbc9f8
json_connect: separate port arg so we can parse IPv6 addresses.
...
Fixes : #391
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-04 11:15:59 +01:00
0069787eb6
lightningd: fix crash on bad connect host arg.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-04 11:15:59 +01:00
45e9f35988
docs: Note that we need 0.15 (for estimatesmartfee with CONSERVATIVE/ECONOMCIAL flags)
...
Closes : #392
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-04 10:06:34 +01:00
9ba99d2b2d
hsm: Cleanup after merging control and client libraries
...
Change all calls to use the correct serialization and deserialization
functions, include the correct headers and remove the control
messages.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2017-12-03 17:06:13 +01:00
2d9cd4759e
hsm: Make the master simply a client with special capabilities
2017-12-03 17:06:13 +01:00
8ff69e0307
hsm: channeld now also just uses the handle_client entry point
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2017-12-03 17:06:13 +01:00
6ce264d3a2
hsm: Remove special case of hsmfd_ecdh, replaced with client and cap
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2017-12-03 17:06:13 +01:00
5482acb837
hsm: Unifying the client creation and adding client capabilities
...
We had a number of entry points into the HSM, all with different
behavior, so this is my attempt at unifying the way we handle
clients. Every client, except master, now takes the same path entry
point to the HSM and we use capability bit flags to indicate whether
the client is allowed to execute a set of operations.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2017-12-03 17:06:13 +01:00
70bbc46304
Un-break master after merging #389
...
The #389 introduced some changes that conflicted with
9de3827199#389 and fixes the `master` branch again.
Lesson learned: always rebase a PR before merging.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2017-12-02 13:00:29 +01:00
40516941af
channeld: fill in channel_update field in errors by asking gossipd.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-02 12:54:12 +01:00
933c1794a1
gossipd: gossip_get_update / gossip_get_update_reply from channeld.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-02 12:54:12 +01:00
0a596fb043
channel: infrastructure for gossipd request/response.
...
The same as master request/response: we queue up incoming replies we
don't want for later processing.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-02 12:54:12 +01:00
9de3827199
channeld: don't use ccan/io, go sync.
...
We revert to a simple select() loop. This makes things simpler, and fixes
the problem where we want to exit but we've partially read a peer packet.
We still queue up outgoing peer packets for non-blocking send: if we
went full sync there, we'd risk deadlock if both sides wrote a huge
number of packets and neither was reading.
This also greatly simplifies the next patches, where we want to make
our first get/response from gossipd.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-02 12:54:12 +01:00
Christian Decker
ZmnSCPxj
Rusty Russell
practicalswift