024bc83fca
listpeers: add inflights info
...
Changelog-Added: for v2 channels, we now list the inflights information for a channel
2021-05-24 12:17:48 +09:30
8925fc8b01
inflights: add checks that there's actually an inflight
2021-05-24 12:17:48 +09:30
82fa3fa2ef
df-rbf: order inflights by funding_feerate
...
When we re-populate from disk, we need to know what order to recreate the
inflights list in.
Fixes #4511
2021-05-24 12:17:48 +09:30
8ae9f6ac9e
df-tests: add better explainer for test logic
2021-05-24 12:17:48 +09:30
bab5ef4aff
df-test: test for a failed rbf attempt, currently crashes
...
An attempted + failed RBF results in a crashed/dead node
2021-05-24 12:17:48 +09:30
e2867be609
df-tests: re-write test_funding_cancel_race for v2 commands
...
test_funding_cancel_race uses fundchannel_open etc; this new test does a
similar (but not exact thing, as 'aborts' dont work after an update
is confirmed) thing, using openchannel_update and openchannel_abort.
2021-05-23 17:42:09 +09:30
2d4939fa6d
df-tests: re-write the funding wallet corners test for v2
2021-05-23 17:42:09 +09:30
8908dd08ec
df-bugs: only include the `funding` if we're the opener
...
`funding` field belongs to the INITIATOR!
2021-05-23 17:42:09 +09:30
260adb824e
df: differentiate error message between
...
There's a difference between "no channel" and "channel in progress
but no open available to cancel"
2021-05-23 17:42:09 +09:30
4ae9e0c73f
CI: Re-enable experimental build.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-23 08:20:59 +09:30
477832057d
funder: print reason that we don't contribute funds
...
If we don't put funds into a channel, say why in the logs. Should make
it a bit easier to figure out what's going on.
2021-05-23 08:19:50 +09:30
c93bd5bd51
funder: test for adding utxos, calculating total available
...
Make sure that 100% available actually puts in 100% of what we can add
(note that this isn't 'all' -- we don't include uneconomic utxos)
2021-05-23 08:19:50 +09:30
f6186d5860
funder: subtract the fee of the utxo from the available amount
...
Adjust our total available funds downward, to account for the fees we'll
be charged to spend them.
2021-05-23 08:19:50 +09:30
9a1041ee97
fundpsbt: dont add utxos that are a net-loss
...
if the utxo can't pay for its own fees, dont put it in the tx
Changelog-Changed: JSONRPC: fundpsbt will not include UTXOs that aren't economic (can't pay for their own fees), unless 'all'
2021-05-23 08:19:50 +09:30
5e7695f6a0
funder: add count of utxos we're signing to the logs
...
Useful for asserting how many inputs we're contributing
2021-05-23 08:19:50 +09:30
14febd4ecc
pytest: disable mpp test which is blocking merges.
...
I'm still diagnosing exactly why this fails, but it will need Christian's
help at this stage.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-23 08:13:27 +09:30
46b735c023
dijkstra: add chan pointer argument to path scoring.
...
For fuzz, we will need some fixed per-channel data (so we always fuzz
a channel the same way).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
3832542d27
common/dijkstra: remove dijkstra_amount().
...
Unless you're using amount as the sole cost function (we don't!), the
"cost" is not the "amount".
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
2bb365a931
common/route: route_from_dijkstra returns route_hop array.
...
This is what (most) callers actually want, so unify it into one place.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
e531a38963
gossipd / plugin: clean up names in struct route_hop.
...
We're going to unify them, but the names are not the normal ones.
Fix that first.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
9dadcc858b
common/gossip_store: avoid fd pass for new store, use end marker.
...
This is also simpler.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
c2a88912e1
common/gossmap: reload once we hit end marker.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
0d4f014021
gossip_store: create end marker for EOF.
...
This is better than using the previous "keep statting the file" approach,
since we can also tell you how long the replacement is, to avoid a
gratitous load.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
167681c709
gossmap: fix gossmap_chan_get_announce() and gossmap_node_get_announce().
...
These were never used, nor tested.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
d54abd0e36
gossmap: function to get channel features bitmap.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
770a328d56
gossmap: save the offset where the channel updates are, function for details.
...
This takes an extra 8 bytes per channel, but means we can go back and
get more information about them; this is implemented in
gossmap_chan_get_update_details() which is what listchannels will need.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
d1f8a5f0be
gossmap: add gossmap_chan_get_capacity() helper.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
eb370ab8ff
gossmap: remembers when a channel is private.
...
Steals one bit from the scid_off, and turns that into a relative
offset.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
cc198748d4
common/json_tok: hoist param_short_channel_id from inside lightningd/
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
7ef6dd04d9
plugins/test/run-route-overlong: modern overlong routing test.
...
gossmap equivalent of gossipd/test/run-overlong.c.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
52e5ca3c11
plugins/libplugin: make headers update-mocks friendly.
...
In particular, it expects return type at start of line.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
6f71aae336
plugins/libplugin-pay: extreact route function so we can write unit tests.
...
New "route()" doesn't need a struct payment, so is easier to test.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
088cfced18
common/test/run-route and run-route-specific: modern gossmap tests
...
Equivalent to gossipd/test/run-find_route.c and gossipd/test/run-find_route-specific.c
except they use gossmap.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
0682ad9c48
fetchinvoice: don't produce invalid JSON on sent_inv timeout.
...
An unrelated bug in the reverse path triggered this code, and boom.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
2e3e4a50ec
update-mocks: prefer to find function defs from local includes.
...
This matters for:
- common/wallet.h vs wallet/wallet.h
- common/gossip_store.h vs gossipd/gossip_store.h
- common/json.h vs lightningd/json.h
- common/ping.h vs lightningd/ping.h
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
d868d4470a
Makefile: don't let update-mocks run unless DEVELOPER and EXPERIMENTAL_FEATURES.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
25b5e1e099
update-mocks: make sure we cover all test programs.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
cc6f1fd120
update-mocks: don't try to regenerate files.
...
If you do update-mocks in a dirty tree, the recursive make that it
uses will try to rebuild things! Suppress that.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-22 17:53:04 +09:30
33736b860a
lightningd: attach HTLC timeout to htlc itself, fix gratuitous disconnect bug.
...
We set the timeout on first HTLC, but didn't clear it if that HTLC failed.
It's saner to have a per-HTLC timeout (since that's what it is!) and
also our timer infra is specially coded to scale approximately infinitely so
trying to optimize this is vastly premature.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: Protocol: We would sometimes gratuitously disconnect 30 seconds after an HTLC failed.
2021-05-21 14:45:05 +09:30
11180e7aa1
pytest: add test for HTLC timeout on failed htlcs.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-21 14:45:05 +09:30
0d68febd8d
reorganize .gitignore entries across subdirs.
2021-05-18 09:43:50 +09:30
e17526f64c
gitignore more things.
2021-05-18 09:43:50 +09:30
e141b71675
pytest: fix flake in test_reconnect_no_update
...
If l2 didn't get FUNDING_LOCKED from l1 before it disconnected, it
won't be in state CHANNELD_NORMAL: it will be in DUALOPEND_AWAITING_LOCKIN.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-17 18:58:10 -05:00
0f2009c7a3
make: Do not scan contrib for discouraged functions
2021-05-15 09:31:12 +09:30
6c67afeb03
make: Add CPPCHECK_OPTS to allow excluding files from the check
...
With swig we now have C files that are generated with tools that are
not under our control, so provide an escape hatch for them.
2021-05-15 09:31:12 +09:30
a4c19ba6ba
libhsmd: Clean up the build descriptors for libhsmd_python
2021-05-15 09:31:12 +09:30
323b1a558b
libhsmd: Add missing implementation of status functions
2021-05-15 09:31:12 +09:30
7f15f86718
libhsmd: First working build script for libhsmd-python
...
Changelog-Added: libhsmd: Added python bindings for `libhsmd`
2021-05-15 09:31:12 +09:30
214fdcc9d7
plugin notifications: minor cleanups.
...
1. We don't need to check for NULL before tal_count(NULL).
2. Use of json_for_each_arr iterator is probably better.
3. Weird indent fixed.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-14 10:24:05 +09:30
ce1e5bd388
df-test: make flakey test not as flakey
...
This would flake fairly regularly, what we really care about is
asserting that the l2 node is in CHANNELD_NORMAL state, while the l1
node hasn't progressed that far yet.
2021-05-12 11:25:41 +09:30
niftynei
Rusty Russell
fiatjaf
Christian Decker