5571f2143e
gossip: Added message to notify gossipd of outpoint spends
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-30 16:35:00 +02:00
1b604d5dd6
pytest: Wait for the funding transaction to be in the mempool
...
This can lead to failures in the valgrind configuration.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-30 16:34:31 +02:00
c1a43a04af
payalgo: Be willing to overpay up to maxfeepercent, for privacy.
...
This obscures how far an intermediate hop is from the ultimate
payee, and also obscures slightly the exact payment value.
Fixes : #1089
2018-03-30 15:40:32 +02:00
bc5fc692d1
pay: Let `sendpay` modify the recorded `msatoshi` of payments.
2018-03-30 15:40:32 +02:00
1fe79df867
.gitignore: Ignore `gossip_store` file.
...
This, is generated, by `make check`.
Probably better to put it in some location elsewhere, though?
2018-03-30 00:01:46 +02:00
a85ead7058
invoice: allow numeric labels again.
...
Fixes : #1291
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-30 00:01:10 +02:00
dc25e3a6df
Make compiler happy
2018-03-29 23:16:03 +02:00
b45477b081
Make cppcheck happy and code clearer.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-29 23:16:03 +02:00
760e9f6993
Add cppcheck checking as part of check-source
2018-03-29 23:16:03 +02:00
a54872063f
check-cppcheck: autogen suppressions for all the list_for_each(_safe)
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-29 23:16:03 +02:00
0e0ad1aa4d
gossip: Check that we have a node before applying changes
...
This was a tricky one to find, it turns out that some nodes are sending
node_announcements even if they don't have a channel announced yet. If they are
a peer and the channel is currently verifying then we'll have a local channel in
the network view, hence accept the node_announcement, but when replaying, the
node_announcement will be replayed and we won't have a channel yet. This just
skips node_announcements, which is always safe.
Reported-by: @laszlohanyecz
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-29 23:15:33 +02:00
e25297dd0a
Remove unused functions not covered by unit tests
2018-03-28 11:22:05 +02:00
06e8fbda95
onchain: print exactly what we were doing if we fail in grind_feerate.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-28 01:43:39 +00:00
8df29d169c
The overflow check mul_overflows_s64(int64_t, int64_t) overflows and triggers UB :-) Remove it
...
The overflow check `mul_overflows_s64(int64_t, int64_t)` overflows.
Since this is an signed integer overflow this triggers UB, which
in turn means that we cannot trust the check.
Luckily mul_overflows_s64(int64_t, int64_t) is unused. Removing it.
2018-03-27 23:18:48 +00:00
f2e81fde44
travis: Updated docker builder images to include cppcheck
...
It's a check dependency from PR #1262 .
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-27 23:17:48 +00:00
f341b508e1
pytest: Add checks that funding change and to_us get confirmed
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-27 23:17:17 +00:00
5519717144
onchaind: Pass the funding spend height through when adding a UTXO
...
This is necessary since we have onchaind tell us about the
their_unilateral/to_us output, after it is already in a block.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-27 23:17:17 +00:00
ba7341ec87
cleanup: Make blockheights unsigned
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-27 23:17:17 +00:00
aba0b0e01b
opening: Add the change scriptpubkey to the txfilter
...
This is necessary to track confirmations of or change output.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-27 23:17:17 +00:00
27db2d4ce2
wallet: Also track confirmations of their_unilateral/to_us outpoints
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-27 23:17:17 +00:00
286cfefc62
wallet: Remove pruned outpoints from utxoset outpoint_filter
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-27 17:14:58 +02:00
6269a4c55d
Remove unused functions not covered by unit tests
2018-03-26 23:35:56 +00:00
b914062465
pay: Also record how much we actually ended up sending.
2018-03-26 05:01:49 +00:00
7e9750ffee
Reduce variable scopes
2018-03-26 01:31:21 +00:00
94ca824cf5
Use correct format strings for signed integers
2018-03-26 01:20:22 +00:00
74f3662a3b
lightningd/subd.h: Add missing wire/wire.h.
...
If not included, a source file containing only
`#include<lightningd/subd.h>` will file compilation.
2018-03-26 01:09:59 +00:00
0bb9bcc0f1
wallet: Track some channel usage statistics.
...
Fixes : #1049
2018-03-26 01:08:52 +00:00
217d4f99eb
Added link to macOS in install index.
...
Also, technically, the name of the current version of the OS is macOS, so I
updated it.
2018-03-26 01:05:11 +00:00
e7c8b95be3
Fix include order
2018-03-26 00:30:39 +00:00
c4700a13a7
Add guard for BACKTRACE_SUPPORTED
2018-03-26 00:30:39 +00:00
4c6d72a919
Update git configs for mac build
2018-03-26 00:30:39 +00:00
880c19eb4e
doc: document restrictions on invoice RPC.
...
In particular: label must be a string, and description cannot use any
the JSON unicode escapes, which should be unnecessary with UTF-8
anyway.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-26 00:20:53 +00:00
dfce8b5efd
common/json: move declaration into correct header.
...
Reported-by: @ZmnSCPxj
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-26 00:20:53 +00:00
7ae013202f
json: make json_add_string do partial escapes.
...
This is useful when we log a JSON-escaped string, so we don't double-escape.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-26 00:20:53 +00:00
ed9093fcbd
json: allow strange characters through our JSON parser.
...
Fixes : #387
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-26 00:20:53 +00:00
9f7d4312ff
bolt11: undo json encoding for description bytes.
...
We don't handle \u, since we assume everyone sane is using UTF-8. We'd
still have to reject '\u0000' and maybe other weird cases if we did.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-26 00:20:53 +00:00
54431d2b08
lightningd: escape our own alias when we print it in logs.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-26 00:20:53 +00:00
4139f06780
json_getnodes: escape the alias when we print it out.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-26 00:20:53 +00:00
76e8a11380
wallet: use json_escaped for invoice label.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-26 00:20:53 +00:00
d92579f627
common/json_escaped: new type which explicitly notes a string is already JSON.
...
Trivial to use as a string, but it still means you should be careful
around it.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-26 00:20:53 +00:00
a077c3defb
lightningd: test for weird aliases.
...
Test has inverted conditions to make it "pass", we fix as we go.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-26 00:20:53 +00:00
8c838ebd76
test_lightning: Write test for invoices with weird characters.
...
It's currently expected to fail.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-26 00:20:53 +00:00
439dc0f991
gossipd/gossip_store.h: fix check-source for new source file header guards
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-26 00:20:01 +00:00
82e1f5ade1
gossip: Make gossip_store_append private
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-25 23:56:59 +00:00
44e23b3773
gossip: Replay the entire store on init instead of when idle
...
This now works because we no longer call out to masterd or bitcoind to verify
the channels. It's also rather quick and silent so we can just process all
stored messages until we're done.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-25 23:56:59 +00:00
c4ea79cc5c
Revert gossip: Track whether we read a message from store or peer
...
Messages from peers and messages from the gossip_store now have completely
different entrypoints, so we don't need to trace their origin around the message
handling code any longer.
2018-03-25 23:56:59 +00:00
3826518bd6
gossip: Wrap node_announcements in gossip_store messages
...
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-25 23:56:59 +00:00
db13c7e851
gossip: Wrap channel_updates in the gossip_store as well
...
Bypasses verification when loading from the gossip_store.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-25 23:56:59 +00:00
6e01f38d7d
gossip: Use the custom gossip wire msg to wrap channel_announcements
...
This stores and reads the channel_announcements in the wrapping message which
allows us to store associated data with the raw channel_announcements.
The gossip_store applies channel_announcements directly but it also returns it,
and it gets discarded as a duplicate. In the next commit we'll have gossip_store
apply all changes, bypassing verification, so the duplication is only temporary.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-25 23:56:59 +00:00
6894f20927
gossip: Change gossip_store message length to u32
...
Since we now store additional data along with the original messages they exceed
the length of the peer wire protocol messages.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-03-25 23:56:59 +00:00
Christian Decker
ZmnSCPxj
Rusty Russell
practicalswift
Mark Beckwith
conanoc