590f12145b
listpeers: include the `pushed_msat` amount
...
Useful for accounting for missed/historical channel opens, to figure out
what the actual sat contribution from each peer is at a utxo level
Changelog-Added: JSONRPC: `listpeers` now includes a `pushed_msat` value. For leased channels, is the total lease_fee.
2022-03-05 15:12:12 +10:30
ecb19ba6f2
coin_mvt: report mutual close outputs also
...
It's better to report every single utxo on close so we know when
to mark a channel account as definitively closed.
2022-03-05 15:12:12 +10:30
d246e9c1a2
tx_parts: as a convenience, copy over the value as the 'satoshi'
...
Reporting coin movements was crashing for liquid-regtest tests because
we were using an un-initialized field (the tx_part output's satoshi
field).
We fill this in 'as a convenience' for other wally_tx_outputs that are
on liquid elsewhere, here we do the same for tx_parts sent over the
wire to onchaind.
2022-03-05 15:12:12 +10:30
7a00277b43
coin_mvt: mark coins destined for wallet w/ originating acct
...
Only shows up on delayed to us outputs, but nice to have anyway.
It's missing for channel index destined deposits, maybe nice to add at
some point in the future; right now you can figure out which close a
wallet deposit comes from via the channel close txid
2022-03-05 15:12:12 +10:30
24a1c91045
coin_mvt: report the number of outputs on a channel close tx
...
The bookkeeper needs to know how many outputs to expect before we can
consider a channel resolved onchain.
2022-03-05 15:12:12 +10:30
12cbf614cd
coin_mvt: mark every event that already has a destination
...
Every event that's coming out of here that specifies a different place
to be deposited should be marked as originating from this channel's
account.
2022-03-05 15:12:12 +10:30
b30328a91f
coin_mvt: rm unncessary if statement
...
We don't need to switch on this; if it's zero the below ops will be
effectiely no-ops.
2022-03-05 15:12:12 +10:30
ea36c3a938
db: collapse the db_queries files into the generated ones
...
There's no reason to have these be independent of the generated files,
all the data contained within them is 'formulaic'
2022-03-05 15:03:34 +10:30
453ef7f0ce
db: mark that column is unused/ignored
...
2022-01-25T23:41:45.2994844Z ----------------------------- Captured stderr call -----------------------------
2022-01-25T23:41:45.2995230Z lightningd: Never accessed column 1 in query SELECT 1 FROM offers WHERE offer_id = ?;
2022-03-05 15:03:34 +10:30
ce12d2b8a9
database: pull out database code into a new module
...
We're going to reuse the database controllers for the accounting plugin
2022-03-05 15:03:34 +10:30
03c950bae8
db: decouple `fatal` reliance, have as impl defined function
...
`fatal` is defined in lightningd and has logfile dependencies etc.
Make it more generic by allowing declaration in the use file (wallet.c)
2022-03-05 15:03:34 +10:30
b0829fc52a
lightningd/Make: cleanup lightningd+wallet headers
...
There is no "wallet_lib_headers" variable in wallet/Makefile
Likewise, there were two "lightningd_headers", a couple of unused
variables and some other nonsene in lightningd/Makefile
2022-03-05 15:03:34 +10:30
cd37753849
plugins/bcli: neaten to fix spurious leak report.
...
```
plugin-bcli: MEMLEAK: 0x1d2a118
plugin-bcli: label=plugins/bcli.c:636:const char *[]
plugin-bcli: backtrace:
plugin-bcli: ccan/ccan/tal/tal.c:442 (tal_alloc_)
plugin-bcli: ccan/ccan/tal/tal.c:471 (tal_alloc_arr_)
plugin-bcli: plugins/bcli.c:636 (estimatefees_next)
plugin-bcli: plugins/bcli.c:684 (estimatefees)
plugin-bcli: plugins/libplugin.c:1307 (ld_command_handle)
plugin-bcli: plugins/libplugin.c:1348 (ld_read_json_one)
plugin-bcli: plugins/libplugin.c:1368 (ld_read_json)
plugin-bcli: ccan/ccan/io/io.c:59 (next_plan)
plugin-bcli: ccan/ccan/io/io.c:407 (do_plan)
plugin-bcli: ccan/ccan/io/io.c:417 (io_ready)
plugin-bcli: ccan/ccan/io/poll.c:453 (io_loop)
plugin-bcli: plugins/libplugin.c:1565 (plugin_main)
plugin-bcli: plugins/bcli.c:965 (main)
plugin-bcli: parents:
plugin-bcli: plugins/libplugin.c:1235:struct command
```
It's neater to convert start_bitcoin_cli() to take varargs, and handle take:
the above "leak" is because we don't keep a pointer to the params[] array
which we use to pass to start_bitcoin_cli().
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2022-03-03 10:23:11 +00:00
4386ccd842
bitcoin: Comment typo fix
2022-03-03 11:22:19 +10:30
7bfbe1492a
test_close: sync l1 to the blockchain, so that the events are there
...
Flake on CI coming from `penalty_in/outhtlc` due to the fact that all
the events haven't arrived for the check.
If we wait to sync `l1` as well as `l2`, this should resolve the flake.
# We use a subset of tags in expected_2 that are used in expected_1
> tags = check_utxos_channel(l1, [channel_id], expected_1)
tests/test_closing.py:726:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
tests/utils.py:321: in check_utxos_channel
txid = matchup_events(u_set, evs, chans, tag_list)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
u_set = [[{'account_id': 'external', 'blockheight': 104, 'coin_type': 'bcrt', 'credit': '100000000msat', ...}, None]]
evs = [('external', ['penalty'], None, None), ('external', ['penalty'], None, None), ('external', ['penalty'], None, None)]
chans = ['2722a5fe49a8b5fa4004c19828f3e903632ac02712c6fe78ebea418daad2691f']
tag_list = {'0': '892c64c7d8c8f15d7bdcdcde34b615817d273d2e33d9d775cc9ff38e8e3deeb2', 'A': '1e69d2aa8d41eaeb78fec61227c02a6303e9f32898c10440fab5a849fea52227', 'B': '0e11e2ca01bf5f30b4c54522af172af055dcff8e3810f80a5069a2394cad74b5'}
def matchup_events(u_set, evs, chans, tag_list):
> assert len(u_set) == len(evs) and len(u_set) > 0
E AssertionError
2022-03-01 16:19:34 -06:00
6332578070
rust: Use $CARGO_OPTS when building the example plugin
2022-02-28 23:25:37 +00:00
75f0b8e916
cln-grpc: Add `listpeers` RPC method
...
This is pretty much the hardest to map, but we map it correctly, with
the exception of the state_changes[] array we truncated out in the
last commit.
2022-02-28 23:25:37 +00:00
b73405a4c2
cln-grpc: Allow fields to be mapped to None to ignore them
...
`listpeers` is a rather deeply nested structure which has a couple of
caveats, namely that we use the same enum multiple times, which causes
naming clashes. So we truncate the state_changes[]. We can later map
them if needed, but it'll get much easier once we have an abstract
model description that isn't JSON schema, which unrolls all types,
causing us to generate those enums multiple times.
2022-02-28 23:25:37 +00:00
fd2d126ec4
cln-grpc: Add conversion from pb Amount to json Amount
2022-02-28 23:25:37 +00:00
d95c9d2990
cln-grpc: Add conversion from pb Amount to json Amount
2022-02-28 23:25:37 +00:00
bb4946a6e6
msggen: Support renaming methods in GRPC
...
There is at least one clash with a built-in for the grpc server trait,
namely `connect` so we add support for renaming a method when
generating the scaffolding
2022-02-28 23:25:37 +00:00
efed7d8617
msggen: Support enums in requests too
...
They are sent as i32 over protobuf, so we need to convert them into
their enum representation.
2022-02-28 23:25:37 +00:00
494243d41c
msggen: Handle some more types in request conversions
2022-02-28 23:25:37 +00:00
24e44ecbb6
cln-grpc: Add glue to get all pieces to work together
2022-02-28 23:25:37 +00:00
62dc078271
cln-grpc: Generate server dispatcher
...
The server doesn't do much more than unwrapping the request from its
grpc envelope, convert it into the matching JSON-RPC binding struct,
initiate the RPC connection (until we have connection pooling), and
then forwards the converted request. The inverse then happens for the
result.
2022-02-28 23:25:37 +00:00
5d6e9d6dae
cln-grpc: Add generation of request conversion
...
This is taking protobuf requests on one side and converting them into
the JSON-RPC requests.
2022-02-28 23:25:37 +00:00
8d3871d791
cln-grpc: Add result conversion generator to `msggen`
...
This takes the Rust bindings and converts them into the generated
protobuf bindings:
> JSON-RPC -> Rust bindings -> grpc bindings -> protobuf
2022-02-28 23:25:37 +00:00
4c105d2424
cln-grpc: Generate grpc bindings from proto
...
This is the easy way, since there's already tooling for this.
2022-02-28 23:25:37 +00:00
d01b2c21a7
cln-grpc: Add generation of grpc protobuf file from schema
2022-02-28 23:25:37 +00:00
edf6832f8f
rust: Actually check if we have cargo
...
Seems a temporary edit to check the detection slipped in during the
previous PR. This fixes that :-)
2022-02-28 23:25:37 +00:00
175e0b54b3
testing: fix flake in test_ping_timeout
...
[ Folded 2 fixups --RR ]
2022-03-01 09:38:40 +10:30
c286eb053f
pyln-client: Plugin, improve background comment
2022-03-01 09:38:40 +10:30
ad22535d34
pyln-testing: improve description of wait_for_logs
2022-03-01 09:38:40 +10:30
84bead9396
pyln-testing: in LightningNode.openchannel, make wait_for_announce more reliable
...
it now waits for 'alias' in node_announcement, not just block confirms.
more cleanup
2022-03-01 09:38:40 +10:30
f84e1a0536
pyln-testing: in utils, update method fundbalancedchannel, now it also works with dualfund
...
and some cleanup, fundchannel has been returning tx, txid and outnum for years
2022-03-01 09:38:40 +10:30
2d06c38997
plugin-funder: fix typos in option lease-fee-base-msat and funder-fuzz-percent
...
Changelog-Experimental: option `--lease-fee-base-msat` renamed to `--lease-fee-base-sat`
Changelog-Experimental: option `--lease-fee-base-msat` deprecated and will be removed next release
2022-03-01 09:38:40 +10:30
0173717b6a
doc: add details about: log-level, experimental options and `features` field returned by listnodes,
...
listchannels and connect.
2022-03-01 09:38:40 +10:30
9bbb52097e
lightningd: fix parsing of option dev-force-features
...
It did not pick-up the last (bolt11) bits set.
2022-03-01 09:38:40 +10:30
905a85dc99
JSON-RPC: getinfo, add field `our_features`
...
All build flags and (experimental) options make it hard to find
out what features are supported or enabled.
And the undocumented `--list-features-only`, does not account for all
our featurebits, for example bit 55 (keysend).
Changelog-Added: JSON-RPC: `getinfo` result now includes `our_features` (bits) for various Bolt #9 contexts
2022-03-01 09:38:40 +10:30
32fb8a42fd
testing: cleanup in test_plugin_shutdown
2022-03-01 09:38:40 +10:30
760c271381
devtools: in decodemsg, add newline and fix decoding a node_announcement with tlvs
...
Terminal prompt got messed up because missing newline in case of empty fields.
printwire_addresses expected it to be the last field, which is not
the case of a node_announcement with tlv
2022-03-01 09:38:40 +10:30
05bd62fee4
configure: restore -Og default on non-developer builds.
...
Reverts change in 1ef77504b1
2022-02-28 14:42:41 -06:00
dd495b2b21
memleak: fix handling of excluded pointers.
...
We often hand an exclude pointer (usually the current command) to
memleak. But when we encountered this we would stop iterating, rather
than just ignore it: this means we would often ignore significant siblings.
In particular, fixing this (which has always been there) reveals many
previously-undetected leaks.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2022-02-27 07:44:26 +10:30
ea71e9fe5b
memleak: fix handling of notleak pointers.
...
We were ignoring the *parent* of the notleak pointers, not the notleak
pointer itself!
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2022-02-27 07:44:26 +10:30
fe86395e7c
memleak: restore functionality accidentally removed.
...
Accidentally removed in 6c9b752751
2022-02-27 07:44:26 +10:30
7081413e20
plugins/funder: actually free the pending_opens.
...
It's a small leak, but real.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2022-02-27 07:44:26 +10:30
d5064ff56c
libplugin: make memleak see current requests.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2022-02-27 07:44:26 +10:30
9bf2aa65cd
common/param: don't keep around the temporary array off cmd.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2022-02-27 07:44:26 +10:30
3218e5332f
common/param: fix leak with opt_param_def.
...
We allocate the default, then callback allocates over the top. Mark
params with a default, so we can free that when it's called.
(We can't do this generally, since not all param args are actually
pointers to pointers, though opt_param_def has to be).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2022-02-27 07:44:26 +10:30
f0ea4d60b9
onchaind: fix minor leaks.
...
Not actually leaks, but they do live longer than they need.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2022-02-27 07:44:26 +10:30
niftynei
Rusty Russell
Dustin Dettmer
Christian Decker
Simon Vrouwe