vincenzopalazzo
/
rgb-cln
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity
rgb-cln/lightningd
History
Vincenzo Palazzo 3a2b703ff8 jsonrpc: Remove the old "_msat" prefix in the listpeerchannels command 
This is a regression that we introduced in this release
due to some dirty parts of our codebase.

For historical reasons (I think), we were using a `json_add_sat_only`
procedure defined in `peer_control.c`. So when @rustyrussell removed the _msat,
we thought that all the fields were reflecting the new behavior, but
we were wrong.

This PR fixes this bug and also removes the additional function
from `peer_control.c`. This way, we can be sure that there is no other part
of our codebase that uses this method (except for other `json_add` methods).

Link: https://github.com/ElementsProject/lightning/issues/6244
Reported-by: @hMsats
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
 		2023-05-09 13:35:09 -07:00
..
test lightningd: create small hsm_sync_req() helper for hsm queries. 2023-04-10 17:26:47 +09:30
.gitignore Ignore all the deamon inside the git history 2021-10-28 15:51:38 +02:00
Makefile onchaind: use lightningd to sign and broadcast htlc_success transactions. 2023-04-07 11:49:09 +09:30
bitcoind.c plugins/bcli: use the new feerate levels, and the floor. 2023-04-10 07:31:12 +09:30
bitcoind.h lightningd: handle fees as blockcount + range. 2023-04-10 07:31:12 +09:30
chaintopology.c lightningd: expose default_locktime for wider usage. 2023-04-10 17:26:47 +09:30
chaintopology.h lightningd: expose default_locktime for wider usage. 2023-04-10 17:26:47 +09:30
channel.c lightningd: use channel_type as we're supposed to for forward descisions. 2023-04-10 17:26:47 +09:30
channel.h lightningd: remember depth of closing transaction. 2023-04-07 11:49:09 +09:30
channel_control.c lightningd: clean up feerate handling, deprecate old terms. 2023-04-10 07:31:12 +09:30
channel_control.h doc: update BOLTs to bc86304b4b0af5fd5ce9d24f74e2ebbceb7e2730 2022-09-12 09:34:52 +09:30
channel_state.h wallet: make it clear that `enum state_change` is in db. 2023-03-25 15:28:02 +10:30
closed_channel.c lightningd: add listclosedchannels command. 2023-03-25 15:28:02 +10:30
closed_channel.h lightningd: add listclosedchannels command. 2023-03-25 15:28:02 +10:30
closing_control.c lightningd: clarify uses of dynamic (mempool) feerate floor, and static. 2023-04-10 07:31:12 +09:30
closing_control.h lightningd: trace JSON id prefixes through sendrawtx. 2022-09-16 12:31:45 +09:30
coin_mvts.c lightningd: use hash map for peers instead of linked list. 2023-01-21 08:05:31 -06:00
coin_mvts.h coin_mvt: tiny, dont import lightningd header 2022-02-07 13:02:09 +10:30
connect_control.c connectd: dev-report-fds to do file descriptor audit. 2023-04-10 09:41:56 +09:30
connect_control.h lightningd: tell connectd we're shutting down. 2023-02-05 20:40:47 +01:00
datastore.c lightningd: unescape JSON strings for db. 2023-02-11 12:22:40 -06:00
dual_open_control.c Update libwally to 0.8.8, support PSBTv2 2023-03-23 16:10:55 +10:30
dual_open_control.h lightningd: prepare internal json routines for listpeerchannels. 2023-01-13 10:42:42 +10:30
feerate.c lightningd: allow "NNblocks" and "minimum" as feerates. 2023-04-10 07:31:12 +09:30
feerate.h lightningd: clean up feerate handling, deprecate old terms. 2023-04-10 07:31:12 +09:30
gossip_control.c cleanup: rename json_add_amount_msat_only to json_add_amount_msat 2023-03-18 15:55:49 +10:30
gossip_control.h gossipd: batch outpoints spent, add block height. 2022-09-24 15:22:27 +09:30
hsm_control.c lightningd: create small hsm_sync_req() helper for hsm queries. 2023-04-10 17:26:47 +09:30
hsm_control.h lightningd: create small hsm_sync_req() helper for hsm queries. 2023-04-10 17:26:47 +09:30
htlc_end.c channeld: don't calculate blinding shared secret, let lightningd do it. 2022-10-26 11:29:06 +10:30
htlc_end.h channeld: don't calculate blinding shared secret, let lightningd do it. 2022-10-26 11:29:06 +10:30
htlc_set.c Makefile: update bolts a0bbe47b0278b4f152dbaa4f5fab2562413a217c 2023-04-07 21:22:56 +09:30
htlc_set.h Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES 2020-09-08 09:42:00 +09:30
invoice.c lightningd: create small hsm_sync_req() helper for hsm queries. 2023-04-10 17:26:47 +09:30
invoice.h Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES 2020-09-08 09:42:00 +09:30
io_loop_with_timers.c database: pull out database code into a new module 2022-03-05 15:03:34 +10:30
io_loop_with_timers.h lightningd/io_loop_with_timers.c: Move mainloop to its own source file, have chaintopology use it. 2019-05-31 17:57:10 +02:00
jsonrpc.c lightningd: require "jsonrpc": "2.0" as per JSONRPC spec. 2023-03-18 15:55:49 +10:30
jsonrpc.h lightningd: only use non-numeric JSON ids if plugin says we can. 2022-11-21 11:23:54 +01:00
lightningd.c lightningd: fix 100% CPU hang on shutdown. 2023-04-13 09:03:13 +09:30
lightningd.h plugins/bcli: move commit-fee (dev-max-fee-multiplier) and into core. 2023-04-10 07:31:12 +09:30
log.c common: expose node_id_hash functions. 2023-01-21 08:05:31 -06:00
log.h options: let log-level subsystem filter also cover nodeid. 2022-07-09 09:59:52 +09:30
log_status.c check: make sure all files outside contrib/ include "config.h" first. 2021-12-06 10:05:39 +10:30
log_status.h cleanup: remove unneeded includes in header files. 2021-09-17 09:43:22 +09:30
memdump.c lightningd: fix parent reporting for memleaks. 2023-04-10 17:26:47 +09:30
memdump.h lightningd: simplify memleak code. 2022-03-10 09:40:09 +10:30
notification.c cleanup: rename json_add_amount_msat_only to json_add_amount_msat 2023-03-18 15:55:49 +10:30
notification.h jsonrpc: make error codes an enum. 2022-09-19 10:18:55 +09:30
offer.c lightningd: create small hsm_sync_req() helper for hsm queries. 2023-04-10 17:26:47 +09:30
onchain_control.c lightningd: create small hsm_sync_req() helper for hsm queries. 2023-04-10 17:26:47 +09:30
onchain_control.h onchaind: remove 'is_replay' logic 2021-12-28 04:42:42 +10:30
onion_message.c common: update to latest onion-message spec. 2023-01-30 13:24:29 +10:30
onion_message.h common: remove support for pre v0.10.2 onionmessages. 2021-12-01 05:44:28 +10:30
opening_common.c lightningd: create small hsm_sync_req() helper for hsm queries. 2023-04-10 17:26:47 +09:30
opening_common.h openingd: Add `reserve` to `fundchannel` and `multifundchannel` 2022-09-21 11:25:47 +02:00
opening_control.c common/channel_type: routines to set known variants, set scid_alias. 2023-04-10 17:26:47 +09:30
opening_control.h lightningd: prepare internal json routines for listpeerchannels. 2023-01-13 10:42:42 +10:30
options.c plugins/bcli: move commit-fee (dev-max-fee-multiplier) and into core. 2023-04-10 07:31:12 +09:30
options.h opts: adds the autobool on/off/auto feature 2023-01-25 14:37:56 +01:00
pay.c Makefile: update bolts a0bbe47b0278b4f152dbaa4f5fab2562413a217c 2023-04-07 21:22:56 +09:30
pay.h jsonrpc: make error codes an enum. 2022-09-19 10:18:55 +09:30
peer_control.c jsonrpc: Remove the old "_msat" prefix in the listpeerchannels command 2023-05-09 13:35:09 -07:00
peer_control.h listpeerchannels: add channel_type, both in hex and as array of names. 2023-03-25 15:28:02 +10:30
peer_fd.c subdaemons: remove gossipd fd from per-peer daemons. 2022-02-08 11:15:52 +10:30
peer_fd.h subdaemons: remove gossipd fd from per-peer daemons. 2022-02-08 11:15:52 +10:30
peer_htlcs.c ld: Add a couple of logging statements when forwarding 2023-04-11 11:22:30 +09:30
peer_htlcs.h lightningd: fix valgrind reported leak when we exit early. 2023-01-17 14:13:45 +10:30
ping.c common: clean up json routine locations. 2022-07-15 12:24:00 -05:00
plugin.c lightningd: treat JSON ids as direct tokens. 2023-01-11 11:13:27 +10:30
plugin.h lightningd: correctly exit when an important-plugin fails to start. 2022-11-30 15:47:31 +01:00
plugin_control.c lightningd: wire plugin command JSON id through to plugin commands. 2022-09-16 12:31:45 +09:30
plugin_control.h plugins: add `command` field to subcommand output. 2021-06-25 09:49:33 +09:30
plugin_hook.c lightningd: don't call memcpy with NULL. 2023-01-12 11:44:10 +10:30
plugin_hook.h plugin: wire JSON id for commands which caused hooks to fire. 2022-09-16 12:31:45 +09:30
routehint.c lightnind: use aliases in routehints for private channels. 2022-08-09 16:31:36 -05:00
routehint.h invoice: overhaul routehints to use topology.listincoming, cleanup. 2021-06-16 10:29:17 +09:30
signmessage.c lightningd: create small hsm_sync_req() helper for hsm queries. 2023-04-10 17:26:47 +09:30
subd.c lightningd: more graceful shutdown. 2022-09-12 14:00:41 +02:00
subd.h lightningd: more graceful shutdown. 2022-09-12 14:00:41 +02:00
watch.c lightningd/chaintopology: ensure htables are always tal objects. 2023-01-12 11:44:10 +10:30
watch.h Remove names of parameters of callbacks which confuse gcc. 2022-08-31 12:18:28 +03:00