vincenzopalazzo
/
rgb-cln
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity
rgb-cln/lightningd
History
Rusty Russell 0056dd7557 lightningd: disallow --daemon without --log-file. 
From #clightning:

    (11:24:10) andytoshi: hiya, i'm trying to set up a new lightningd node, and when i run lightningd --network=bitcoin --log-level=debug --daemon
    (11:24:17) andytoshi: i get errors of the form fetchinvoice: Malformed JSON reply '2021-01-25T00:51:16.655Z DEBUG   plugin-offers: disabled itself at init: offers not enabled in config
    (11:24:43) andytoshi: there are a couple variants of this, but always some form of "something: failed to parse <a log line> as json"

Indeed, we close stdout, and it ends up being reused for some plugin.
But the real problem is that we log to stdout by default, which doesn't
make sense.  If they really want to discard logs, they can use
--log-file=/dev/null.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: JSON failures when --daemon is used without --log-file.
 		2021-02-01 09:57:54 +10:30
..
test offers: make it a runtime option. 2021-01-13 14:45:36 +01:00
.gitignore dualopend: new `dualopend` daemon, containing most of accepter side 2020-09-09 19:54:20 +09:30
Makefile offers: make it a runtime option. 2021-01-13 14:45:36 +01:00
bitcoind.c bitcoind: remove v0.9.0-compat for rejecting sendrawtransaction arg. 2021-02-01 09:57:35 +10:30
bitcoind.h plugins/bcli.c: `sendrawtransaction` now has a required `allowhighfees` argument. 2020-09-09 12:38:19 +09:30
chaintopology.c chaintopology: fix crash if bcli doesn't include errmsg. 2021-01-07 19:32:47 +01:00
chaintopology.h plugins/bcli.c: `sendrawtransaction` now has a required `allowhighfees` argument. 2020-09-09 12:38:19 +09:30
channel.c df-tests: test_channel_state_changed_bilateral 2021-01-10 13:44:04 +01:00
channel.h db: add flag to database for recving remote's sigs 2021-01-10 13:44:04 +01:00
channel_control.c df: handle locked in etc in dualopend 2021-01-10 13:44:04 +01:00
channel_control.h channel_fallen_behind: break out functionality into two methods 2021-01-10 13:44:04 +01:00
channel_state.h channel-state: add two new states, for dualopend 2021-01-10 13:44:04 +01:00
closing_control.c subd: keep track of 'channel's type 2021-01-10 13:44:04 +01:00
closing_control.h common/per_per_state: generalize lightningd/peer_comm Part 1 2019-06-04 01:29:39 +00:00
coin_mvts.c channel_id: save to database, dont derive from funding_txid 2020-09-09 19:54:20 +09:30
coin_mvts.h coins: re-write API interface for htlc notices 2020-05-12 15:46:58 +09:30
connect_control.c connectd: implement connection timeout (60 seconds). 2020-09-11 21:27:45 +09:30
connect_control.h lightningd: return `features` in connect response. 2020-04-03 13:13:21 +10:30
dual_open_control.c chore: fix typo in openchannel hook log 2021-02-01 09:57:15 +10:30
dual_open_control.h df: reinitialize dual-funding 2021-01-10 13:44:04 +01:00
gossip_control.c lightningd: control onion messages by `experimental-onion-messages` option. 2021-01-13 14:45:36 +01:00
gossip_control.h gossipd: get fed the blockheight from lightningd when we know it. 2019-09-25 04:01:56 +00:00
gossip_msg.c wire: make fromwire_fail return non-const, use it more 2020-05-20 11:36:13 +02:00
gossip_msg.h gossipd: return channel_announcement features for listchannels. 2020-05-07 08:44:58 +09:30
hsm_control.c hsmd: cleanup encrypted hsm_secret detection 2021-01-06 13:50:01 +01:00
hsm_control.h hsm: decouple hsm from wallet; init before wallet 2020-06-11 13:13:13 +02:00
htlc_end.c coins: have `we_fulfilled` be fully 'ternary' 2020-05-12 15:46:58 +09:30
htlc_end.h common/sphinx: make TOTAL_PACKET_SIZE a macro. 2020-12-11 15:51:24 +01:00
htlc_set.c lightningd: note whether payment secret is used or not. 2020-10-28 12:03:14 +01:00
htlc_set.h Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES 2020-09-08 09:42:00 +09:30
invoice.c offers: make it a runtime option. 2021-01-13 14:45:36 +01:00
invoice.h Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES 2020-09-08 09:42:00 +09:30
io_loop_with_timers.c plugins: don't crash if getmanifest times out. 2019-07-24 16:16:53 +02:00
io_loop_with_timers.h lightningd/io_loop_with_timers.c: Move mainloop to its own source file, have chaintopology use it. 2019-05-31 17:57:10 +02:00
json.c json_command: command_fail_badparam helper. 2020-09-02 09:46:37 +09:30
json.h common: hoist param_bitcoin_address where plugins can use it. 2020-08-11 08:39:24 +09:30
jsonrpc.c jsonrpc: Forward errors on malformed requests to cli 2020-12-09 06:56:21 +10:30
jsonrpc.h lightningd: infrastructure for internal notifications. 2020-10-23 13:53:16 +10:30
lightningd.c open_command: keep them local to channel 2021-01-10 13:44:04 +01:00
lightningd.h offers: make it a runtime option. 2021-01-13 14:45:36 +01:00
log.c lightningd/log.c: Fix up handling of SIGHUP. 2020-12-02 16:48:48 +10:30
log.h lightningd: use a simple array for less memory usage. 2019-11-18 04:50:22 +00:00
log_status.c common: convert to new wire generation style. 2020-08-25 12:53:13 +09:30
log_status.h lightningd: have logging include an optional node_id for each entry. 2019-11-18 04:50:22 +00:00
memdump.c common/memleak: simplify and document API. 2020-09-23 13:52:49 +09:30
memdump.h lightningd: add code to search strmaps for memleak detection. 2019-02-07 20:33:50 +00:00
notification.c df: add a new 'channel_open_failed' notification 2021-01-10 13:44:04 +01:00
notification.h df: add a new 'channel_open_failed' notification 2021-01-10 13:44:04 +01:00
offer.c fetchinvoice: check we're in the period before attempting to fetch. 2021-01-09 14:34:35 +10:30
onchain_control.c subd: keep track of 'channel's type 2021-01-10 13:44:04 +01:00
onchain_control.h closingd: convert to new wire generation style. 2020-08-25 12:53:13 +09:30
onion_message.c lightningd: control onion messages by `experimental-onion-messages` option. 2021-01-13 14:45:36 +01:00
onion_message.h gossipd, channeld: handle onion messages in gossipd so we don't need a channel. 2021-01-09 14:34:35 +10:30
opening_common.c df: rename the dual_open wires to match other daemon wires 2020-12-02 14:19:08 +10:30
opening_common.h openingd/: Fail `fundchannel_start` if we already are, or will become, the fundee. 2020-11-07 17:18:49 +00:00
opening_control.c chore: fix typo in openchannel hook log 2021-02-01 09:57:15 +10:30
opening_control.h memleak: 'generify' the memleak calling to code for openingd/dualopend 2020-09-17 10:12:08 +09:30
options.c lightningd: disallow --daemon without --log-file. 2021-02-01 09:57:54 +10:30
options.h common: parse --allow-deprecated-apis extremely early. 2019-11-23 22:42:34 +00:00
pay.c listsendpays: remove deprecated "null" amount_msat. 2021-02-01 09:57:35 +10:30
pay.h lightningd: don't report spurious temporary_node_failure on local failures. 2020-05-04 18:56:33 +09:30
peer_control.c chore: cleanup some nits 2021-02-01 09:57:15 +10:30
peer_control.h open_command: keep them local to channel 2021-01-10 13:44:04 +01:00
peer_htlcs.c autodata: requests new line number, please 2021-01-10 13:44:04 +01:00
peer_htlcs.h lightningd: separate fee_states out of struct channel_info. 2020-09-23 15:51:13 +09:30
ping.c gossipd: convert wire to new scheme. 2020-08-25 12:53:13 +09:30
ping.h ping: complete JSON RPC ping commands even if one ping gets no response. 2018-09-14 22:11:23 +02:00
plugin.c plugins: allow plugins to disable themselves at startup. 2021-01-13 14:45:36 +01:00
plugin.h Plugin: support extra args to "start". 2020-12-15 09:28:56 +10:30
plugin_control.c Plugin: support extra args to "start". 2020-12-15 09:28:56 +10:30
plugin_control.h lightningd: attach plugins natively to the command which started it. 2020-05-05 13:45:17 +09:30
plugin_hook.c lightningd/plugin_hook.c: Make `db_write` a chained hook. 2020-11-30 10:40:11 +10:30
plugin_hook.h plugins: check order once all plugins have returned from getmanifest. 2020-11-09 15:22:33 -06:00
routehint.c lightningd: extract routehint selection code. 2020-09-08 19:47:11 +09:30
routehint.h lightningd: extract routehint selection code. 2020-09-08 19:47:11 +09:30
signmessage.c gossipd: convert wire to new scheme. 2020-08-25 12:53:13 +09:30
subd.c subd: keep track of 'channel's type 2021-01-10 13:44:04 +01:00
subd.h subd: keep track of 'channel's type 2021-01-10 13:44:04 +01:00
watch.c wallet: remove edgecase around transaction checks 2020-01-02 16:56:42 +01:00
watch.h lightningd: fix occasional missing txid detection. 2019-06-28 03:31:43 +00:00