From 522560b82f0b6e138d9fd7fcecc2d90d1b8fbf5f Mon Sep 17 00:00:00 2001 From: John Kacur Date: Wed, 27 Jan 2010 19:47:03 +0100 Subject: [PATCH] rt-tests: Remove the ret variable, the end label and the goto. Remove the ret variable, the end lable and the goto. We already have inconsistent exit points for the function, and the end lable wasn't strictly for errors. Directly returning simplifies and shortens the code. Signed-off-by: John Kacur --- src/cyclictest/rt_numa.h | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/cyclictest/rt_numa.h b/src/cyclictest/rt_numa.h index 8d44097..ac2aca2 100644 --- a/src/cyclictest/rt_numa.h +++ b/src/cyclictest/rt_numa.h @@ -73,7 +73,7 @@ static int rt_numa_numa_node_of_cpu(int cpu) static int rt_numa_numa_node_of_cpu(int cpu) { unsigned char cpumask[16]; - int node, ret, idx, bit; + int node, idx, bit; int max_node, max_cpus; max_node = numa_max_node(); @@ -88,19 +88,15 @@ static int rt_numa_numa_node_of_cpu(int cpu) idx = cpu / 8; bit = cpu % 8; - for (node = 0; node <= max_node; node++){ + for (node = 0; node <= max_node; node++) { if (numa_node_to_cpus(node, (void *) cpumask, sizeof(cpumask))) return -1; - if (cpumask[idx] & (1<