bridge config: Add a TODO about a redundant clone

2022-11-30 15:09:58 +00:00 · 2022-11-30 15:09:58 +00:00 · e4ac39e638
parent 429d2c7cb7
commit e4ac39e638
1 changed files with 3 additions and 0 deletions
--- a/crates/tor-guardmgr/src/bridge/config.rs
+++ b/crates/tor-guardmgr/src/bridge/config.rs
@ -370,6 +370,9 @@ impl FromStr for BridgeConfigBuilder {
                let (transport, addr, settings) = target.into_parts();
                let addr: Option<BridgeAddr> = addr.into();
                let addrs = addr.into_iter().collect_vec();
+                // TODO transport.to_string() clones transport and then drops it
+                // PtTransportName::into_inner ought to exist but was deleted
+                // in 119e5f6f754251e0d2db7731f9a7044764f4653e
                (transport.to_string(), addrs, settings.into_inner())
            }
            other => {