Commit Graph

7914 Commits

Author SHA1 Message Date
Ian Jackson 98e3d7ac56 dev notes: Draft IPT algorithm: Possible fixed descriptor lifetimes
Prompted by
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924501
2023-07-26 12:21:34 +01:00
Ian Jackson 36cf899dd9 dev notes: Draft IPT algorithm: Add a publication rate limit
Prompted by
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924499
2023-07-26 12:21:34 +01:00
Ian Jackson 0b928f8a5b dev notes: Draft IPT algorithm: Add a TODO re selecting from >N IPTs
Prompted by
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924498
2023-07-26 12:21:34 +01:00
Ian Jackson 348aab8166 dev notes: Draft IPT algorithm: Added 2N IPT limit to tuning params
Prompted by
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924496
2023-07-26 12:21:34 +01:00
Ian Jackson a0d0a90b2b dev notes: Draft IPT algorithm: Delay IPT replacement
Prompted by
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924497
2023-07-26 12:21:34 +01:00
Ian Jackson 360bf843ae dev notes: Draft IPT algorithm: Early descriptor publish timing
Prompted by
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924494
2023-07-26 12:21:34 +01:00
Ian Jackson f050309c60 dev notes: Draft IPT algorithm: Retire IPTs - note re Onion Balance
Prompted by
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924487
2023-07-26 12:21:34 +01:00
Ian Jackson e9935ce2bc dev notes: Draft IPT algorithm: Retire IPTs - timing question
Prompted by
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924485
2023-07-26 12:21:34 +01:00
Ian Jackson 3807b43791 dev notes: Draft IPT algorithm: Retire IPTs after N introductions
Prompted by
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924485
2023-07-26 12:21:34 +01:00
Ian Jackson 75cc7ccf22 dev notes: Draft IPT algorithm: note re unpublished IPT
Prompted by
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924483
2023-07-26 12:21:34 +01:00
Ian Jackson 35a1e269c4 dev notes: Draft IPT algorithm: note re intro pt verification
Discussions here:
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924481
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924495
2023-07-26 12:21:34 +01:00
Ian Jackson 30e25af0a0 Merge branch 'typos' into 'main'
Fix typos

See merge request tpo/core/arti!1436
2023-07-26 10:21:27 +00:00
Ian Jackson 86e76c1100 Merge branch 'sw1tch/fix_reconfigure_deadlock' into 'main'
fixes deadlock in TorClient::reconfigure

See merge request tpo/core/arti!1432
2023-07-26 10:20:49 +00:00
Dimitris Apostolou c466edaa07
Fix typos 2023-07-25 21:17:18 +03:00
sw1tch b6873a9b84 pass reconfigure_lock guard into TorClient::reconfigure_inner 2023-07-25 19:31:36 +02:00
Nick Mathewson 2833648bfb Merge branch 'ipts' into 'main'
dev notes: Draft IPT algorithm

See merge request tpo/core/arti!1429
2023-07-25 16:29:38 +00:00
Nick Mathewson 6f841d0fb8 Merge branch 'onion-service-notes-v1' into 'main'
Initial notes about onion service structs and APIs

See merge request tpo/core/arti!1422
2023-07-25 16:29:28 +00:00
gabi-250 e3d2e12624 Merge branch 'keymgr-keygen-key-list' into 'main'
keymgr-doc: Document the list of keys the keymgr needs to generate.

See merge request tpo/core/arti!1413
2023-07-25 10:51:01 +00:00
Ian Jackson 965aab96b9 Merge branch 'safer_build' into 'main'
Add `doc/safer_build.md` to explain path anonymization

Closes #957

See merge request tpo/core/arti!1435
2023-07-25 10:44:51 +00:00
Nick Mathewson 7347a25ab1 Change keyid to nickname 2023-07-24 12:22:46 -04:00
Nick Mathewson 4f5fb5c011 Mention anti-DOS options. 2023-07-24 12:19:43 -04:00
Nick Mathewson 75038d8348 Mention ob_config. Not sure we will want to build it like this. 2023-07-24 12:18:21 -04:00
Nick Mathewson 7166c9e5b5 Add `doc/safer_build.md` to explain path anonymization
Otherwise our default build instructions will lead people
to build binaries that include their home directory.

Closes #957 for now.
2023-07-24 09:34:40 -04:00
Nick Mathewson f400ba2925 Merge branch 'fmt' into 'main'
Run cargo +nightly fmt to format many let ... else ...

See merge request tpo/core/arti!1434
2023-07-24 13:19:36 +00:00
sw1tch 7347d45acc cargo fmt 2023-07-24 14:48:19 +02:00
Ian Jackson 3e2a909707 Run cargo +nightly fmt to format many let ... else ...
rustfmt has grown opinions about how let ... else ... ought to be
formatted.  They don't always agree with our previous manual
decisions.

I think our policy is to always insist on rustfmt.  When that version
of rustfmt hits stable, our CI will start to fail for everyone.
(Right now this discrepancy just causes trouble for contributors who
are using nightly by default.)
2023-07-24 13:46:05 +01:00
Gabriela Moldovan 89dc3a162a
keymgr: Move duplicated match block to KeyMgr::select_keystore(). 2023-07-24 13:17:35 +01:00
Gabriela Moldovan f96298a791
keymgr: Add KeyMgr::generate() for generating new keys. 2023-07-24 13:17:31 +01:00
Gabriela Moldovan 9c326ced81
keymgr: Add function for generating EncodableKeys. 2023-07-24 13:17:23 +01:00
Gabriela Moldovan f5f133c04c
keymgr: Test whether insert() creates the missing directories. 2023-07-24 13:17:16 +01:00
Gabriela Moldovan b9f3ba5885
keymgr: Return an unimplemented error instead of panicking.
This will enable us to test the parts of `ArtiNativeKeystore::insert`
that _are_ implemented (such as the part where it creates the missing
directories).
2023-07-24 13:17:12 +01:00
Gabriela Moldovan cfe90f1478
keymgr: Create the parent directories as needed 2023-07-24 13:17:08 +01:00
Gabriela Moldovan e36e7db6e7
keymgr: Add a Keystore::contains accessor. 2023-07-24 13:17:05 +01:00
sw1tch 3eee408985 fixes deadlock in TorClient::reconfigure 2023-07-24 13:39:49 +02:00
Nick Mathewson 19f097d1fa Merge branch 'typos' into 'main'
Fix typos

See merge request tpo/core/arti!1431
2023-07-22 14:08:24 +00:00
Dimitris Apostolou 947ddfff0c
Fix typos 2023-07-22 10:10:34 +03:00
gabi-250 15407a1a7e Merge branch 'keymgr-api-updates' into 'main'
keymgr: API updates and other improvements

Closes #903

See merge request tpo/core/arti!1421
2023-07-21 16:22:56 +00:00
gabi-250 3ceff307bf Merge branch 'keymgr-api-updates-minor-fixes' into 'keymgr-api-updates'
Keymgr api updates minor fixes

See merge request gabi-250/arti!1
2023-07-21 15:54:52 +00:00
gabi-250 f735583eca Merge branch 'keymgr-api-updates-more-fixes' into 'keymgr-api-updates'
Address review comments

See merge request gabi-250/arti!5
2023-07-21 15:47:44 +00:00
Ian Jackson 611576c515 Merge branch 'access' into 'main'
Add getters to a couple of config builders

See merge request tpo/core/arti!1425
2023-07-21 15:10:31 +00:00
gabi-250 eeca8e36aa Merge branch 'warn' into 'main'
tor-geoip: Fix a doc warning

See merge request tpo/core/arti!1430
2023-07-21 14:25:16 +00:00
Ian Jackson f00ac8e747 tor-geoip: Fix a doc warning
cargo doc --locked --document-private-items --workspace --all-features

warning: unclosed HTML tag `CountryCode`
  --> crates/tor-geoip/src/lib.rs:90:54
   |
90 |     /// We store these as NonZeroU8 so that an Option<CountryCode> only has to
   |                                                      ^^^^^^^^^^^^^
   |
   = note: `#[warn(rustdoc::invalid_html_tags)]` on by default
2023-07-21 14:44:14 +01:00
Ian Jackson a92627418d dev notes: Draft IPT algorithm 2023-07-21 13:20:34 +01:00
Gabriela Moldovan 96e59cb97f
keymgr: Use KeystoreId instead of a static string. 2023-07-21 12:36:29 +01:00
Gabriela Moldovan 32083cbd51
keymgr: Add a newtype for keystore identifiers. 2023-07-21 12:36:22 +01:00
Gabriela Moldovan ec82795614
keymgr, tor-error: Remove unused error type and HasKind. 2023-07-21 12:36:19 +01:00
Gabriela Moldovan c7d29dfc3d
keymgr: Use BadApiUsage instead of KeystoreMisuse.
Trying to use a keystore that doesn't exist is `bad_api_usage!`.
2023-07-21 12:36:16 +01:00
Gabriela Moldovan d48cc2ca6b
keymgr: Remove unused KeystoreSelector::All variant.
This also removes the corresponding
`KeyMgrError::UnsupportedKeystoreSelector` error, because it's not
needed anymore.
2023-07-21 12:36:13 +01:00
Gabriela Moldovan a4c5edd165
Revert "keymgr: Require callers to be explicit about which keystore to get keys from." (fmt) 2023-07-21 12:21:39 +01:00
Gabriela Moldovan 98337afec9
Revert "keymgr: Require callers to be explicit about which keystore to get keys from."
This reverts commit 38a6c74c78.

This also updates some tests to make them compile with the reverted
version of the code.
2023-07-21 12:21:36 +01:00