582f1463d6
dirclient: refactor and test "should-i-retire-the-circuit" code.
2022-02-01 09:54:47 -05:00
36069fc2d0
dirclient: Add tests for a number of failing cases.
...
These bring the case a tiny improvement in test coverage, and also
manage to turn up a few bugs.
2022-02-01 09:54:47 -05:00
7fdde559d4
dirclient: don't return too-long responses on decompression failure
...
There are a couple of places where we forgot to truncate our
return-buffer to its actual size, and instead returned a big bunch
of zeros. Found while writing the tests in the next commit.
Someday, we'll have ReadBuf and won't have to worry about these
things.
2022-02-01 09:54:47 -05:00
81a49fb6ec
Merge branch 'dedup-cobertura' into 'main'
...
add postprocessing script to deduplicate cobertura reports
See merge request tpo/core/arti!272
2022-01-31 17:19:01 +00:00
a7df9ca0a5
Tweak release instructions based on 0.0.4 experience
2022-01-31 11:35:40 -05:00
329bde58dd
Bump tor-netdir and tor-guardmgr versions
...
tor-netdir needs to bump because tor-netdoc bumped, even though
there were no other changes in tor-netdir. Whoops.
tor-guardmgr needs to bump because it already published, with the
older tor-netdir.
2022-01-31 11:05:34 -05:00
01d9937308
Bump the patch version of every crate that changed since 0.0.3
2022-01-31 10:30:52 -05:00
d3039d805d
Update changed_crates to be more useful.
2022-01-31 10:30:50 -05:00
64fde906f9
Mention shellcheck patch in changelog.
2022-01-31 10:29:17 -05:00
74838b7ba0
Changelog for 0.0.4.
2022-01-31 08:52:35 -05:00
880d5f2d36
Merge branch 'shellcheck' into 'main'
...
Add shellcheck to gitlab ci and git hook
See merge request tpo/core/arti!275
2022-01-31 13:02:36 +00:00
7f83b9fb30
maint/shellcheck_all.sh: add missing final newline
2022-01-31 12:44:27 +00:00
42fb7667b4
Change which command to command -v
2022-01-29 00:12:36 +01:00
1774de7e47
Remove redundancy/code duplication and switch to shellcheck_all.sh script
2022-01-29 00:09:36 +01:00
21a9ad848c
Add shellcheck script into maint directory
2022-01-29 00:09:06 +01:00
daa1eba969
add postprocessing script to deduplicate cobertura reports
2022-01-28 20:52:50 +01:00
1d7fcd6d48
Undo remove document-private-items arg
2022-01-28 17:44:32 +01:00
01b3bc85c9
Remove argument document-private-items from nightly build
2022-01-28 17:28:25 +01:00
67ac91a809
Add missing file ending for downgrade_dependencies in gitlab ci
2022-01-28 15:26:14 +01:00
09ccc1aed9
Add shellcheck to pre-push git hook
2022-01-28 15:21:47 +01:00
6fe0543645
Add shellcheck step into build stage
2022-01-28 15:21:28 +01:00
0fed438a58
Add correct file ending to maint/downgrade_dependencies
2022-01-28 15:20:54 +01:00
af40fa4d74
WANT_FROM_OTHER_CRATES: add a few links.
2022-01-28 09:12:41 -05:00
2f51add62f
Run "cargo update" in preparation for monday's release.
2022-01-28 08:38:54 -05:00
5187b05c19
Use script to update README.md files.
2022-01-28 08:36:34 -05:00
427e07ec8a
Merge branch 'bug299' into 'main'
...
Make max_file_limit configurable
Closes #299
See merge request tpo/core/arti!261
2022-01-28 11:17:49 +00:00
417809123c
Make max_file_limit configurable
2022-01-28 11:17:49 +00:00
54bdab588a
Merge branch 'improve-coverage-ci-job' into 'main'
...
Improve `coverage` job in CI
See merge request tpo/core/arti!269
2022-01-28 00:28:07 +00:00
72a08cc295
Improve `coverage` job in CI
2022-01-28 00:28:06 +00:00
c5fa23b336
Merge branch 'dirmgr_state_test_fix' into 'main'
...
Fix test failure in tor_dirmgr::state::test::get_microdescs_state
See merge request tpo/core/arti!268
2022-01-27 22:36:31 +00:00
98d8171610
Fix test failure in tor_dirmgr::state::test::get_microdescs_state
...
This failure occurred because our tests use canned data to exercise
the directory state functionality, and the canned consensus has
suddenly become very expired.
There are better fixes possible, but this is a minimal one that
should get CI working on main again.
2022-01-27 17:13:38 -05:00
c9feb3803b
Merge branch 'shellcheck_teardown' into 'main'
...
Fix/suppress shellcheck errors in teardown.sh
See merge request tpo/core/arti!266
2022-01-27 21:32:59 +00:00
bc867fed65
Merge branch 'rtcompat_tests' into 'main'
...
Unit test cleanup in tor-rtcompat
See merge request tpo/core/arti!267
2022-01-27 21:25:53 +00:00
19f878b3aa
tor-rtcompat: remove some unused code.
...
Nothing actually used these accessor functions, and it's not clear
what would. We can add them later if they're needed.
2022-01-27 15:52:59 -05:00
f7373f8b20
tor-rtcompat: Add some miscellaneous tests
...
These probably aren't for things that will fail IRL, but it's nice
to have coverage on the code, just in case.
2022-01-27 15:48:30 -05:00
af85262257
tor-rtcompat: Simplify test-declaration macros.
...
Now there's much less copy-and-paste.
2022-01-27 15:09:09 -05:00
9435e4b36e
Move tor-rtcompat tests to lib.rs
...
This makes our layout more similar to our other crates, and
successfully informs our grcov exclusion pattern that these tests
are indeed tests.
Doing this knocks down the reported coverage for the tor-rtcompat
crate, but that's okay: we hadn't earned it.
I hereby promise that this commit is only code-movement.
2022-01-27 14:45:00 -05:00
83a01725d7
Fix/suppress shellcheck errors in teardown.sh
...
Rationale: It's good to have all of our scripts pass shellcheck.
2022-01-27 14:24:12 -05:00
1c620019c4
Merge branch 'eta/303' into 'main'
...
doc/Release.md: add note to check feature combinations
See merge request tpo/core/arti!265
2022-01-27 18:33:43 +00:00
aa9e5515d8
with_coverage: resolve a shellcheck warning
...
Shellcheck doesn't like it when you do `rm -r "$A/$B"` : it worries
that the path might accidentally expand to /.
That shouldn't actually be possible in this case, but let's avoid
being the people who accidentally remove somebody's filesystem.
2022-01-27 12:19:35 -05:00
5b6b0d6a7d
Once more exclude arti-bench from coverage.
...
This was added in !210 ; looks like it got removed by mistake with
!221 .
2022-01-27 12:14:32 -05:00
40c67e5e20
with_coverage.sh: split grcov options into separate lines.
...
This makes it easier to see when they're changing, and will make
future patches easier to review.
2022-01-27 12:09:20 -05:00
ecb63bafa5
doc/Release.md: add note to check feature combinations
...
This is a nice reminder to have before we solve arti#303 for good.
2022-01-27 15:53:46 +00:00
2f39dbd587
Merge branch 'rtcompat-refactor' into 'main'
...
Refactor the tor-rtcompat API.
Closes #301 and #300
See merge request tpo/core/arti!263
2022-01-27 15:53:35 +00:00
9f3ad85d75
Document why {current,create}_runtime are type-erased
2022-01-27 10:31:45 -05:00
c4321289f2
Apply @eta's suggestions from review on !263
...
Comment-only.
2022-01-27 15:25:57 +00:00
785ad605d7
Merge branch 'coverage-tracking' into 'main'
...
Add test coverage tracking with CI/CD
Closes #250
See merge request tpo/core/arti!221
2022-01-27 12:56:22 +00:00
899691e5c7
Install bs4 in coverage job
2022-01-26 23:48:11 -06:00
b3ba32824e
Use `maint/with_coverage.sh` in coverage job
2022-01-26 23:13:15 -06:00
3213b89390
Add changes in `maint`
...
Follows up on changes from https://gitlab.torproject.org/trinity-1686a/arti/-/merge_requests/2/diffs#bc2cc73a8917fa6fed183148df69119665eb4e55
2022-01-26 22:46:45 -06:00
Nick Mathewson
Ian Jackson
Ian Jackson
Daniel Schischkin
trinity-1686a
Neel Chauhan
eta
arturomf94