Nick Mathewson
b4c3aaf362
Reload configuration when our configuration files change.
...
Closes #270
2022-02-01 16:04:53 -05:00
Nick Mathewson
610ccb3040
Un-Arc<> TorClient in the arti crate
...
TorClient doesn't need to be wrapped in an Arc any longer, thanks
to other refactoring.
2022-02-01 14:43:31 -05:00
Nick Mathewson
feab848509
arti_config: Refactor configuration sources into a struct
...
This is by no means our final API, but should represent an
improvement. Here instead of having to specify a list of files and
their is-this-optional status, along with a list of command-line
options, we have a single structure that encapsulates all of that
information.
Two advantages here:
- Callers no longer have to remember what the boolean means.
- We can "reload" more easily, by keeping the source object around.
This change also implements the correct behavior for our default
configuration file in `arti::main`: if the file is absent and the
user doesn't list a config file, that's no problem. But if the user
lists _that very same config file, we should insist that it be
present.
2022-02-01 14:26:39 -05:00
Nick Mathewson
487f3be6de
Expose Reconfigure enum from arti-client.
...
This enum is required to use `TorClient::reconfigure` correctly, and
as such ought to be re-exported.
2022-02-01 14:26:39 -05:00
Ian Jackson
a2f3ed4a03
Merge branch 'fix-invalid-windows-path' into 'main'
...
Fix invalid path character on windows
See merge request tpo/core/arti!277
2022-02-01 10:46:47 +00:00
Michael
334bba2ef2
Fix invalid path character on windows
2022-01-31 20:53:13 +00:00
eta
a71ab72bf2
Merge branch 'ci-rustup-show' into 'main'
...
CI: Add "rustup show" to show compiler versions in logs
See merge request tpo/core/arti!276
2022-01-31 18:33:22 +00:00
Nick Mathewson
81a49fb6ec
Merge branch 'dedup-cobertura' into 'main'
...
add postprocessing script to deduplicate cobertura reports
See merge request tpo/core/arti!272
2022-01-31 17:19:01 +00:00
Nick Mathewson
a7df9ca0a5
Tweak release instructions based on 0.0.4 experience
2022-01-31 11:35:40 -05:00
Nick Mathewson
329bde58dd
Bump tor-netdir and tor-guardmgr versions
...
tor-netdir needs to bump because tor-netdoc bumped, even though
there were no other changes in tor-netdir. Whoops.
tor-guardmgr needs to bump because it already published, with the
older tor-netdir.
2022-01-31 11:05:34 -05:00
Nick Mathewson
01d9937308
Bump the patch version of every crate that changed since 0.0.3
2022-01-31 10:30:52 -05:00
Nick Mathewson
d3039d805d
Update changed_crates to be more useful.
2022-01-31 10:30:50 -05:00
Nick Mathewson
64fde906f9
Mention shellcheck patch in changelog.
2022-01-31 10:29:17 -05:00
Ian Jackson
ac8e28b6c7
CI: Add "rustup show" to show compiler versions in logs
...
Trying to debug the nightly failure here
https://gitlab.torproject.org/Diziet/arti/-/pipelines/25417
and I can't seem to repro it.
2022-01-31 13:58:46 +00:00
Nick Mathewson
74838b7ba0
Changelog for 0.0.4.
2022-01-31 08:52:35 -05:00
Ian Jackson
880d5f2d36
Merge branch 'shellcheck' into 'main'
...
Add shellcheck to gitlab ci and git hook
See merge request tpo/core/arti!275
2022-01-31 13:02:36 +00:00
Ian Jackson
7f83b9fb30
maint/shellcheck_all.sh: add missing final newline
2022-01-31 12:44:27 +00:00
Daniel Schischkin
42fb7667b4
Change which command to command -v
2022-01-29 00:12:36 +01:00
Daniel Schischkin
1774de7e47
Remove redundancy/code duplication and switch to shellcheck_all.sh script
2022-01-29 00:09:36 +01:00
Daniel Schischkin
21a9ad848c
Add shellcheck script into maint directory
2022-01-29 00:09:06 +01:00
trinity-1686a
daa1eba969
add postprocessing script to deduplicate cobertura reports
2022-01-28 20:52:50 +01:00
Daniel Schischkin
1d7fcd6d48
Undo remove document-private-items arg
2022-01-28 17:44:32 +01:00
Daniel Schischkin
01b3bc85c9
Remove argument document-private-items from nightly build
2022-01-28 17:28:25 +01:00
Daniel Schischkin
67ac91a809
Add missing file ending for downgrade_dependencies in gitlab ci
2022-01-28 15:26:14 +01:00
Daniel Schischkin
09ccc1aed9
Add shellcheck to pre-push git hook
2022-01-28 15:21:47 +01:00
Daniel Schischkin
6fe0543645
Add shellcheck step into build stage
2022-01-28 15:21:28 +01:00
Daniel Schischkin
0fed438a58
Add correct file ending to maint/downgrade_dependencies
2022-01-28 15:20:54 +01:00
Nick Mathewson
af40fa4d74
WANT_FROM_OTHER_CRATES: add a few links.
2022-01-28 09:12:41 -05:00
Nick Mathewson
2f51add62f
Run "cargo update" in preparation for monday's release.
2022-01-28 08:38:54 -05:00
Nick Mathewson
5187b05c19
Use script to update README.md files.
2022-01-28 08:36:34 -05:00
Ian Jackson
427e07ec8a
Merge branch 'bug299' into 'main'
...
Make max_file_limit configurable
Closes #299
See merge request tpo/core/arti!261
2022-01-28 11:17:49 +00:00
Neel Chauhan
417809123c
Make max_file_limit configurable
2022-01-28 11:17:49 +00:00
eta
54bdab588a
Merge branch 'improve-coverage-ci-job' into 'main'
...
Improve `coverage` job in CI
See merge request tpo/core/arti!269
2022-01-28 00:28:07 +00:00
arturomf94
72a08cc295
Improve `coverage` job in CI
2022-01-28 00:28:06 +00:00
Nick Mathewson
c5fa23b336
Merge branch 'dirmgr_state_test_fix' into 'main'
...
Fix test failure in tor_dirmgr::state::test::get_microdescs_state
See merge request tpo/core/arti!268
2022-01-27 22:36:31 +00:00
Nick Mathewson
98d8171610
Fix test failure in tor_dirmgr::state::test::get_microdescs_state
...
This failure occurred because our tests use canned data to exercise
the directory state functionality, and the canned consensus has
suddenly become very expired.
There are better fixes possible, but this is a minimal one that
should get CI working on main again.
2022-01-27 17:13:38 -05:00
eta
c9feb3803b
Merge branch 'shellcheck_teardown' into 'main'
...
Fix/suppress shellcheck errors in teardown.sh
See merge request tpo/core/arti!266
2022-01-27 21:32:59 +00:00
Nick Mathewson
bc867fed65
Merge branch 'rtcompat_tests' into 'main'
...
Unit test cleanup in tor-rtcompat
See merge request tpo/core/arti!267
2022-01-27 21:25:53 +00:00
Nick Mathewson
19f878b3aa
tor-rtcompat: remove some unused code.
...
Nothing actually used these accessor functions, and it's not clear
what would. We can add them later if they're needed.
2022-01-27 15:52:59 -05:00
Nick Mathewson
f7373f8b20
tor-rtcompat: Add some miscellaneous tests
...
These probably aren't for things that will fail IRL, but it's nice
to have coverage on the code, just in case.
2022-01-27 15:48:30 -05:00
Nick Mathewson
af85262257
tor-rtcompat: Simplify test-declaration macros.
...
Now there's much less copy-and-paste.
2022-01-27 15:09:09 -05:00
Nick Mathewson
9435e4b36e
Move tor-rtcompat tests to lib.rs
...
This makes our layout more similar to our other crates, and
successfully informs our grcov exclusion pattern that these tests
are indeed tests.
Doing this knocks down the reported coverage for the tor-rtcompat
crate, but that's okay: we hadn't earned it.
I hereby promise that this commit is only code-movement.
2022-01-27 14:45:00 -05:00
Nick Mathewson
83a01725d7
Fix/suppress shellcheck errors in teardown.sh
...
Rationale: It's good to have all of our scripts pass shellcheck.
2022-01-27 14:24:12 -05:00
Nick Mathewson
1c620019c4
Merge branch 'eta/303' into 'main'
...
doc/Release.md: add note to check feature combinations
See merge request tpo/core/arti!265
2022-01-27 18:33:43 +00:00
Nick Mathewson
aa9e5515d8
with_coverage: resolve a shellcheck warning
...
Shellcheck doesn't like it when you do `rm -r "$A/$B"` : it worries
that the path might accidentally expand to /.
That shouldn't actually be possible in this case, but let's avoid
being the people who accidentally remove somebody's filesystem.
2022-01-27 12:19:35 -05:00
Nick Mathewson
5b6b0d6a7d
Once more exclude arti-bench from coverage.
...
This was added in !210 ; looks like it got removed by mistake with
!221 .
2022-01-27 12:14:32 -05:00
Nick Mathewson
40c67e5e20
with_coverage.sh: split grcov options into separate lines.
...
This makes it easier to see when they're changing, and will make
future patches easier to review.
2022-01-27 12:09:20 -05:00
eta
ecb63bafa5
doc/Release.md: add note to check feature combinations
...
This is a nice reminder to have before we solve arti#303 for good.
2022-01-27 15:53:46 +00:00
eta
2f39dbd587
Merge branch 'rtcompat-refactor' into 'main'
...
Refactor the tor-rtcompat API.
Closes #301 and #300
See merge request tpo/core/arti!263
2022-01-27 15:53:35 +00:00
Nick Mathewson
9f3ad85d75
Document why {current,create}_runtime are type-erased
2022-01-27 10:31:45 -05:00