vincenzopalazzo
/
arti
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3,704 Commits 3 Branches 23 Tags 19 MiB
Commit Graph

3704 Commits

Author SHA1 Message Date
Nick Mathewson fb672dc688 NetDoc: Make AddrPortPattern implement serde traits 
I'm using serde_with here to just re-use the Display and FromStr
implementations, since those are what has proven easier to type in
the past.
 2022-06-17 08:47:57 -04:00
Nick Mathewson 48a86506be GuardMgr: Support for multiple guard sets 
guard-spec.txt specifies that we have multiple separate samples of
guards that we can use depending on whether the filter is
restrictive or not.  Here we implement the rules for switching
between samples.
 2022-06-17 08:47:57 -04:00
Nick Mathewson e098a5a303 Move set_filter into GuardMgrInner. 
Convert its argument type to Option<&NetDir> to better match the
rest of the API.
 2022-06-17 08:47:57 -04:00
Nick Mathewson a720f4f667 GuardMgr: Function to tell how permissive a filter is. 
When we're filtering guards, we have to check whether the filter is
"restrictive": if it forbids most of the guards (by bandwidth), we
keep its guards separated from the main set.  If it is
super-restrictive, we also warn.

This functionality is specified in guard-spec.txt.
 2022-06-17 08:47:57 -04:00
Nick Mathewson 19fa946fc7 Make AddrPortPattern and friends implement Eq and PartialEq 2022-06-17 08:46:16 -04:00
Nick Mathewson e3c2a86195 GuardMgr: Also apply filters to fallback directories. 2022-06-17 08:46:16 -04:00
Nick Mathewson a189aaf1fb GuardMgr: remove disallowed addresses from returned FirstHops. 
Since a guard can have a bunch of addresses, and the guard is
permitted if any one of those addresses is permitted, then we might
decide to use a guard with some non-permitted addresses.  Thus, we
need to filter those addresses before returning the view of the
guard as a FirstHop.
 2022-06-17 08:46:16 -04:00
Nick Mathewson 23218fe037 GuardMgr: Remove old testing filter variant. 
We don't need to restrict based on bits in the key id any longer,
since we have a real filter.
 2022-06-17 08:46:16 -04:00
Nick Mathewson 9c4f31edc1 GuardMgr: Add a new filter type based on reachable addresses. 2022-06-17 08:46:16 -04:00
Nick Mathewson 801b6bec5f Guardmgr: Change the GuardFilter API. 
The guard filter is now a set of restrictions that can be placed on
allowable guards.
 2022-06-17 08:46:16 -04:00
Nick Mathewson 60eaabfb37 gitlab-ci: Use lowercase tpa tag. 
Our gitlab admins are standardizing on this variant.
 2022-06-16 10:01:07 -04:00
Nick Mathewson 0223c91b26 Merge branch 'high-level-features' into 'main' 
Add "full" and "experimental" features to arti, arti-client, and below.

Closes #499

See merge request tpo/core/arti!584
 2022-06-16 12:24:47 +00:00
Nick Mathewson 28a23e96bd Remove "rustls" from "full", for license reasons. 
Rustls uses ring, which uses code from BoringSSL, which derived from
OpenSSL before OpenSSL changed their license.  So ring is currently
under 3BSD/SSLEay licenses, which aren't GPL-compatible, which may
be a problem for some people.

See #493.
 2022-06-15 13:45:38 -04:00
Nick Mathewson 5e05573ec9 Merge branch 'clippy_20220614' into 'main' 
Fix several clippy issues, most with nightly

See merge request tpo/core/arti!588
 2022-06-15 17:34:53 +00:00
Nick Mathewson bd9bd39ef3 Add one more "allow" to tor_netdoc::parse::macros. 
Without this, clippy is error-free, but `cargo test` somehow gives a
warning.
 2022-06-15 11:52:30 -04:00
Nick Mathewson 2f0bef64a3 Permit eprintln in channel-padding test. 
There is not, apparently, an eprintln equivalent for
allow-dbg-in-tests.
 2022-06-15 11:52:30 -04:00
Nick Mathewson 647d4410bb Fix clippy::significant_drop_in_scrutinee warnings 
This is apparently a new warning from clippy nightly, documented in
https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_in_scrutinee .

I'm not in love with the temporary variables that this warning wants
me to introduce, but it does seem like a decent way to avoid some
kinds of deadlock.
 2022-06-15 11:52:30 -04:00
Nick Mathewson 425af9db91 Work around an erroneous warning from nightly clippy 2022-06-15 11:52:30 -04:00
Nick Mathewson 2d39545f8d Merge branch 'unwrap' into 'main' 
tor-netdir: testnet: Make construct_netdir infallible

See merge request tpo/core/arti!585
 2022-06-13 14:37:08 +00:00
Nick Mathewson d44dd6f44f Merge branch 'dormant_directory' into 'main' 
Use TaskSchedule to sleep in directory bootstrapping

Closes #497

See merge request tpo/core/arti!571
 2022-06-13 13:59:26 +00:00
Ian Jackson 3e035927f2 tor-netdir: testnet: Make construct_netdir infallible (rustfmt) 
Run rustfmt.  Separate commit to make review of the substantive commit
easier.
 2022-06-13 14:26:32 +01:00
Ian Jackson 7d223ac9e6 tor-netdir: testnet: Make construct_netdir infallible 
This is a *lot* of unwraps.  The function takes no parameters and
is used only for testing.  It ought to be infallible.
 2022-06-13 14:25:45 +01:00
Nick Mathewson 923a7c55e3 Document "full", "experimental" in toplevel crate documentation. 
Also, unify the features documentation format for those two crates,
and document previously undocumented features there.
 2022-06-13 09:04:02 -04:00
eta f7a9274e57 Merge branch 'option' into 'main' 
config: Be consistent about Option

Closes #488

See merge request tpo/core/arti!582
 2022-06-13 12:30:03 +00:00
eta ca38fbeaaf Merge branch 'doc' into 'main' 
tor-error: Fix a broken intra-doc link

See merge request tpo/core/arti!580
 2022-06-13 12:29:29 +00:00
Nick Mathewson 2129aee6cd DirMgr: Use scopeguard crate in place of ad hoc RAII substitutes 2022-06-13 08:28:41 -04:00
Nick Mathewson a7b406e69f Put the task schedule back when the dl task exits. 
This will allow somebody else to call bootstrap() if bootstrap() fails
the first time.
 2022-06-13 08:28:41 -04:00
Nick Mathewson 430f4ffb86 New API to expose and use TaskHandle from DirMgr. 
This change also means that we need to create the handle and scheduler
earlier in the process of creating the DirMgr.  If we don't, we won't
have a way to manage the task before bootstrap() returns.
 2022-06-13 08:28:41 -04:00
Nick Mathewson ef4364f465 Add "full" and "experimental" features to arti. 2022-06-10 15:35:00 -04:00
Nick Mathewson 8a586a40fa Add "full" and "experimental" features to arti-client and below. 
The "full" feature is a catch-all for all features, _except_:

   * Those that select a particular implementation (like
     tor-llcrypto/with-openssl) or build flag (like "static")
   * Those that are experimental or unstable (like "experimental-api")
   * Those that are testing-only.
 2022-06-10 15:32:21 -04:00
Nick Mathewson 171b406b00 DirMgr: Refactor bootstrap to use a TaskSchedule for sleeping. 
This change (not yet exposed as an API) will let the TorClient have
a `TaskHandle` corresponding to the directory task, letting it
make the directory task dormant as needed.
 2022-06-10 13:59:30 -04:00
Nick Mathewson 947bbe6fe7 TaskSchedule: Add a sleep_until_wallclock method too. 2022-06-10 13:59:30 -04:00
Nick Mathewson e7681ca135 Merge branch 'nested-read-write' into 'main' 
tor-bytes: read_nested_*: Take a closure

Closes #498

See merge request tpo/core/arti!579
 2022-06-10 14:27:08 +00:00
Nick Mathewson 4f6c4f91c9 Merge branch 'channel' into 'main' 
Have channel reactor able to send channel padding

See merge request tpo/core/arti!574
 2022-06-10 13:28:51 +00:00
Ian Jackson d22f6007f0 config: document semver change 2022-06-10 14:28:36 +01:00
Ian Jackson baca49e087 config: Suppose that we might extend resolve_option to non-T::Default 
As per point 3 in
  https://gitlab.torproject.org/tpo/core/arti/-/issues/488
 2022-06-10 14:23:16 +01:00
Ian Jackson 77f33176c3 config: Do not strip_option for journald (and in future) 
As per point 1 in
  https://gitlab.torproject.org/tpo/core/arti/-/issues/488
 2022-06-10 14:23:13 +01:00
Ian Jackson abea103bb0 tor-error: Fix a broken intra-doc link 
I didn't spot this in review amongst the other messages from Nightly.
 2022-06-10 13:45:30 +01:00
Ian Jackson 03a19f3877 tor-bytes: read_nested_*: rustfmt 
I disagree with almost all of these layout decisions...
 2022-06-10 12:30:22 +01:00
Ian Jackson 8fe63b3192 tor-bytes: read_nested_*: Take a closure 
This eliminates the possibility of writing the bug of failing to call
`should_be_exhausted`.

As per this discussion
  https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/572#note_2811464

Fixes #498
 2022-06-10 12:27:00 +01:00
Ian Jackson a38c86a020 Merge branch 'format-ids' into 'main' 
Replace four very similar "ids in request"

See merge request tpo/core/arti!577
 2022-06-10 11:21:15 +00:00
Ian Jackson dc387e10a6 dirclient: Fix comments re conssensus request without authorities 2022-06-10 11:25:34 +01:00
Ian Jackson 605a988a60 Merge branch 'typos' into 'main' 
Fix typos

See merge request tpo/core/arti!578
 2022-06-10 10:19:37 +00:00
Dimitris Apostolou 9bbb0cf3dd
Fix typos 2022-06-10 07:03:50 +03:00
Ian Jackson 8731e45001 Merge branch 'nested-read-write' into 'main' 
Introduce and use nested length reader/writers

See merge request tpo/core/arti!572
 2022-06-09 16:46:19 +00:00
Nick Mathewson a2c6bd08fe Fix typos in docs and comments 2022-06-09 17:08:56 +01:00
Ian Jackson bcf3bca211 tor-cell: udp: Remove manual length calculations 
This does away entirely with `wire_addr_len`, which recapitulates the
length calculation.
 2022-06-09 17:08:56 +01:00
Ian Jackson 6f92bf9e86 tor-bytes: Provide nested writers 2022-06-09 17:08:56 +01:00
Ian Jackson a6a48c3c28 tor-bytes: Provide nested readers 2022-06-09 17:08:56 +01:00
Ian Jackson 04bca2e75a tor-bytes: Reader: Provide take_rest 
We'll want this in a moment.
 2022-06-09 17:08:56 +01:00