6d3fb11bc6
df-tests: patch for state == AWAITING_UNILATERAL problem
...
Found on CI where DEVELOPER=0 EXPERIMENTAL_DUAL_FUND=1,
as we turn off automatic reconnects when DEVELOPER=1
This test has been modified to make the error happen every time, and
then fixed.
lightningd-2: 2021-05-07T20:12:03.790Z DEBUG 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-chan#1: Peer has reconnected, state AWAITING_UNILATERAL
lightningd-2: 2021-05-07T20:12:03.812Z **BROKEN** lightningd: FATAL SIGNAL 6 (version e8b3f78)
lightningd-2: 2021-05-07T20:12:03.812Z **BROKEN** lightningd: backtrace: common/daemon.c:44 (send_backtrace) 0x56384ee072e9
lightningd-2: 2021-05-07T20:12:03.813Z **BROKEN** lightningd: backtrace: common/daemon.c:52 (crashdump) 0x56384ee0733b
----------------------------- Captured stderr call -----------------------------
lightningd: lightningd/peer_control.c:1100: peer_connected_hook_final: Assertion `channel->state == DUALOPEND_OPEN_INIT || channel->state == DUALOPEND_AWAITING_LOCKIN' failed.
lightningd: FATAL SIGNAL 6 (version e8b3f78)
0x56384ee072a1 send_backtrace
common/daemon.c:39
0x56384ee0733b crashdump
common/daemon.c:52
0x7f88486a020f ???
???:0
0x7f88486a018b ???
???:0
0x7f884867f858 ???
???:0
0x7f884867f728 ???
???:0
0x7f8848690f35 ???
???:0
0x56384eddc94e peer_connected_hook_final
lightningd/peer_control.c:1100
0x56384edea2ed plugin_hook_call_
lightningd/plugin_hook.c:275
0x56384eddfeb8 plugin_hook_call_peer_connected
lightningd/peer_control.c:1156
0x56384eddfeb8 peer_connected
lightningd/peer_control.c:1209
0x56384edc30cd connectd_msg
lightningd/connect_control.c:332
0x56384edebe6f sd_msg_read
lightningd/subd.c:509
0x56384edebfb1 read_fds
lightningd/subd.c:310
0x56384ee483b0 next_plan
ccan/ccan/io/io.c:59
0x56384ee4885b do_plan
ccan/ccan/io/io.c:407
0x56384ee488f8 io_ready
ccan/ccan/io/io.c:417
0x56384ee4a23c io_loop
ccan/ccan/io/poll.c:445
0x56384edcabda io_loop_with_timers
lightningd/io_loop_with_timers.c:24
0x56384edce826 main
lightningd/lightningd.c:1111
0x7f88486810b2 ???
???:0
0x56384edb52ad ???
???:0
0xffffffffffffffff ???
???:0
2021-05-12 11:25:41 +09:30
342f783f53
df-tests: Turn on v2 tests on CI
...
Let's run more tests with the v2 open protocol
2021-05-12 11:25:41 +09:30
558abe288a
tests: explicitly mark tests to run both as v1+v2
...
By default, tests only run as v1 unless marked as v2.
These tests we want to run as both v1+v2
Includes fixes to have tests pass
2021-05-12 11:25:41 +09:30
dc758f616b
tests: mark as v1 or v2 openchannel required
2021-05-12 11:25:41 +09:30
3a2d602922
tests: add marker for v1/v2 channel opens
...
Tests that will only run when !EXPERIMENTAL_DUAL_FUND:
@pytest.marker.openchannel('v1')
def test_...()
Tests that will only run when EXPERIMENTAL_DUAL_FUND:
@pytest.marker.openchannel('v2')
def test_...()
2021-05-12 11:25:41 +09:30
d0bbf07655
tests: not DEVELOPER -> mark.developer
...
Nicer syntaxtic sugar for marking pytests as 'developer required'
2021-05-12 11:25:41 +09:30
b4e24ac8ba
df: anchor outputs are on if EXP_DF
...
So we should treat it the same as EXPERIMENTAL_FEATURES
2021-05-12 11:25:41 +09:30
484d6bde83
tests: move EXP_DF into the testing utils
2021-05-12 11:25:41 +09:30
7a488cc11e
df-tests: remove df_accepter plugin
...
The `funder` plugin, does the same stuff as this temporary test plugin,
so we move over to using that instead.
2021-05-12 11:25:41 +09:30
de854fa9d4
psbt: really hacky patch over libwally's 0-input txs parse fail
...
Issue being tracked at https://github.com/ElementsProject/libwally-core/pull/273
2021-05-12 11:25:41 +09:30
ef9d8bcd5a
dual-fund: reconnections were borked, this fixes them
2021-05-12 11:25:41 +09:30
09b5c906fd
funder, startupregtest: fixup default config to be 100
...
Fails on start otherwise
2021-05-12 11:25:41 +09:30
6dc954bb91
df-bugs: rm duplicate call to channeld
...
This gets called from channel_set_owner, which both `delete_channel` and
the `channel_fail_reconnect` pathways call.
Fixes crash
------------------------------------------------------ Captured stderr teardown -------------------------------------------------------
lightning_connectd: peer_disconnected unknown peer: 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518 (version v0.10.0-144-gfaf98c9)
0x560e90d59d08 send_backtrace
common/daemon.c:39
0x560e90d648a5 status_failed
common/status.c:214
0x560e90d50e8f peer_disconnected
connectd/connectd.c:1606
0x560e90d510d5 recv_req
connectd/connectd.c:1662
0x560e90d5a266 handle_read
common/daemon_conn.c:31
0x560e90d98ccb next_plan
ccan/ccan/io/io.c:59
0x560e90d998b0 do_plan
ccan/ccan/io/io.c:407
0x560e90d998f2 io_ready
ccan/ccan/io/io.c:417
0x560e90d9bb8a io_loop
ccan/ccan/io/poll.c:445
0x560e90d512c8 main
connectd/connectd.c:1735
0x7fbdb828b0b2 ???
???:0
0x560e90d4a6dd ???
???:0
0xffffffffffffffff ???
???:0
2021-05-11 15:37:24 +09:30
e960b1015d
!fixup
...
Log this so I can try to find dual fund connnectd race.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-11 11:25:16 +09:30
d8e68893f5
bcli: become less aggressive with onchain fee levels.
...
Users are more upset recently with the cost of unilateral closes
than they are the risk of being cheated. While we complete our
anchor implementation so we can use low fees there, let's
get less aggressive (we already have 34 or 18 blocks to close
in the worst case).
The changes are:
- Commit transactions were "2 CONSERVATIVE" now "6 ECONOMICAL".
- HTLC resolution txs were "3 CONSERVATIVE" now "6 ECONOMICAL".
- Penalty txs were "3 CONSERVATIVE" now "12 ECONOMICAL".
- Normal txs were "4 ECONOMICAL" now "12 ECONOMICAL".
There can be no perfect levels, but we have had understandable
complaints recently about how high our default fee levels are.
Changelog-Changed: Protocol: channel feerates reduced to bitcoind's "6 block ECONOMICAL" rate.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-11 11:25:16 +09:30
9a22e7b3a1
plugins/bcli: make feerate calls more changeable.
...
This make it clearer what we're doing, IMHO, so we can easily alter
the levels if we want.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-11 11:25:16 +09:30
9825f32874
lightningd: implement --log-timestamps=false.
...
Fixes : #4494
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: config: New option `log-timestamps` allow disabling of timestamp prefix in logs.
2021-05-05 17:19:19 -05:00
96acafcef3
libhsmd: Prefix check_client_capabilities
...
I wante to hide it inside the library, but it is good to have a single
place to verify that the client was permitted to send a message we are
handling, so make it officially part of the interface by prefixing it.
2021-05-04 11:18:52 +09:30
fb2b107bef
libhsmd: Cleanup the bip32_key_version
2021-05-04 11:18:52 +09:30
4d43e84afd
libhsmd: Finalize encapsulation of hsmd data in libhsmd
...
Changelog-Added: libhsmd: Extracted the `hsmd` logic into its own library for other projects to use
2021-05-04 11:18:52 +09:30
c9e9581b35
libhsmd: Migrate bolt12 initialization into hsmd_init
2021-05-04 11:18:52 +09:30
d30392c432
libhsmd: Start migrating initialization to hsmd_init
2021-05-04 11:18:52 +09:30
befa7fb9f0
libhsmd: Clean up includes in hsmd.c
2021-05-04 11:18:52 +09:30
1efa792edc
libhsmd: Migrate handle_sign_delayer_payment_to_us
2021-05-04 11:18:52 +09:30
fe82181fe3
libhsmd: Migrate handle_sign_remote_htlc_to_us
2021-05-04 11:18:52 +09:30
e643594104
libhsmd: handle_sign_commitment_tx
2021-05-04 11:18:52 +09:30
4764ebd879
libhsmd: Migrate handle_sign_penalty_to_us
2021-05-04 11:18:52 +09:30
bee7a65170
libhsmd: Migrate handle_sign_remote_commitment_tx
2021-05-04 11:18:52 +09:30
c2d035d377
libhsmd: Migrate handle_sign_remote_htlc_tx
2021-05-04 11:18:52 +09:30
7b2c6ec4d3
libhsmd: Migrate handle_sign_local_htlc_tx
2021-05-04 11:18:52 +09:30
cd8fb641cf
libhsmd: Migrate handle_sign_mutual_tx
2021-05-04 11:18:52 +09:30
9aa4b5198d
libhsmd: Migrate handle_sign_withdrawal_tx
2021-05-04 11:18:52 +09:30
e7007a7f36
libhsmd: Migrate handle_get_per_commitment_point
2021-05-04 11:18:52 +09:30
eab4aeaed3
libhsmd: Migrate handle_channel_update_sig
2021-05-04 11:18:52 +09:30
166f0ade04
libhsmd: Migrate handle_sign_node_announcement
2021-05-04 11:18:52 +09:30
4a3f24a737
libhsmd: Migrate handle_cannouncement_sig
2021-05-04 11:18:52 +09:30
e9cc8644b6
libhsmd: Migrate handle_get_output_scriptpubkey
2021-05-04 11:18:52 +09:30
ec5d40c0e7
libhsmd: Migrate handle_check_future_secret
2021-05-04 11:18:52 +09:30
0e61ed32e3
libhsmd: Migrate handle_ecdh
2021-05-04 11:18:52 +09:30
d1b3a5b1aa
libhsmd: Migrate handle_get_channel_basepoints
2021-05-04 11:18:52 +09:30
2cb25a16e0
libhsmd: Migrate handle_sign_invoice
2021-05-04 11:18:52 +09:30
79ec4b4808
libhsmd: Migrate handle_sign_bolt12
2021-05-04 11:18:52 +09:30
3d959e128d
libhsmd: Add dispatcher function
2021-05-04 11:18:52 +09:30
ac836bbd1b
libhsmd: Add status functions to report to whoever is listening
...
These are currently just shims that replicate the old behavior, but
when compiling as a library we can relink the status_* functions to
something that makes sense in the context of the user, and not assume
we're running as a subdaemon.
2021-05-04 11:18:52 +09:30
b5a2ddd384
libhsmd: Migrate check_client_capabilities to libhsmd
2021-05-04 11:18:52 +09:30
ed4676bea8
libhsmd: Add scaffolding to start separating hsmd from io logic
2021-05-04 11:18:52 +09:30
ae06bb91ed
plugins/bcli: strip trailing whitespace appropriately
...
Changelog-Fixed: Handle windows-style newlines and other trailing whitespaces correctly in bitcoin-cli interface
2021-05-03 19:00:26 +09:30
ff6b26b70e
plugins/funder: fix up compilation.
...
I merge Christian's plugin notification API change at the same
time, broke plugins/funder.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-05-03 11:42:04 +09:30
c58b15de19
docs: Document the custom plugin notifications
2021-05-03 11:20:15 +09:30
ef7f9a8022
pay: Add pay_failure notification
2021-05-03 11:20:15 +09:30
niftynei
Rusty Russell
Christian Decker
Nalin Bhardwaj