vincenzopalazzo
/
rt-tests
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rt-tests: Remove the ret variable, the end label and the goto. 

Remove the ret variable, the end lable and the goto. We already have
inconsistent exit points for the function, and the end lable wasn't strictly
for errors. Directly returning simplifies and shortens the code.

Signed-off-by: John Kacur <jkacur@redhat.com>
This commit is contained in:
John Kacur 2010-01-27 19:47:03 +01:00
parent 51dfab754a
commit 522560b82f
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/cyclictest/rt_numa.h
View File

@ -73,7 +73,7 @@ static int rt_numa_numa_node_of_cpu(int cpu)
static int rt_numa_numa_node_of_cpu(int cpu)
{
unsigned char cpumask[16];
int node, ret, idx, bit;
int node, idx, bit;
int max_node, max_cpus;
max_node = numa_max_node();
@ -88,19 +88,15 @@ static int rt_numa_numa_node_of_cpu(int cpu)
idx = cpu / 8;
bit = cpu % 8;
for (node = 0; node <= max_node; node++){
for (node = 0; node <= max_node; node++) {
if (numa_node_to_cpus(node, (void *) cpumask, sizeof(cpumask)))
return -1;
if (cpumask[idx] & (1<<bit)) {
ret = node;
goto end;
}
if (cpumask[idx] & (1<<bit))
return node;
}
ret = -1;
errno = EINVAL;
end:
return ret;
return -1;
}
#endif /* LIBNUMA_API_VERSION */